From: Robert Griesemer <gri@golang.org>
Date: Thu, 24 Feb 2011 19:13:20 +0000 (-0800)
Subject: godoc: fix writeFileAtomically utility function
X-Git-Tag: weekly.2011-02-24~9
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=c9021a1afec280134638a1ffb15597354fee269c;p=gostls13.git

godoc: fix writeFileAtomically utility function

If the filename was absolute, writeFileAtomically
used the wrong filename for ioutil.TempFile leading
to non-existent directories and the TempFile would
fail.

R=r, r2
CC=golang-dev
https://golang.org/cl/4224043
---

diff --git a/src/cmd/godoc/utils.go b/src/cmd/godoc/utils.go
index cc028cc4d7..d21e7e9863 100644
--- a/src/cmd/godoc/utils.go
+++ b/src/cmd/godoc/utils.go
@@ -95,7 +95,7 @@ func canonicalizePaths(list []string, filter func(path string) bool) []string {
 // atomically renames that file to the file named by filename.
 //
 func writeFileAtomically(filename string, data []byte) os.Error {
-	f, err := ioutil.TempFile(cwd, filename)
+	f, err := ioutil.TempFile(pathutil.Split(filename))
 	if err != nil {
 		return err
 	}