From: Bryan C. Mills <bcmills@google.com>
Date: Tue, 2 May 2023 16:43:04 +0000 (-0400)
Subject: cmd/go: remove a redundant HasExec check in TestScript/README
X-Git-Tag: go1.21rc1~693
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=ca49b8d7af25a51309af277c27724b01bd80453f;p=gostls13.git

cmd/go: remove a redundant HasExec check in TestScript/README

The test checks testenv.HasExec right before calling testenv.Command,
but testenv.Command already skips the test if HasExec is false.

Change-Id: I04716bf823a1b76640394a964973ff34c65afb1f
Reviewed-on: https://go-review.googlesource.com/c/go/+/491658
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Matloob <matloob@golang.org>
---

diff --git a/src/cmd/go/scriptreadme_test.go b/src/cmd/go/scriptreadme_test.go
index fde1e8e9f8..2a842fbc0f 100644
--- a/src/cmd/go/scriptreadme_test.go
+++ b/src/cmd/go/scriptreadme_test.go
@@ -37,10 +37,6 @@ func checkScriptReadme(t *testing.T, engine *script.Engine, env []string) {
 	}
 	args.Conditions = conds.String()
 
-	if !testenv.HasExec() {
-		t.Skipf("updating script README requires os/exec")
-	}
-
 	doc := new(strings.Builder)
 	cmd := testenv.Command(t, testGo, "doc", "cmd/go/internal/script")
 	cmd.Env = env