From: Scott Lawrence <bytbox@gmail.com>
Date: Mon, 31 Oct 2011 23:07:17 +0000 (-0700)
Subject: template: fix error checking on execute without parse
X-Git-Tag: weekly.2011-11-01~13
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=cae23f036ac639141153a73551bcabbb7169e9e0;p=gostls13.git

template: fix error checking on execute without parse

Fixed error checking in exec.go to give a sensible error message when
execution is attempted before a successful parse (rather than an
outright panic).

R=r
CC=golang-dev
https://golang.org/cl/5306065
---

diff --git a/src/pkg/exp/template/html/escape_test.go b/src/pkg/exp/template/html/escape_test.go
index a4ea7596cd..1b3b256733 100644
--- a/src/pkg/exp/template/html/escape_test.go
+++ b/src/pkg/exp/template/html/escape_test.go
@@ -1549,8 +1549,8 @@ func TestEnsurePipelineContains(t *testing.T) {
 	}
 }
 
-func expectExecuteFailure(t *testing.T, b *bytes.Buffer) {
-	if x := recover(); x != nil {
+func expectExecuteFailure(t *testing.T, b *bytes.Buffer, err os.Error) {
+	if err != nil {
 		if b.Len() != 0 {
 			t.Errorf("output on buffer: %q", b.String())
 		}
@@ -1563,8 +1563,8 @@ func TestEscapeErrorsNotIgnorable(t *testing.T) {
 	var b bytes.Buffer
 	tmpl := template.Must(template.New("dangerous").Parse("<a"))
 	Escape(tmpl)
-	defer expectExecuteFailure(t, &b)
-	tmpl.Execute(&b, nil)
+	err := tmpl.Execute(&b, nil)
+	expectExecuteFailure(t, &b, err)
 }
 
 func TestEscapeSetErrorsNotIgnorable(t *testing.T) {
@@ -1574,8 +1574,8 @@ func TestEscapeSetErrorsNotIgnorable(t *testing.T) {
 	}
 	EscapeSet(s, "t")
 	var b bytes.Buffer
-	defer expectExecuteFailure(t, &b)
-	s.Execute(&b, "t", nil)
+	err = s.Execute(&b, "t", nil)
+	expectExecuteFailure(t, &b, err)
 }
 
 func TestRedundantFuncs(t *testing.T) {
diff --git a/src/pkg/template/exec.go b/src/pkg/template/exec.go
index e7fad72fe7..34c6633232 100644
--- a/src/pkg/template/exec.go
+++ b/src/pkg/template/exec.go
@@ -97,7 +97,7 @@ func (t *Template) Execute(wr io.Writer, data interface{}) (err os.Error) {
 		line: 1,
 		vars: []variable{{"$", value}},
 	}
-	if t.Root == nil {
+	if t.Tree == nil || t.Root == nil {
 		state.errorf("must be parsed before execution")
 	}
 	state.walk(value, t.Root)