From: David Symonds Date: Thu, 11 Jun 2009 22:55:03 +0000 (-0700) Subject: Switch http client_test to use google.com/robots.txt to avoid redirect loop. X-Git-Tag: weekly.2009-11-06~1408 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=cbd00921737ccf6fd3c3ea0168649c558d0ba5f5;p=gostls13.git Switch http client_test to use google.com/robots.txt to avoid redirect loop. www.google.com seems to be redirecting requests in an infinite loop. I haven't tracked down whether it's their code or this code that is causing it. This is just a quick fix so that this test passes. APPROVED=r DELTA=4 (0 added, 0 deleted, 4 changed) OCL=30178 CL=30210 --- diff --git a/src/pkg/http/client_test.go b/src/pkg/http/client_test.go index e9354fc40d..6cde4a41ca 100644 --- a/src/pkg/http/client_test.go +++ b/src/pkg/http/client_test.go @@ -16,9 +16,9 @@ import ( func TestClient(t *testing.T) { // TODO: add a proper test suite. Current test merely verifies that - // we can retrieve the Google home page. - - r, url, err := Get("http://www.google.com"); + // we can retrieve the Google robots.txt file. + + r, url, err := Get("http://www.google.com/robots.txt"); var b []byte; if err == nil { b, err = io.ReadAll(r.Body); @@ -33,8 +33,8 @@ func TestClient(t *testing.T) { t.Errorf("Error fetching URL: %v", err); } else { s := string(b); - if (!strings.HasPrefix(s, "")) { - t.Errorf("Incorrect page body (did not begin with ): %q", s); + if (!strings.HasPrefix(s, "User-agent:")) { + t.Errorf("Incorrect page body (did not begin with User-agent): %q", s); } } }