From: Bryan C. Mills <bcmills@google.com>
Date: Thu, 11 Apr 2019 20:35:56 +0000 (-0400)
Subject: cmd/go: log failures to remove workdir
X-Git-Tag: go1.13beta1~727
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=ccaa4913864d49137012d04a0cd3ddf2d8ffc015;p=gostls13.git

cmd/go: log failures to remove workdir

Failures here don't otherwise affect the build, but they do cause a
slow file leak in the user's temp directory. The user deserves at
least a cursory warning that something may be amiss.

Updates #30789

Change-Id: Id0e72b1967e7f7c88cdc94d532554496653f264b
Reviewed-on: https://go-review.googlesource.com/c/go/+/171764
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
---

diff --git a/src/cmd/go/internal/work/action.go b/src/cmd/go/internal/work/action.go
index 415df94f4a..052811d34a 100644
--- a/src/cmd/go/internal/work/action.go
+++ b/src/cmd/go/internal/work/action.go
@@ -242,7 +242,11 @@ func (b *Builder) Init() {
 		}
 		if !cfg.BuildWork {
 			workdir := b.WorkDir
-			base.AtExit(func() { os.RemoveAll(workdir) })
+			base.AtExit(func() {
+				if err := os.RemoveAll(workdir); err != nil {
+					fmt.Fprintf(os.Stderr, "go: failed to remove work dir: %s\n", err)
+				}
+			})
 		}
 	}