From: Dave Cheney <dave@cheney.net>
Date: Thu, 30 Apr 2015 01:57:34 +0000 (+1000)
Subject: misc/cgo/testcshared, misc/cgo/testshared: fix clang warnings and errors
X-Git-Tag: go1.5beta1~807
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=ccaaf1f13417b4fdc56ac571f22f8b6dd8c7c8e1;p=gostls13.git

misc/cgo/testcshared, misc/cgo/testshared: fix clang warnings and errors

Fix several warnings generated on the linux-amd64-clang builder
and make it clear to clang that -znow is a linker only flag.

Tested with

    env CC=clang-3.5 ./all.bash
    env CC=gcc-4.8 ./all.bash

Change-Id: I5ca7366ba8bf6221a36d25a2157dda4b4f3e16fa
Reviewed-on: https://go-review.googlesource.com/9523
Reviewed-by: Ian Lance Taylor <iant@golang.org>
---

diff --git a/misc/cgo/testcshared/main0.c b/misc/cgo/testcshared/main0.c
index fa0eb4a09e..7fe0a27ff8 100644
--- a/misc/cgo/testcshared/main0.c
+++ b/misc/cgo/testcshared/main0.c
@@ -5,6 +5,10 @@
 #include <stdint.h>
 #include <stdio.h>
 
+extern int8_t DidInitRun(void);
+extern int8_t DidMainRun(void);
+extern int32_t FromPkg(void);
+
 // Tests libgo.so to export the following functions.
 //   int8_t DidInitRun();
 //   int8_t DidMainRun();
diff --git a/src/cmd/internal/ld/lib.go b/src/cmd/internal/ld/lib.go
index b14a6c1b50..44389c9fa8 100644
--- a/src/cmd/internal/ld/lib.go
+++ b/src/cmd/internal/ld/lib.go
@@ -946,7 +946,7 @@ func hostlink() {
 		// We force all symbol resolution to be done at program startup
 		// because lazy PLT resolution can use large amounts of stack at
 		// times we cannot allow it to do so.
-		argv = append(argv, "-znow")
+		argv = append(argv, "-Wl,-znow")
 	}
 
 	argv = append(argv, "-o")