From: Brad Fitzpatrick Date: Thu, 14 Feb 2013 02:33:15 +0000 (-0800) Subject: net/http: test that we preserve Go 1.0 Request.Write Host behavior X-Git-Tag: go1.1rc2~1046 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=cd566958e938c695d09730dfcb7c2b8e76658f89;p=gostls13.git net/http: test that we preserve Go 1.0 Request.Write Host behavior Fixes #4792 R=golang-dev, rsc CC=golang-dev https://golang.org/cl/7314093 --- diff --git a/src/pkg/net/http/requestwrite_test.go b/src/pkg/net/http/requestwrite_test.go index fc3186f0c0..3a5cd8ae2d 100644 --- a/src/pkg/net/http/requestwrite_test.go +++ b/src/pkg/net/http/requestwrite_test.go @@ -328,6 +328,31 @@ var reqWriteTests = []reqWriteTest{ "User-Agent: Go http package\r\n" + "X-Foo: X-Bar\r\n\r\n", }, + + // If no Request.Host and no Request.URL.Host, we send + // an empty Host header, and don't use + // Request.Header["Host"]. This is just testing that + // we don't change Go 1.0 behavior. + { + Req: Request{ + Method: "GET", + Host: "", + URL: &url.URL{ + Scheme: "http", + Host: "", + Path: "/search", + }, + ProtoMajor: 1, + ProtoMinor: 1, + Header: Header{ + "Host": []string{"bad.example.com"}, + }, + }, + + WantWrite: "GET /search HTTP/1.1\r\n" + + "Host: \r\n" + + "User-Agent: Go http package\r\n\r\n", + }, } func TestRequestWrite(t *testing.T) {