From: Michael Pratt <mpratt@google.com>
Date: Wed, 21 May 2025 17:36:42 +0000 (-0400)
Subject: runtime: skip windows stack tests in race mode
X-Git-Tag: go1.25rc1~144
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=ce49eb488af1c5273b226b3b52a8cbd7eae63a51;p=gostls13.git

runtime: skip windows stack tests in race mode

These became race instrumented in CL 643897, but race mode uses more
memory, so the test doesn't make much sense.

For #71395.

Change-Id: I6a6a636cf09ba29625aa9a22550314845fb2e611
Reviewed-on: https://go-review.googlesource.com/c/go/+/675077
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
---

diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go
index 34e33169d5..c5d7303261 100644
--- a/src/runtime/crash_cgo_test.go
+++ b/src/runtime/crash_cgo_test.go
@@ -597,6 +597,9 @@ func TestWindowsStackMemoryCgo(t *testing.T) {
 	if runtime.GOOS != "windows" {
 		t.Skip("skipping windows specific test")
 	}
+	if race.Enabled {
+		t.Skip("skipping test: race mode uses more stack memory")
+	}
 	testenv.SkipFlaky(t, 22575)
 	o := runTestProg(t, "testprogcgo", "StackMemory")
 	stackUsage, err := strconv.Atoi(o)
diff --git a/src/runtime/syscall_windows_test.go b/src/runtime/syscall_windows_test.go
index 6709267403..ad9bfb464b 100644
--- a/src/runtime/syscall_windows_test.go
+++ b/src/runtime/syscall_windows_test.go
@@ -7,6 +7,7 @@ package runtime_test
 import (
 	"fmt"
 	"internal/abi"
+	"internal/race"
 	"internal/syscall/windows/sysdll"
 	"internal/testenv"
 	"io"
@@ -668,6 +669,9 @@ func TestWERDialogue(t *testing.T) {
 }
 
 func TestWindowsStackMemory(t *testing.T) {
+	if race.Enabled {
+		t.Skip("skipping test: race mode uses more stack memory")
+	}
 	o := runTestProg(t, "testprog", "StackMemory")
 	stackUsage, err := strconv.Atoi(o)
 	if err != nil {