From: Brad Fitzpatrick Date: Sat, 8 Nov 2014 18:13:28 +0000 (-0300) Subject: net/http: fix benchmark goroutine leak X-Git-Tag: go1.4rc1~32 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=cf105e2fa04bb001a2331cabba2437a59760562b;p=gostls13.git net/http: fix benchmark goroutine leak New detection because of net/http now using TestMain. Fixes #9033 LGTM=iant R=golang-codereviews, iant CC=adg, golang-codereviews, rsc https://golang.org/cl/170210043 --- diff --git a/src/net/http/serve_test.go b/src/net/http/serve_test.go index bb44ac8537..5e0a0053c0 100644 --- a/src/net/http/serve_test.go +++ b/src/net/http/serve_test.go @@ -2819,6 +2819,7 @@ func benchmarkClientServerParallel(b *testing.B, parallelism int, useTLS bool) { InsecureSkipVerify: true, }, } + defer noVerifyTransport.CloseIdleConnections() client := &Client{Transport: noVerifyTransport} for pb.Next() { res, err := client.Get(ts.URL)