From: Alan Donovan <adonovan@google.com>
Date: Tue, 11 Mar 2014 02:22:51 +0000 (-0400)
Subject: net/http: eliminate defined-but-not-used var.
X-Git-Tag: go1.3beta1~404
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=cf57cf17e785e0e1c36c522067490b9a806e9cb1;p=gostls13.git

net/http: eliminate defined-but-not-used var.

gc does not report this as an error, but go/types does.
(I suspect that constructing a closure counts as a reference
to &all in gc's implementation).

This is not a tool bug, since the spec doesn't require
implementations to implement this check, but it does
illustrate that dialect variations are always a nuisance.

LGTM=rsc, bradfitz
R=bradfitz
CC=golang-codereviews, gri, rsc
https://golang.org/cl/73850043
---

diff --git a/src/pkg/net/http/client_test.go b/src/pkg/net/http/client_test.go
index 1f8a8b12cf..7f1c4b1392 100644
--- a/src/pkg/net/http/client_test.go
+++ b/src/pkg/net/http/client_test.go
@@ -886,11 +886,9 @@ func TestClientTimeout(t *testing.T) {
 		t.Fatal("handler never got /slow request")
 	}
 
-	var all []byte
 	errc := make(chan error, 1)
 	go func() {
-		var err error
-		all, err = ioutil.ReadAll(res.Body)
+		_, err := ioutil.ReadAll(res.Body)
 		errc <- err
 		res.Body.Close()
 	}()