From: Tobias Klauser <tklauser@distanz.ch>
Date: Sat, 24 Oct 2020 18:21:48 +0000 (+0200)
Subject: cmd/dist: document why test fails on incomplete ports
X-Git-Tag: go1.16beta1~546
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=d03437a7c228c6842ad81b4d6e7dabea913cdc5f;p=gostls13.git

cmd/dist: document why test fails on incomplete ports

It might not be obvious from reading the code why we consider the test
as failed on incomplete ports even though it passed. Add a comment
documenting this behavior, as suggested by Dmitri in CL 155839.

Change-Id: I3eb7db27d01d63db277172381e5fa51577dad941
Reviewed-on: https://go-review.googlesource.com/c/go/+/264682
Trust: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
---

diff --git a/src/cmd/dist/test.go b/src/cmd/dist/test.go
index 09d69f72ed..dbe55a7c38 100644
--- a/src/cmd/dist/test.go
+++ b/src/cmd/dist/test.go
@@ -217,6 +217,9 @@ func (t *tester) run() {
 		fmt.Println("\nFAILED")
 		xexit(1)
 	} else if incomplete[goos+"/"+goarch] {
+		// The test succeeded, but consider it as failed so we don't
+		// forget to remove the port from the incomplete map once the
+		// port is complete.
 		fmt.Println("\nFAILED (incomplete port)")
 		xexit(1)
 	} else if t.partial {