From: Dmitriy Vyukov <dvyukov@google.com>
Date: Tue, 4 Mar 2014 07:42:02 +0000 (+0400)
Subject: cmd/go: fix data race on buildLdflags
X-Git-Tag: go1.3beta1~494
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=d1c6c6004be6d2c3ad030c5c1ef5ae1c84c7d293;p=gostls13.git

cmd/go: fix data race on buildLdflags
Fixes #7438.

LGTM=rsc
R=golang-codereviews
CC=bradfitz, golang-codereviews, iant, rsc
https://golang.org/cl/70420044
---

diff --git a/src/cmd/go/build.go b/src/cmd/go/build.go
index 6c9b9f7e50..bf30be70e4 100644
--- a/src/cmd/go/build.go
+++ b/src/cmd/go/build.go
@@ -1714,6 +1714,8 @@ func (gcToolchain) ld(b *builder, p *Package, out string, allactions []*action,
 		}
 	}
 	ldflags := buildLdflags
+	// Limit slice capacity so that concurrent appends do not race on the shared array.
+	ldflags = ldflags[:len(ldflags):len(ldflags)]
 	if buildContext.InstallSuffix != "" {
 		ldflags = append(ldflags, "-installsuffix", buildContext.InstallSuffix)
 	}