From: Rajat Goel Date: Tue, 10 Feb 2015 01:12:12 +0000 (-0800) Subject: net/http: fix test to check that requests to 'localhost' are not proxied X-Git-Tag: go1.5beta1~2068 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=d34ee29a52ac4c99cb2b88873b239cd2c8407c3b;p=gostls13.git net/http: fix test to check that requests to 'localhost' are not proxied I think the test was meant to test requests to 'localhost:80' instead of 'localhost:80:80'. It passes even with 'localhost:80:80' because net.SplitHostPort fails inside useProxy. Please comment if you want to leave old 'localhost:80' is the list too to check old code path. Change-Id: Ic4cd21901563449e3d4e2f4c8caf723f4ca15bac u Reviewed-on: https://go-review.googlesource.com/4293 Reviewed-by: Brad Fitzpatrick --- diff --git a/src/net/http/proxy_test.go b/src/net/http/proxy_test.go index b6aed3792b..823d1447ee 100644 --- a/src/net/http/proxy_test.go +++ b/src/net/http/proxy_test.go @@ -18,7 +18,7 @@ var UseProxyTests = []struct { match bool }{ // Never proxy localhost: - {"localhost:80", false}, + {"localhost", false}, {"127.0.0.1", false}, {"127.0.0.2", false}, {"[::1]", false},