From: Rob Pike <r@golang.org>
Date: Mon, 20 Dec 2010 21:36:47 +0000 (-0800)
Subject: template: fix trivial bug: integers are not "empty"
X-Git-Tag: weekly.2010-12-22~4
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=d3866ddc65789d1dbdbb90e4bedafcf0bfc65c87;p=gostls13.git

template: fix trivial bug: integers are not "empty"
Fixes #1357.

R=adg, gri
CC=golang-dev
https://golang.org/cl/3809041
---

diff --git a/src/pkg/template/template.go b/src/pkg/template/template.go
index be5c59aed8..aa05077616 100644
--- a/src/pkg/template/template.go
+++ b/src/pkg/template/template.go
@@ -673,7 +673,7 @@ func empty(v reflect.Value) bool {
 	case *reflect.SliceValue:
 		return v.Len() == 0
 	}
-	return true
+	return false
 }
 
 // Look up a variable or method, up through the parent if necessary.
diff --git a/src/pkg/template/template_test.go b/src/pkg/template/template_test.go
index 1c491e34ae..4075444a81 100644
--- a/src/pkg/template/template_test.go
+++ b/src/pkg/template/template_test.go
@@ -197,6 +197,12 @@ var tests = []*Test{
 		out: " Header\n",
 	},
 
+	&Test{
+		in: "{.section integer}{@}{.end}",
+
+		out: "77",
+	},
+
 	// Repeated
 	&Test{
 		in: "{.section pdata }\n" +