From: Shivansh Rai <shivansh@freebsd.org>
Date: Fri, 18 May 2018 01:20:43 +0000 (+0530)
Subject: cmd/gofmt: update error handling when writing to backup file
X-Git-Tag: go1.12beta1~1337
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=d778a371be488312fe43b2d710dfc8c7afb3d29c;p=gostls13.git

cmd/gofmt: update error handling when writing to backup file

As per commit aa0ae75, handling of io.ErrShortWrite is done in
*File.Write() itself.

Change-Id: I92924b51e8df2ae88e6e50318348f44973addba8
Reviewed-on: https://go-review.googlesource.com/113696
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/cmd/gofmt/gofmt.go b/src/cmd/gofmt/gofmt.go
index d5b7be327a..ac6852f2e4 100644
--- a/src/cmd/gofmt/gofmt.go
+++ b/src/cmd/gofmt/gofmt.go
@@ -319,10 +319,7 @@ func backupFile(filename string, data []byte, perm os.FileMode) (string, error)
 	}
 
 	// write data to backup file
-	n, err := f.Write(data)
-	if err == nil && n < len(data) {
-		err = io.ErrShortWrite
-	}
+	_, err = f.Write(data)
 	if err1 := f.Close(); err == nil {
 		err = err1
 	}