From: Joshua M. Clulow Date: Mon, 21 Oct 2019 08:45:43 +0000 (-0700) Subject: runtime: temporarily skip gdb python-related tests on illumos X-Git-Tag: go1.14beta1~684 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=d960de0b6f61a486576dbd5a49151bc6125c7010;p=gostls13.git runtime: temporarily skip gdb python-related tests on illumos Updates golang/go#20821 Change-Id: I186356a78ac385a15b4604e0ea6110c4c212ebc4 Reviewed-on: https://go-review.googlesource.com/c/go/+/202357 Reviewed-by: Brad Fitzpatrick --- diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go index de1bac65da..8cbc7638ca 100644 --- a/src/runtime/runtime-gdb_test.go +++ b/src/runtime/runtime-gdb_test.go @@ -66,8 +66,8 @@ func checkGdbVersion(t *testing.T) { } func checkGdbPython(t *testing.T) { - if runtime.GOOS == "solaris" && testenv.Builder() != "solaris-amd64-smartosbuildlet" { - t.Skip("skipping gdb python tests on solaris; see golang.org/issue/20821") + if runtime.GOOS == "solaris" || runtime.GOOS == "illumos" { + t.Skip("skipping gdb python tests on illumos and solaris; see golang.org/issue/20821") } cmd := exec.Command("gdb", "-nx", "-q", "--batch", "-iex", "python import sys; print('go gdb python support')")