From: Josh Bleecher Snyder Date: Tue, 25 Feb 2014 22:43:53 +0000 (-0800) Subject: 5g, 8g: remove dead code X-Git-Tag: go1.3beta1~571 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=d97d37188a7e58250b2a655dc86dbf644637d034;p=gostls13.git 5g, 8g: remove dead code maxstksize is superfluous and appears to be vestigial. 6g does not use it. c >= 4 cannot occur; c = w % 4. LGTM=rsc R=rsc CC=golang-codereviews https://golang.org/cl/68750043 --- diff --git a/src/cmd/5g/gg.h b/src/cmd/5g/gg.h index a67a50080a..413e93c24a 100644 --- a/src/cmd/5g/gg.h +++ b/src/cmd/5g/gg.h @@ -28,7 +28,6 @@ EXTERN Node* panicindex; EXTERN Node* panicslice; EXTERN Node* throwreturn; extern long unmappedzero; -EXTERN int maxstksize; /* * gen.c diff --git a/src/cmd/5g/ggen.c b/src/cmd/5g/ggen.c index b9930f49e7..417f381da4 100644 --- a/src/cmd/5g/ggen.c +++ b/src/cmd/5g/ggen.c @@ -22,11 +22,8 @@ defframe(Prog *ptxt) ptxt->to.offset2 = rnd(curfn->type->argwid, widthptr); // fill in final stack size - if(stksize > maxstksize) - maxstksize = stksize; - frame = rnd(maxstksize+maxarg, widthptr); + frame = rnd(stksize+maxarg, widthptr); ptxt->to.offset = frame; - maxstksize = 0; p = ptxt; if(stkzerosize > 0) { diff --git a/src/cmd/8g/gg.h b/src/cmd/8g/gg.h index 8a2fcb6772..bdefa93b5b 100644 --- a/src/cmd/8g/gg.h +++ b/src/cmd/8g/gg.h @@ -31,7 +31,6 @@ EXTERN Node* panicindex; EXTERN Node* panicslice; EXTERN Node* panicdiv; EXTERN Node* throwreturn; -EXTERN int maxstksize; extern uint32 unmappedzero; diff --git a/src/cmd/8g/ggen.c b/src/cmd/8g/ggen.c index f761fa6b03..997811af36 100644 --- a/src/cmd/8g/ggen.c +++ b/src/cmd/8g/ggen.c @@ -21,11 +21,8 @@ defframe(Prog *ptxt) ptxt->to.offset2 = rnd(curfn->type->argwid, widthptr); // fill in final stack size - if(stksize > maxstksize) - maxstksize = stksize; - frame = rnd(maxstksize+maxarg, widthptr); + frame = rnd(stksize+maxarg, widthptr); ptxt->to.offset = frame; - maxstksize = 0; // insert code to contain ambiguously live variables // so that garbage collector only sees initialized values @@ -137,11 +134,6 @@ clearfat(Node *nl) q--; } - if(c >= 4) { - gconreg(AMOVL, c, D_CX); - gins(AREP, N, N); // repeat - gins(ASTOSB, N, N); // STOB AL,*(DI)+ - } else while(c > 0) { gins(ASTOSB, N, N); // STOB AL,*(DI)+ c--;