From: Josh Bleecher Snyder Date: Fri, 10 Mar 2017 06:02:13 +0000 (-0800) Subject: net/http: change TestServerAllowsBlockingRemoteAddr to non-parallel X-Git-Tag: go1.9beta1~1209 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=d9fe2332ba63d1dd9416438a53b58bd6a91626b6;p=gostls13.git net/http: change TestServerAllowsBlockingRemoteAddr to non-parallel It appears that this test is particularly sensitive to resource starvation. Returning it to non-parallel should reduce flakiness, by giving it the full system resources to run. Fixes #19161 Change-Id: I6e8906516629badaa0cffeb5712af649dc197f39 Reviewed-on: https://go-review.googlesource.com/38005 Run-TryBot: Josh Bleecher Snyder TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- diff --git a/src/net/http/serve_test.go b/src/net/http/serve_test.go index d301d15eb1..7d964b309e 100644 --- a/src/net/http/serve_test.go +++ b/src/net/http/serve_test.go @@ -929,7 +929,6 @@ func (c *blockingRemoteAddrConn) RemoteAddr() net.Addr { // Issue 12943 func TestServerAllowsBlockingRemoteAddr(t *testing.T) { - setParallel(t) defer afterTest(t) ts := httptest.NewUnstartedServer(HandlerFunc(func(w ResponseWriter, r *Request) { fmt.Fprintf(w, "RA:%s", r.RemoteAddr)