From: Aliaksandr Valialkin <valyala@gmail.com>
Date: Tue, 24 May 2016 10:53:44 +0000 (+0300)
Subject: cmd/vet: do not check print-like functions with unknown type
X-Git-Tag: go1.7beta1~113
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=dcc42c7d11ad06bebc9d13d1e812629f930f14a7;p=gostls13.git

cmd/vet: do not check print-like functions with unknown type

Fixes #15787

Change-Id: I559ba886527b474dbdd44fe884c78973b3012377
Reviewed-on: https://go-review.googlesource.com/23351
Run-TryBot: Rob Pike <r@golang.org>
Reviewed-by: Rob Pike <r@golang.org>
---

diff --git a/src/cmd/vet/print.go b/src/cmd/vet/print.go
index 07499e6ae6..f4b985cfbd 100644
--- a/src/cmd/vet/print.go
+++ b/src/cmd/vet/print.go
@@ -587,22 +587,24 @@ func (f *File) argCanBeChecked(call *ast.CallExpr, formatArg int, isStar bool, s
 func (f *File) checkPrint(call *ast.CallExpr, name string) {
 	firstArg := 0
 	typ := f.pkg.types[call.Fun].Type
-	if typ != nil {
-		if sig, ok := typ.(*types.Signature); ok {
-			if !sig.Variadic() {
-				// Skip checking non-variadic functions.
-				return
-			}
-			params := sig.Params()
-			firstArg = params.Len() - 1
-
-			typ := params.At(firstArg).Type()
-			typ = typ.(*types.Slice).Elem()
-			it, ok := typ.(*types.Interface)
-			if !ok || !it.Empty() {
-				// Skip variadic functions accepting non-interface{} args.
-				return
-			}
+	if typ == nil {
+		// Skip checking functions with unknown type.
+		return
+	}
+	if sig, ok := typ.(*types.Signature); ok {
+		if !sig.Variadic() {
+			// Skip checking non-variadic functions.
+			return
+		}
+		params := sig.Params()
+		firstArg = params.Len() - 1
+
+		typ := params.At(firstArg).Type()
+		typ = typ.(*types.Slice).Elem()
+		it, ok := typ.(*types.Interface)
+		if !ok || !it.Empty() {
+			// Skip variadic functions accepting non-interface{} args.
+			return
 		}
 	}
 	args := call.Args
diff --git a/src/cmd/vet/testdata/print.go b/src/cmd/vet/testdata/print.go
index 261ee788c7..ab97256c08 100644
--- a/src/cmd/vet/testdata/print.go
+++ b/src/cmd/vet/testdata/print.go
@@ -8,6 +8,7 @@ package testdata
 
 import (
 	"fmt"
+	"io"
 	"math"
 	"os"
 	"unsafe" // just for test case printing unsafe.Pointer
@@ -272,11 +273,21 @@ func Printf(format string, args ...interface{}) {
 	panic("don't call - testing only")
 }
 
+// Println is used by the test so we must declare it.
+func Println(args ...interface{}) {
+	panic("don't call - testing only")
+}
+
 // Logf is used by the test so we must declare it.
 func Logf(format string, args ...interface{}) {
 	panic("don't call - testing only")
 }
 
+// Log is used by the test so we must declare it.
+func Log(args ...interface{}) {
+	panic("don't call - testing only")
+}
+
 // printf is used by the test so we must declare it.
 func printf(format string, args ...interface{}) {
 	panic("don't call - testing only")
@@ -415,3 +426,10 @@ var recursiveStruct1V = &RecursiveStruct1{}
 func (int) String() {
 	return ""
 }
+
+func (s *unknownStruct) Fprintln(w io.Writer, s string) {}
+
+func UnknownStructFprintln() {
+	s := unknownStruct{}
+	s.Fprintln(os.Stdout, "hello, world!") // OK
+}