From: Brad Fitzpatrick Date: Wed, 2 Nov 2016 21:45:27 +0000 (-0700) Subject: crypto/x509: update __MAC_OS_X_VERSION_MAX_ALLOWED on Mac X-Git-Tag: go1.8beta1~301 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=dd1e7b3be0f64438e58f956bfb989608c7fa61bc;p=gostls13.git crypto/x509: update __MAC_OS_X_VERSION_MAX_ALLOWED on Mac Reportedly, -mmacosx-version-min=10.6 -D__MAC_OS_X_VERSION_MAX_ALLOWED=1060 is problematic. It means min 10.6 and max 10.6, thus exactly 10.6. But we only support 10.8+. It never caused us problems, because we build on Macs, but apparently if you cross-compile from Linux with some Mac compiler SDK thing, then things break? This was added in https://golang.org/cl/5700083 for #3131, and the intent at the time was to pin to exactly 10.6. So it wasn't a mistake, but it is definitely outdated. Given that we now support 10.8 as the min, update it to 1080. Fixes #17732 Change-Id: I6cc8ab6ac62b8638a5025952b830f23e8822b2a6 Reviewed-on: https://go-review.googlesource.com/32580 Reviewed-by: Josh Bleecher Snyder Reviewed-by: Russ Cox Reviewed-by: Quentin Smith Run-TryBot: Brad Fitzpatrick --- diff --git a/src/crypto/x509/root_cgo_darwin.go b/src/crypto/x509/root_cgo_darwin.go index a4b33c7660..ea86b60e11 100644 --- a/src/crypto/x509/root_cgo_darwin.go +++ b/src/crypto/x509/root_cgo_darwin.go @@ -7,7 +7,7 @@ package x509 /* -#cgo CFLAGS: -mmacosx-version-min=10.6 -D__MAC_OS_X_VERSION_MAX_ALLOWED=1060 +#cgo CFLAGS: -mmacosx-version-min=10.6 -D__MAC_OS_X_VERSION_MAX_ALLOWED=1080 #cgo LDFLAGS: -framework CoreFoundation -framework Security #include