From: Brad Fitzpatrick Date: Fri, 14 Oct 2011 17:07:27 +0000 (-0700) Subject: net: skip ICMP test on Windows too unless uid 0 X-Git-Tag: weekly.2011-10-18~75 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=ddc3381e8b3bc91e54985bd8679c98f0cba3beff;p=gostls13.git net: skip ICMP test on Windows too unless uid 0 This test fails for me on Windows 7 64-bit non-Admin. R=golang-dev, rsc, krautz CC=golang-dev https://golang.org/cl/5276048 --- diff --git a/src/pkg/net/ipraw_test.go b/src/pkg/net/ipraw_test.go index 7f8c7b841e..6894ce656d 100644 --- a/src/pkg/net/ipraw_test.go +++ b/src/pkg/net/ipraw_test.go @@ -11,7 +11,6 @@ import ( "bytes" "flag" "os" - "runtime" "testing" ) @@ -65,7 +64,7 @@ var dsthost = flag.String("dsthost", "127.0.0.1", "Destination for the ICMP ECHO // test (raw) IP socket using ICMP func TestICMP(t *testing.T) { - if runtime.GOOS != "windows" && os.Getuid() != 0 { + if os.Getuid() != 0 { t.Logf("test disabled; must be root") return }