From: Russ Cox <rsc@golang.org>
Date: Fri, 21 Sep 2012 19:54:56 +0000 (+1000)
Subject: [release-branch.go1] cmd/go: be clear that import loops are bad
X-Git-Tag: go1.0.3~51
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=e09cf61b6430c03a912d749ced1a79b124c7c0fe;p=gostls13.git

[release-branch.go1] cmd/go: be clear that import loops are bad

««« backport f697709b5082
cmd/go: be clear that import loops are bad

There was mail on golang-nuts a few weeks ago
from someone who understood the message perfectly
and knew he had a cyclic dependency but assumed
that Go, like Python or Java, was supposed to handle it.

R=golang-dev, bradfitz, dave
CC=golang-dev
https://golang.org/cl/6488069

»»»
---

diff --git a/src/cmd/go/pkg.go b/src/cmd/go/pkg.go
index 30bbfad55a..51046412fc 100644
--- a/src/cmd/go/pkg.go
+++ b/src/cmd/go/pkg.go
@@ -246,7 +246,7 @@ func reusePackage(p *Package, stk *importStack) *Package {
 		if p.Error == nil {
 			p.Error = &PackageError{
 				ImportStack: stk.copy(),
-				Err:         "import loop",
+				Err:         "import cycle not allowed",
 			}
 		}
 		p.Incomplete = true