From: Than McIntosh <thanm@google.com>
Date: Wed, 11 Mar 2020 20:37:41 +0000 (-0400)
Subject: [dev.link] cmd/link: remove legacy newdie function
X-Git-Tag: go1.15beta1~679^2~81
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=e440f052517a5e914715229176c66dc939a95824;p=gostls13.git

[dev.link] cmd/link: remove legacy newdie function

Remove the linker's "newdie" function (no longer called).

Change-Id: Ide8be6019f512339b8356b0af812426f353af47d
Reviewed-on: https://go-review.googlesource.com/c/go/+/223057
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jeremy Faller <jeremy@golang.org>
Reviewed-by: Cherry Zhang <cherryyz@google.com>
---

diff --git a/src/cmd/link/internal/ld/dwarf2.go b/src/cmd/link/internal/ld/dwarf2.go
index 172c8a049e..ac971849b4 100644
--- a/src/cmd/link/internal/ld/dwarf2.go
+++ b/src/cmd/link/internal/ld/dwarf2.go
@@ -14,10 +14,8 @@
 package ld
 
 import (
-	"cmd/internal/dwarf"
 	"cmd/internal/objabi"
 	"cmd/link/internal/sym"
-	"fmt"
 	"log"
 )
 
@@ -27,34 +25,6 @@ func isDwarf64(ctxt *Link) bool {
 
 var dwarfp []*sym.Symbol
 
-// Every DIE manufactured by the linker has at least an AT_name
-// attribute (but it will only be written out if it is listed in the abbrev).
-// The compiler does create nameless DWARF DIEs (ex: concrete subprogram
-// instance).
-func newdie(ctxt *Link, parent *dwarf.DWDie, abbrev int, name string, version int) *dwarf.DWDie {
-	die := new(dwarf.DWDie)
-	die.Abbrev = abbrev
-	die.Link = parent.Child
-	parent.Child = die
-
-	newattr(die, dwarf.DW_AT_name, dwarf.DW_CLS_STRING, int64(len(name)), name)
-
-	if name != "" && (abbrev <= dwarf.DW_ABRV_VARIABLE || abbrev >= dwarf.DW_ABRV_NULLTYPE) {
-		if abbrev != dwarf.DW_ABRV_VARIABLE || version == 0 {
-			if abbrev == dwarf.DW_ABRV_COMPUNIT {
-				// Avoid collisions with "real" symbol names.
-				name = fmt.Sprintf(".pkg.%s.%d", name, len(ctxt.compUnits))
-			}
-			s := ctxt.Syms.Lookup(dwarf.InfoPrefix+name, version)
-			s.Attr |= sym.AttrNotInSymbolTable
-			s.Type = sym.SDWARFINFO
-			die.Sym = s
-		}
-	}
-
-	return die
-}
-
 /*
  *  Elf.
  */