From: Michael Pratt <mpratt@google.com>
Date: Mon, 12 Feb 2024 19:32:22 +0000 (-0500)
Subject: runtime/cgo: add note about default stack bounds
X-Git-Tag: go1.23rc1~1244
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=e45c262fe55ada091a4ae53bf140ff22d9f74b35;p=gostls13.git

runtime/cgo: add note about default stack bounds

The default case in x_cgo_getstackbound does not actually get the stack bound of
the current thread, but estimates the bound based on the default stack size. Add
a comment noting this.

Change-Id: I7d886461f0bbc795834bed37b554417cf3837a2d
Reviewed-on: https://go-review.googlesource.com/c/go/+/563376
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
---

diff --git a/src/runtime/cgo/gcc_stack_unix.c b/src/runtime/cgo/gcc_stack_unix.c
index f3fead9c9e..67efd9bc63 100644
--- a/src/runtime/cgo/gcc_stack_unix.c
+++ b/src/runtime/cgo/gcc_stack_unix.c
@@ -29,6 +29,8 @@ x_cgo_getstackbound(uintptr bounds[2])
 	pthread_attr_get_np(pthread_self(), &attr);
 	pthread_attr_getstack(&attr, &addr, &size); // low address
 #else
+	// We don't know how to get the current stacks, so assume they are the
+	// same as the default stack bounds.
 	pthread_attr_init(&attr);
 	pthread_attr_getstacksize(&attr, &size);
 	addr = __builtin_frame_address(0) + 4096 - size;