From: David Crawshaw Date: Thu, 26 Feb 2015 14:44:41 +0000 (-0500) Subject: os/exec: disable tests on darwin/arm X-Git-Tag: go1.5beta1~1850 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=e4791066c8a46131462f3af4135dd401651c16b9;p=gostls13.git os/exec: disable tests on darwin/arm There is only one process under the iOS sandboxd. Change-Id: I21b5528366a0248a034801a717f24c60f0733c5f Reviewed-on: https://go-review.googlesource.com/6101 Reviewed-by: Hyang-Ah Hana Kim Reviewed-by: Brad Fitzpatrick --- diff --git a/src/os/exec/exec_test.go b/src/os/exec/exec_test.go index 197d3e8b40..ebaef992bc 100644 --- a/src/os/exec/exec_test.go +++ b/src/os/exec/exec_test.go @@ -28,8 +28,9 @@ import ( ) func helperCommand(t *testing.T, s ...string) *exec.Cmd { - if runtime.GOOS == "nacl" { - t.Skip("skipping on nacl") + if runtime.GOOS == "nacl" || (runtime.GOOS == "darwin" && runtime.GOARCH == "arm") { + // iOS cannot fork + t.Skipf("skipping on %s/%s", runtime.GOOS, runtime.GOARCH) } cs := []string{"-test.run=TestHelperProcess", "--"} cs = append(cs, s...) @@ -49,6 +50,10 @@ func TestEcho(t *testing.T) { } func TestCommandRelativeName(t *testing.T) { + if runtime.GOOS == "darwin" && runtime.GOARCH == "arm" { + t.Skip("skipping on darwin/arm") + } + // Run our own binary as a relative path // (e.g. "_test/exec.test") our parent directory. base := filepath.Base(os.Args[0]) // "exec.test" @@ -378,6 +383,10 @@ func TestExtraFiles(t *testing.T) { switch runtime.GOOS { case "nacl", "windows": t.Skipf("skipping test on %q", runtime.GOOS) + case "darwin": + if runtime.GOARCH == "arm" { + t.Skipf("skipping test on %s/%s", runtime.GOOS, runtime.GOARCH) + } } // Ensure that file descriptors have not already been leaked into