From: Matt T. Proud <matt.proud@gmail.com>
Date: Sat, 20 Jun 2015 04:29:18 +0000 (+0200)
Subject: testing/quick: improve function signature error.
X-Git-Tag: go1.5beta1~94
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=e6ad56c711f00ee15d2c42ff64849542e19eca8a;p=gostls13.git

testing/quick: improve function signature error.

This commit fixes a cosmetic defect whereby quick.Check reports that
the provided function returns too many values when it may, in fact,
return too few:

  func f() {}

  func TestFoo(t *testing.T) {
    if err := quick.Check(f, nil); err != nil {
      t.Fatal(err)
    }
  }
  // yields
  // $ go test -v foo_test.go
  // === RUN TestFoo
  // --- FAIL: TestFoo (0.00s)
  // 	foo_test.go:76: function returns more than one value.

Change-Id: Ia209ff5b57375b30f8db425454e80798908e8ff4
Reviewed-on: https://go-review.googlesource.com/11281
Reviewed-by: Russ Cox <rsc@golang.org>
---

diff --git a/src/testing/quick/quick.go b/src/testing/quick/quick.go
index 0e36810eb6..13c56cdf48 100644
--- a/src/testing/quick/quick.go
+++ b/src/testing/quick/quick.go
@@ -249,7 +249,7 @@ func Check(f interface{}, config *Config) (err error) {
 	}
 
 	if fType.NumOut() != 1 {
-		err = SetupError("function returns more than one value.")
+		err = SetupError("function does not return one value")
 		return
 	}
 	if fType.Out(0).Kind() != reflect.Bool {