From: Kevin Burke <kev@inburke.com>
Date: Thu, 3 Aug 2017 05:24:22 +0000 (-0700)
Subject: strings: avoid unnecessary variable setting
X-Git-Tag: go1.10beta1~1691
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=e93eb2843c6b6b8e0e6c5e9eb1a4417328055ec6;p=gostls13.git

strings: avoid unnecessary variable setting

We initialize fieldStart to 0, then set it to i without ever reading
0, so we might as well just initialize it to i.

Change-Id: I17905b25d54a62b6bc76f915353756ed5eb6972b
Reviewed-on: https://go-review.googlesource.com/52933
Reviewed-by: Martin Möhrmann <moehrmann@google.com>
Reviewed-by: Avelino <t@avelino.xxx>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/strings/strings.go b/src/strings/strings.go
index 0c836c09d4..52466e924d 100644
--- a/src/strings/strings.go
+++ b/src/strings/strings.go
@@ -363,7 +363,6 @@ func Fields(s string) []string {
 	// a non-ASCII rune needs to be decoded and checked
 	// if it corresponds to a space.
 	a := make([]string, 0, n)
-	fieldStart := 0
 	i := 0
 	// Skip spaces in the front of the input.
 	for i < len(s) {
@@ -380,7 +379,7 @@ func Fields(s string) []string {
 			i += w
 		}
 	}
-	fieldStart = i
+	fieldStart := i
 	for i < len(s) {
 		if c := s[i]; c < utf8.RuneSelf {
 			if asciiSpace[c] == 0 {