From: Rob Pike <r@golang.org>
Date: Wed, 6 May 2015 20:19:30 +0000 (-0700)
Subject: testing: document that Log and Logf always print in benchmarks
X-Git-Tag: go1.5beta1~700
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=e9827f62018b87482e647dd88aecdedb24c94680;p=gostls13.git

testing: document that Log and Logf always print in benchmarks

Fixes #10713.

Change-Id: Ifdafc340ae3bba751236f0482246c568346a569c
Reviewed-on: https://go-review.googlesource.com/9763
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/testing/testing.go b/src/testing/testing.go
index 51631238aa..280d76a1aa 100644
--- a/src/testing/testing.go
+++ b/src/testing/testing.go
@@ -342,13 +342,15 @@ func (c *common) log(s string) {
 }
 
 // Log formats its arguments using default formatting, analogous to Println,
-// and records the text in the error log. The text will be printed only if
-// the test fails or the -test.v flag is set.
+// and records the text in the error log. For tests, the text will be printed only if
+// the test fails or the -test.v flag is set. For benchmarks, the text is always
+// printed to avoid having performance depend on the value of the -test.v flag.
 func (c *common) Log(args ...interface{}) { c.log(fmt.Sprintln(args...)) }
 
 // Logf formats its arguments according to the format, analogous to Printf,
-// and records the text in the error log. The text will be printed only if
-// the test fails or the -test.v flag is set.
+// and records the text in the error log. For tests, the text will be printed only if
+// the test fails or the -test.v flag is set. For benchmarks, the text is always
+// printed to avoid having performance depend on the value of the -test.v flag.
 func (c *common) Logf(format string, args ...interface{}) { c.log(fmt.Sprintf(format, args...)) }
 
 // Error is equivalent to Log followed by Fail.