From: Dan Scales <danscales@google.com>
Date: Tue, 2 Nov 2021 19:30:37 +0000 (-0700)
Subject: cmd/compile: remove TODO that is no longer relevant
X-Git-Tag: go1.18beta1~589
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=eb63cbd2950e703ff2a6bd04330e97dc76c7923d;p=gostls13.git

cmd/compile: remove TODO that is no longer relevant

types2 methods are now sorted in the same way as types1, so this TODO is
no longer needed.  (Comment change only).

Change-Id: Ic975ce001a5d54f15381a9cb7b6969dff795e3b4
Reviewed-on: https://go-review.googlesource.com/c/go/+/360856
Trust: Dan Scales <danscales@google.com>
Run-TryBot: Dan Scales <danscales@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
---

diff --git a/src/cmd/compile/internal/noder/expr.go b/src/cmd/compile/internal/noder/expr.go
index d19513a1ac..24e6dbefe7 100644
--- a/src/cmd/compile/internal/noder/expr.go
+++ b/src/cmd/compile/internal/noder/expr.go
@@ -235,12 +235,6 @@ func (g *irgen) selectorExpr(pos src.XPos, typ types2.Type, expr *syntax.Selecto
 		return DotField(pos, x, last)
 	}
 
-	// TODO(danscales,mdempsky): Interface method sets are not sorted the
-	// same between types and types2. In particular, using "last" here
-	// without conversion will likely fail if an interface contains
-	// unexported methods from two different packages (due to cross-package
-	// interface embedding).
-
 	var n ir.Node
 	method2 := selinfo.Obj().(*types2.Func)