From: Nigel Tao Date: Fri, 13 Jun 2014 07:43:02 +0000 (+1000) Subject: image/png: fix compare-to-golden-file test. X-Git-Tag: go1.4beta1~1292 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=eb788045d85f48980b8513a71661fcf3100c98c8;p=gostls13.git image/png: fix compare-to-golden-file test. bufio.Scanner.Scan returns whether the scan succeeded, not whether it is done, so the test was mistakenly breaking early. LGTM=r R=r CC=golang-codereviews https://golang.org/cl/93670045 --- diff --git a/src/pkg/image/png/reader_test.go b/src/pkg/image/png/reader_test.go index ac0d949a9d..0bc3c8d4a1 100644 --- a/src/pkg/image/png/reader_test.go +++ b/src/pkg/image/png/reader_test.go @@ -235,8 +235,8 @@ func TestReader(t *testing.T) { // Compare the two, in SNG format, line by line. for { - pdone := pb.Scan() - sdone := sb.Scan() + pdone := !pb.Scan() + sdone := !sb.Scan() if pdone && sdone { break }