From: Russ Cox <rsc@golang.org>
Date: Thu, 22 Oct 2009 18:21:13 +0000 (-0700)
Subject: fix handling of escaped characters like ' " & < >
X-Git-Tag: weekly.2009-11-06~225
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=eea2573032b910bb1d187cc6125b7ed2d7461c3d;p=gostls13.git

fix handling of escaped characters like ' " & < >

R=r
http://go/go-review/1013007
---

diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 23b5733304..f0092a3c60 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -618,7 +618,8 @@ def mail(ui, repo, *pats, **opts):
 	pmsg = "Hello " + JoinComma(cl.reviewer) + ",\n"
 	pmsg += "\n"
 	pmsg += "I'd like you to review the following change.\n"
-	PostMessage(cl.name, pmsg, send_mail="checked", subject="code review: " + line1(cl.desc))
+	subject = "code review %s: %s" % (cl.name, line1(cl.desc))
+	PostMessage(cl.name, pmsg, send_mail="checked", subject=subject)
 	
 def submit(ui, repo, *pats, **opts):
 	"""submit change to remote repository
@@ -835,9 +836,7 @@ class FormParser(HTMLParser):
 			self.curtag = None
 			self.curdata = None
 	def handle_charref(self, name):
-		import unicodedata
-		char = unicodedata.name(unichr(int(name)))
-		self.handle_data(char)
+		self.handle_data(unichr(int(name)))
 	def handle_entityref(self, name):
 		import htmlentitydefs
 		if name in htmlentitydefs.entitydefs: