From: Keith Randall <khr@golang.org>
Date: Fri, 29 Aug 2014 06:26:50 +0000 (-0700)
Subject: runtime: don't allocate a new string in printf
X-Git-Tag: go1.4beta1~636
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=ef64d9ffcc237fde9bcaed1fd00c5036c4f489de;p=gostls13.git

runtime: don't allocate a new string in printf

LGTM=dave
R=rsc, dave
CC=golang-codereviews
https://golang.org/cl/139890043
---

diff --git a/src/pkg/runtime/print1.go b/src/pkg/runtime/print1.go
index 94ba9e4733..9df6a621bb 100644
--- a/src/pkg/runtime/print1.go
+++ b/src/pkg/runtime/print1.go
@@ -39,7 +39,7 @@ func goprintf(s string) {
 // and type tables.
 //go:nosplit
 func printf(s *byte) {
-	vprintf(gostring(s), add(unsafe.Pointer(&s), unsafe.Sizeof(s)))
+	vprintf(gostringnocopy(s), add(unsafe.Pointer(&s), unsafe.Sizeof(s)))
 }
 
 // sprintf is only called from C code.
diff --git a/src/pkg/runtime/string.c b/src/pkg/runtime/string.c
index 60a0545a9a..5421b53196 100644
--- a/src/pkg/runtime/string.c
+++ b/src/pkg/runtime/string.c
@@ -90,6 +90,7 @@ runtime·gobytes(byte *p, intgo n)
 	return sl;
 }
 
+#pragma textflag NOSPLIT
 String
 runtime·gostringnocopy(byte *str)
 {
diff --git a/src/pkg/runtime/stubs.go b/src/pkg/runtime/stubs.go
index 26126fcf9a..2014dfbf90 100644
--- a/src/pkg/runtime/stubs.go
+++ b/src/pkg/runtime/stubs.go
@@ -203,6 +203,7 @@ func noteclear(n *note)
 func lock(lk *mutex)
 func unlock(lk *mutex)
 func purgecachedstats(c *mcache)
+func gostringnocopy(b *byte) string
 
 //go:noescape
 func write(fd uintptr, p unsafe.Pointer, n int32) int32