From: Rob Pike <r@golang.org>
Date: Fri, 16 Aug 2013 02:49:51 +0000 (+1000)
Subject: cmd/go: fix at least some instances of double compilation
X-Git-Tag: go1.2rc2~532
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=f0fef323833b9b060024507a3229fa7bf9b523a8;p=gostls13.git

cmd/go: fix at least some instances of double compilation

When the packages the tested package depends on don't build,
we weren't getting out early. Added a simple check for a successful
build to an existing early out.

There may be other ways that double compilation arises, but
this fixes the one listed in the issue.
Fixes #5679

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13036043
---

diff --git a/src/cmd/go/test.go b/src/cmd/go/test.go
index d4a1c50f41..002758c3b1 100644
--- a/src/cmd/go/test.go
+++ b/src/cmd/go/test.go
@@ -378,7 +378,7 @@ func runTest(cmd *Command, args []string) {
 			a.deps = append(a.deps, b.action(modeInstall, modeInstall, p))
 		}
 		b.do(a)
-		if !testC {
+		if !testC || a.failed {
 			return
 		}
 		b.init()