From: Cherry Zhang <cherryyz@google.com>
Date: Wed, 8 Apr 2020 15:54:11 +0000 (-0400)
Subject: [dev.link] cmd/link: ignore undefined symbols in trampoline generation
X-Git-Tag: go1.15beta1~556^2^2~28
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=f12683a83114b9240bea9715fba563647deed72d;p=gostls13.git

[dev.link] cmd/link: ignore undefined symbols in trampoline generation

Don't emit an error for undefined symbol in trampoline
generation pass, which will be duplicate as we'll emit a better
one later.

Fix TestUndefinedRelocErrors on PPC64.

Change-Id: I964d4bd63ec4b4c6eb5d98caf68db93ce6488bf5
Reviewed-on: https://go-review.googlesource.com/c/go/+/227617
Run-TryBot: Cherry Zhang <cherryyz@google.com>
Reviewed-by: Than McIntosh <thanm@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
---

diff --git a/src/cmd/link/internal/ld/data.go b/src/cmd/link/internal/ld/data.go
index 3a1f355056..f72262cf4d 100644
--- a/src/cmd/link/internal/ld/data.go
+++ b/src/cmd/link/internal/ld/data.go
@@ -101,7 +101,7 @@ func trampoline(ctxt *Link, s loader.Sym) {
 			continue
 		}
 		rs := r.Sym()
-		if !ldr.AttrReachable(rs) {
+		if !ldr.AttrReachable(rs) || ldr.SymType(rs) == sym.Sxxx {
 			continue // something is wrong. skip it here and we'll emit a better error later
 		}
 		rs = ldr.ResolveABIAlias(rs)