From: Ian Lance Taylor <iant@golang.org>
Date: Sat, 25 Aug 2018 17:11:19 +0000 (-0700)
Subject: cmd/go: don't let script grep commands match $WORK
X-Git-Tag: go1.12beta1~1263
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=f2ed3e1da16ba02543268b14d962e1026257604e;p=gostls13.git

cmd/go: don't let script grep commands match $WORK

If $WORK happens to contain the string that a stdout/stderr/grep
command is searching for, a negative grep command will fail incorrectly.

Fixes #27170
Fixes #27221

Change-Id: I84454d3c42360fe3295c7235d388381525eb85b4
Reviewed-on: https://go-review.googlesource.com/131398
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
---

diff --git a/src/cmd/go/script_test.go b/src/cmd/go/script_test.go
index 389485bc65..7c083a87b9 100644
--- a/src/cmd/go/script_test.go
+++ b/src/cmd/go/script_test.go
@@ -629,6 +629,9 @@ func scriptMatch(ts *testScript, neg bool, args []string, text, name string) {
 		text = string(data)
 	}
 
+	// Matching against workdir would be misleading.
+	text = strings.Replace(text, ts.workdir, "$WORK", -1)
+
 	if neg {
 		if re.MatchString(text) {
 			if isGrep {