From: Wei Guangjing Date: Tue, 12 Jul 2011 18:29:38 +0000 (-0700) Subject: debug/pe: fixes ImportedSymbols for Win64. X-Git-Tag: weekly.2011-07-19~102 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=f340b3de5a19c310aa38abc6f474c366a7b7d89b;p=gostls13.git debug/pe: fixes ImportedSymbols for Win64. R=golang-dev, alex.brainman CC=golang-dev https://golang.org/cl/4639086 --- diff --git a/src/pkg/debug/pe/file.go b/src/pkg/debug/pe/file.go index 04991f781b..c934dd4477 100644 --- a/src/pkg/debug/pe/file.go +++ b/src/pkg/debug/pe/file.go @@ -245,6 +245,7 @@ func (f *File) DWARF() (*dwarf.Data, os.Error) { // satisfied by other libraries at dynamic load time. // It does not return weak symbols. func (f *File) ImportedSymbols() ([]string, os.Error) { + pe64 := f.Machine == IMAGE_FILE_MACHINE_AMD64 ds := f.Section(".idata") if ds == nil { // not dynamic, so no libraries @@ -274,17 +275,31 @@ func (f *File) ImportedSymbols() ([]string, os.Error) { // seek to OriginalFirstThunk d = d[dt.OriginalFirstThunk-ds.VirtualAddress:] for len(d) > 0 { - va := binary.LittleEndian.Uint32(d[0:4]) - d = d[4:] - if va == 0 { - break - } - if va&0x80000000 > 0 { // is Ordinal - // TODO add dynimport ordinal support. - //ord := va&0x0000FFFF - } else { - fn, _ := getString(names, int(va-ds.VirtualAddress+2)) - all = append(all, fn+":"+dt.dll) + if pe64 { // 64bit + va := binary.LittleEndian.Uint64(d[0:8]) + d = d[8:] + if va == 0 { + break + } + if va&0x8000000000000000 > 0 { // is Ordinal + // TODO add dynimport ordinal support. + } else { + fn, _ := getString(names, int(uint32(va)-ds.VirtualAddress+2)) + all = append(all, fn+":"+dt.dll) + } + } else { // 32bit + va := binary.LittleEndian.Uint32(d[0:4]) + d = d[4:] + if va == 0 { + break + } + if va&0x80000000 > 0 { // is Ordinal + // TODO add dynimport ordinal support. + //ord := va&0x0000FFFF + } else { + fn, _ := getString(names, int(va-ds.VirtualAddress+2)) + all = append(all, fn+":"+dt.dll) + } } } }