From: Robert Griesemer <gri@golang.org>
Date: Tue, 28 Mar 2023 18:18:40 +0000 (-0700)
Subject: go/types, types2: slightly tighter checks in Checker.use
X-Git-Tag: go1.21rc1~1111
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=f46ea60f2b072885439d5b3b2f751b16d2b1f18e;p=gostls13.git

go/types, types2: slightly tighter checks in Checker.use

Checker.use is called to check expressions and "use" variables
in case of an error. Use Checker.exprOrType instead of just
rawExpr.

Change-Id: I4da6fa51ef3b0c9b07c453494452836caced9b1a
Reviewed-on: https://go-review.googlesource.com/c/go/+/479897
Reviewed-by: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Griesemer <gri@google.com>
---

diff --git a/src/cmd/compile/internal/types2/call.go b/src/cmd/compile/internal/types2/call.go
index bb82c2464e..ec814995a9 100644
--- a/src/cmd/compile/internal/types2/call.go
+++ b/src/cmd/compile/internal/types2/call.go
@@ -820,7 +820,7 @@ func (check *Checker) use1(e syntax.Expr, lhs bool) bool {
 				}
 			}
 		}
-		check.rawExpr(nil, &x, n, nil, true)
+		check.exprOrType(&x, n, true)
 		if v != nil {
 			v.used = v_used // restore v.used
 		}
diff --git a/src/go/types/call.go b/src/go/types/call.go
index f75043d5dc..bdcfd9d56b 100644
--- a/src/go/types/call.go
+++ b/src/go/types/call.go
@@ -870,7 +870,7 @@ func (check *Checker) use1(e ast.Expr, lhs bool) bool {
 				}
 			}
 		}
-		check.rawExpr(nil, &x, n, nil, true)
+		check.exprOrType(&x, n, true)
 		if v != nil {
 			v.used = v_used // restore v.used
 		}