From: Tobias Klauser <tklauser@distanz.ch>
Date: Tue, 21 Aug 2018 12:27:07 +0000 (+0200)
Subject: cmd/cover: fix off-by-one error in TestCoverHTML
X-Git-Tag: go1.12beta1~1349
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=f4e4ec2cd09c2f9d821f3cb6f47edd7c41a90b25;p=gostls13.git

cmd/cover: fix off-by-one error in TestCoverHTML

Avoid index out of range if len(goldenLines) == len(outLines) + 1

Change-Id: Ic23a85d2b8dd06a615e35a58331e78abe4ad6703
Reviewed-on: https://go-review.googlesource.com/130396
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
---

diff --git a/src/cmd/cover/cover_test.go b/src/cmd/cover/cover_test.go
index c818819c39..8eb7124aad 100644
--- a/src/cmd/cover/cover_test.go
+++ b/src/cmd/cover/cover_test.go
@@ -314,7 +314,7 @@ func TestCoverHTML(t *testing.T) {
 	// Compare at the line level, stopping at first different line so
 	// we don't generate tons of output if there's an inserted or deleted line.
 	for i, goldenLine := range goldenLines {
-		if i > len(outLines) {
+		if i >= len(outLines) {
 			t.Fatalf("output shorter than golden; stops before line %d: %s\n", i+1, goldenLine)
 		}
 		// Convert all white space to simple spaces, for easy comparison.