From: Matthew Dempsky Date: Tue, 10 Oct 2017 16:35:11 +0000 (-0700) Subject: cmd/compile: remove outdated TODO about inlining X-Git-Tag: go1.10beta1~804 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=f58c6c991581fde4eca563100126eadceab48e80;p=gostls13.git cmd/compile: remove outdated TODO about inlining We've supported inlining methods called as functions for a while now. Change-Id: I53fba426e45f91d65a38f00456c2ae1527372b50 Reviewed-on: https://go-review.googlesource.com/69530 Run-TryBot: Matthew Dempsky TryBot-Result: Gobot Gobot Reviewed-by: Robert Griesemer --- diff --git a/src/cmd/compile/internal/gc/inl.go b/src/cmd/compile/internal/gc/inl.go index 35da0de6dd..c65eb14413 100644 --- a/src/cmd/compile/internal/gc/inl.go +++ b/src/cmd/compile/internal/gc/inl.go @@ -23,7 +23,6 @@ // // TODO: // - inline functions with ... args -// - handle T.meth(f()) with func f() (t T, arg, arg, ) package gc diff --git a/test/inline.go b/test/inline.go index 773b047cf7..7bb86ef8b2 100644 --- a/test/inline.go +++ b/test/inline.go @@ -72,3 +72,13 @@ func switchType(x interface{}) int { // ERROR "switchType x does not escape" return 0 } } + +type T struct{} + +func (T) meth(int, int) {} // ERROR "can inline T.meth" + +func k() (T, int, int) { return T{}, 0, 0 } // ERROR "can inline k" + +func _() { // ERROR "can inline _" + T.meth(k()) // ERROR "inlining call to k" "inlining call to T.meth" +}