From: Robert Findley <rfindley@google.com>
Date: Tue, 9 Nov 2021 16:19:20 +0000 (-0500)
Subject: go/types: make object test an external test
X-Git-Tag: go1.18beta1~430
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=f59d36d2e3f0707c8bf2b157009ffc38a9b74d25;p=gostls13.git

go/types: make object test an external test

This is a port of CL 361409 to go/types.

Change-Id: I17ccf8a5b4ba715fd8a87ea2c1811700fb1157e3
Reviewed-on: https://go-review.googlesource.com/c/go/+/362538
Trust: Robert Findley <rfindley@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
---

diff --git a/src/go/types/object_test.go b/src/go/types/object_test.go
index c12af64df7..e9a4bd6dbf 100644
--- a/src/go/types/object_test.go
+++ b/src/go/types/object_test.go
@@ -2,13 +2,15 @@
 // Use of this source code is governed by a BSD-style
 // license that can be found in the LICENSE file.
 
-package types
+package types_test
 
 import (
 	"go/ast"
 	"go/parser"
 	"go/token"
 	"testing"
+
+	. "go/types"
 )
 
 func TestIsAlias(t *testing.T) {
@@ -36,15 +38,15 @@ func TestIsAlias(t *testing.T) {
 		name  *TypeName
 		alias bool
 	}{
-		{NewTypeName(0, nil, "t0", nil), false},            // no type yet
-		{NewTypeName(0, pkg, "t0", nil), false},            // no type yet
-		{t1, false},                                        // type name refers to named type and vice versa
-		{NewTypeName(0, nil, "t2", &emptyInterface), true}, // type name refers to unnamed type
-		{NewTypeName(0, pkg, "t3", n1), true},              // type name refers to named type with different type name
-		{NewTypeName(0, nil, "t4", Typ[Int32]), true},      // type name refers to basic type with different name
-		{NewTypeName(0, nil, "int32", Typ[Int32]), false},  // type name refers to basic type with same name
-		{NewTypeName(0, pkg, "int32", Typ[Int32]), true},   // type name is declared in user-defined package (outside Universe)
-		{NewTypeName(0, nil, "rune", Typ[Rune]), true},     // type name refers to basic type rune which is an alias already
+		{NewTypeName(0, nil, "t0", nil), false},                       // no type yet
+		{NewTypeName(0, pkg, "t0", nil), false},                       // no type yet
+		{t1, false},                                                   // type name refers to named type and vice versa
+		{NewTypeName(0, nil, "t2", NewInterfaceType(nil, nil)), true}, // type name refers to unnamed type
+		{NewTypeName(0, pkg, "t3", n1), true},                         // type name refers to named type with different type name
+		{NewTypeName(0, nil, "t4", Typ[Int32]), true},                 // type name refers to basic type with different name
+		{NewTypeName(0, nil, "int32", Typ[Int32]), false},             // type name refers to basic type with same name
+		{NewTypeName(0, pkg, "int32", Typ[Int32]), true},              // type name is declared in user-defined package (outside Universe)
+		{NewTypeName(0, nil, "rune", Typ[Rune]), true},                // type name refers to basic type rune which is an alias already
 		{t5, false}, // type name refers to type parameter and vice versa
 	} {
 		check(test.name, test.alias)