From: Zeke Lu <lvzecai@gmail.com>
Date: Wed, 1 Nov 2023 13:47:23 +0000 (+0000)
Subject: net/http/httptest: remove unnecessary creation of http.Transport
X-Git-Tag: go1.22rc1~417
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=f5ec2e46d93f6ae289b1eed0bd6e82f3368ecee9;p=gostls13.git

net/http/httptest: remove unnecessary creation of http.Transport

In (*Server).StartTLS, it's unnecessary to create an http.Client
with a Transport, because a new one will be created with the
TLSClientConfig later.

Change-Id: I086e28717e9739787529006c3f0296c8224cd790
GitHub-Last-Rev: 33724596bd901a05a91654f8c2df233aa6563ea6
GitHub-Pull-Request: golang/go#60124
Reviewed-on: https://go-review.googlesource.com/c/go/+/494355
Run-TryBot: t hepudds <thepudds1460@gmail.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Damien Neil <dneil@google.com>
Reviewed-by: qiulaidongfeng <2645477756@qq.com>
---

diff --git a/src/net/http/httptest/server.go b/src/net/http/httptest/server.go
index 79749a0378..c962749e85 100644
--- a/src/net/http/httptest/server.go
+++ b/src/net/http/httptest/server.go
@@ -144,7 +144,7 @@ func (s *Server) StartTLS() {
 		panic("Server already started")
 	}
 	if s.client == nil {
-		s.client = &http.Client{Transport: &http.Transport{}}
+		s.client = &http.Client{}
 	}
 	cert, err := tls.X509KeyPair(testcert.LocalhostCert, testcert.LocalhostKey)
 	if err != nil {