From: Russ Cox Date: Mon, 28 Aug 2017 18:26:31 +0000 (-0400) Subject: [dev.boringcrypto] crypto/internal/boring: fix NewHMAC with empty key X-Git-Tag: go1.19beta1~484^2~179 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=f6358bdb6ca21b93313f98e3963229aedd043fe8;p=gostls13.git [dev.boringcrypto] crypto/internal/boring: fix NewHMAC with empty key Test is in a separate CL for easier cherry-picking to master branch. Change-Id: Ia4a9032892d2896332010fe18a3216f8c4a58d1c Reviewed-on: https://go-review.googlesource.com/59770 Reviewed-by: Adam Langley --- diff --git a/src/crypto/internal/boring/hmac.go b/src/crypto/internal/boring/hmac.go index a547438222..3757da6805 100644 --- a/src/crypto/internal/boring/hmac.go +++ b/src/crypto/internal/boring/hmac.go @@ -100,7 +100,7 @@ func (h *boringHMAC) Reset() { } C._goboringcrypto_HMAC_CTX_init(&h.ctx) - if C._goboringcrypto_HMAC_Init(&h.ctx, unsafe.Pointer(&h.key[0]), C.int(len(h.key)), h.md) == 0 { + if C._goboringcrypto_HMAC_Init(&h.ctx, unsafe.Pointer(base(h.key)), C.int(len(h.key)), h.md) == 0 { panic("boringcrypto: HMAC_Init failed") } if int(C._goboringcrypto_HMAC_size(&h.ctx)) != h.size {