From: Heschi Kreinick Date: Tue, 10 May 2022 14:49:40 +0000 (-0400) Subject: [release-branch.go1.17] cmd/objdump: skip TestDisasm* on darwin-arm64 X-Git-Tag: go1.17.10~1 X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=f7209f904d45b4c5426cb76992066cdd1cc2f74e;p=gostls13.git [release-branch.go1.17] cmd/objdump: skip TestDisasm* on darwin-arm64 The macOS 12 builders have an incompatible version of XCode installed. We fixed the bug on 1.18 but not 1.17. Updates #49700. Change-Id: Id356786aad351568ba6665430f093f5f78bb4357 Reviewed-on: https://go-review.googlesource.com/c/go/+/405474 Reviewed-by: David Chase Reviewed-by: Dmitri Shuralyov Reviewed-by: Dmitri Shuralyov --- diff --git a/src/cmd/objdump/objdump_test.go b/src/cmd/objdump/objdump_test.go index f231a7c6e0..1ce21c46ab 100644 --- a/src/cmd/objdump/objdump_test.go +++ b/src/cmd/objdump/objdump_test.go @@ -106,6 +106,9 @@ var ppcGnuNeed = []string{ } func mustHaveDisasm(t *testing.T) { + if strings.HasPrefix(testenv.Builder(), "darwin-arm64") { + t.Skipf("builder %q has an incompatible version of XCode installed, see go.dev/issue/49700", testenv.Builder()) + } switch runtime.GOARCH { case "mips", "mipsle", "mips64", "mips64le": t.Skipf("skipping on %s, issue 12559", runtime.GOARCH)