From: Tarmigan Casebolt <tarmigan@gmail.com>
Date: Sun, 21 Aug 2011 10:28:29 +0000 (+1000)
Subject: goinstall: error out with paths that end with '/'
X-Git-Tag: weekly.2011-09-01~147
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=f7b9ac765b9febe3be51cb6e29ed907279f08b59;p=gostls13.git

goinstall: error out with paths that end with '/'

R=adg, rsc, tarmigan+golang
CC=golang-dev
https://golang.org/cl/4807048
---

diff --git a/src/cmd/goinstall/main.go b/src/cmd/goinstall/main.go
index 910ab7090a..baea260e56 100644
--- a/src/cmd/goinstall/main.go
+++ b/src/cmd/goinstall/main.go
@@ -182,6 +182,12 @@ func install(pkg, parent string) {
 		visit[pkg] = done
 	}()
 
+	// Don't allow trailing '/'
+	if _, f := filepath.Split(pkg); f == "" {
+		errorf("%s should not have trailing '/'\n", pkg)
+		return
+	}
+
 	// Check whether package is local or remote.
 	// If remote, download or update it.
 	tree, pkg, err := build.FindTree(pkg)