From: Ian Lance Taylor <iant@golang.org>
Date: Wed, 26 Feb 2014 15:37:10 +0000 (-0800)
Subject: cmd/6g, cmd/8g: simplify calls to gvardef
X-Git-Tag: go1.3beta1~565
X-Git-Url: http://www.git.cypherpunks.su/?a=commitdiff_plain;h=fa6375ea47ce054d5f1d93a4a1fe7efe2e293991;p=gostls13.git

cmd/6g, cmd/8g: simplify calls to gvardef

The gvardef function does nothing if n->class == PEXTERN, so
we don't need to test for that before calling it.  This makes
the 6g/8g code more like the 5g code and clarifies that the
cases that do not test for n->class != PEXTERN are not buggy.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://golang.org/cl/68900044
---

diff --git a/src/cmd/6g/cgen.c b/src/cmd/6g/cgen.c
index e1b5d1140e..72ab0857e9 100644
--- a/src/cmd/6g/cgen.c
+++ b/src/cmd/6g/cgen.c
@@ -1389,11 +1389,11 @@ sgen(Node *n, Node *ns, int64 w)
 
 	if(n->ullman >= ns->ullman) {
 		agenr(n, &nodr, N);
-		if(ns->op == ONAME && ns->class != PEXTERN)
+		if(ns->op == ONAME)
 			gvardef(ns);
 		agenr(ns, &nodl, N);
 	} else {
-		if(ns->op == ONAME && ns->class != PEXTERN)
+		if(ns->op == ONAME)
 			gvardef(ns);
 		agenr(ns, &nodl, N);
 		agenr(n, &nodr, N);
@@ -1575,7 +1575,7 @@ componentgen(Node *nr, Node *nl)
 	switch(nl->type->etype) {
 	case TARRAY:
 		// componentgen for arrays.
-		if(nl->op == ONAME && nl->class != PEXTERN)
+		if(nl->op == ONAME)
 			gvardef(nl);
 		t = nl->type;
 		if(!isslice(t)) {
@@ -1626,7 +1626,7 @@ componentgen(Node *nr, Node *nl)
 		goto yes;
 
 	case TSTRING:
-		if(nl->op == ONAME && nl->class != PEXTERN)
+		if(nl->op == ONAME)
 			gvardef(nl);
 		nodl.xoffset += Array_array;
 		nodl.type = ptrto(types[TUINT8]);
@@ -1651,7 +1651,7 @@ componentgen(Node *nr, Node *nl)
 		goto yes;
 
 	case TINTER:
-		if(nl->op == ONAME && nl->class != PEXTERN)
+		if(nl->op == ONAME)
 			gvardef(nl);
 		nodl.xoffset += Array_array;
 		nodl.type = ptrto(types[TUINT8]);
@@ -1676,7 +1676,7 @@ componentgen(Node *nr, Node *nl)
 		goto yes;
 
 	case TSTRUCT:
-		if(nl->op == ONAME && nl->class != PEXTERN)
+		if(nl->op == ONAME)
 			gvardef(nl);
 		loffset = nodl.xoffset;
 		roffset = nodr.xoffset;
diff --git a/src/cmd/8g/cgen.c b/src/cmd/8g/cgen.c
index dc2350f491..825c360de4 100644
--- a/src/cmd/8g/cgen.c
+++ b/src/cmd/8g/cgen.c
@@ -1384,7 +1384,7 @@ componentgen(Node *nr, Node *nl)
 
 	switch(nl->type->etype) {
 	case TARRAY:
-		if(nl->op == ONAME && nl->class != PEXTERN)
+		if(nl->op == ONAME)
 			gvardef(nl);
 		nodl.xoffset += Array_array;
 		nodl.type = ptrto(nl->type->type);
@@ -1419,7 +1419,7 @@ componentgen(Node *nr, Node *nl)
 		goto yes;
 
 	case TSTRING:
-		if(nl->op == ONAME && nl->class != PEXTERN)
+		if(nl->op == ONAME)
 			gvardef(nl);
 		nodl.xoffset += Array_array;
 		nodl.type = ptrto(types[TUINT8]);
@@ -1444,7 +1444,7 @@ componentgen(Node *nr, Node *nl)
 		goto yes;
 
 	case TINTER:
-		if(nl->op == ONAME && nl->class != PEXTERN)
+		if(nl->op == ONAME)
 			gvardef(nl);
 		nodl.xoffset += Array_array;
 		nodl.type = ptrto(types[TUINT8]);