]>
Cypherpunks repositories - gostls13.git/log
Andrew Gerrand [Thu, 31 Oct 2013 23:51:42 +0000 (10:51 +1100)]
[release-branch.go1.2] runtime: remove nomemprof
««« CL
14695044 /
35d5bae6aac8
runtime: remove nomemprof
Nomemprof seems to be unneeded now, there is no recursion.
If the recursion will be re-introduced, it will break loudly by deadlocking.
Fixes #6566.
R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/
14695044
»»»
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
20540043
Andrew Gerrand [Thu, 31 Oct 2013 23:50:00 +0000 (10:50 +1100)]
[release-branch.go1.2] misc/dist: build race packages when os suffix present
««« CL
14930043 /
5746e3a5443b
misc/dist: build race packages when os suffix present
The "darwin-amd64-osx10.8" target was not matching "darwin-amd64".
R=golang-dev
CC=golang-dev
https://golang.org/cl/
14930043
»»»
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
20290045
Andrew Gerrand [Fri, 18 Oct 2013 04:53:33 +0000 (13:53 +0900)]
go1.2rc2
Andrew Gerrand [Fri, 18 Oct 2013 04:36:59 +0000 (13:36 +0900)]
api: add go1.2.txt, use in tests
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/
14860043
Andrew Gerrand [Fri, 18 Oct 2013 01:51:21 +0000 (10:51 +0900)]
misc/dist: set default go.tools tag
Fixes #6607.
R=dsymonds
CC=golang-dev
https://golang.org/cl/
14830043
Brad Fitzpatrick [Thu, 17 Oct 2013 23:06:40 +0000 (16:06 -0700)]
net/url: fix regression when serializing relative URLs
Only add a slash to path if it's a separator between
a host and path.
Fixes #6609
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/
14815043
Ian Lance Taylor [Thu, 17 Oct 2013 18:57:48 +0000 (11:57 -0700)]
runtime: correct test for when to poll network
Fixes #6610.
R=golang-dev, khr
CC=golang-dev
https://golang.org/cl/
14793043
Ian Lance Taylor [Thu, 17 Oct 2013 18:57:00 +0000 (11:57 -0700)]
runtime: correct parameter name in MCentral_AllocList comment
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
14792043
Russ Cox [Thu, 17 Oct 2013 16:13:33 +0000 (12:13 -0400)]
encoding/xml: accept chains of interfaces and pointers
Fixes #6556.
R=golang-dev, iant, adg
CC=golang-dev
https://golang.org/cl/
14747043
Alberto García Hierro [Thu, 17 Oct 2013 16:02:32 +0000 (09:02 -0700)]
database/sql: make tests repeatable with -cpu=n,n
New test added in CL
14611045 causes a deadlock when
running the tests with -cpu=n,n because the fakedb
driver always waits when opening a new connection after
running TestConnectionLeak. Reset its state after.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
14780043
David Symonds [Thu, 17 Oct 2013 00:48:27 +0000 (11:48 +1100)]
A+C: add Jamie Turner (Dropbox corporate CLA).
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/
14765043
Brad Fitzpatrick [Wed, 16 Oct 2013 23:30:39 +0000 (16:30 -0700)]
database/sql: fix some test fmt verbs
Found by vet.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
14762044
Robert Griesemer [Wed, 16 Oct 2013 23:16:54 +0000 (16:16 -0700)]
spec: clarify re-use of underlying arrays in slice operations
Please note the slight rewording for append: The spec now
requires that append reuses the underlying array if it is
sufficiently large. Per majority sentiment.
This is technically a language change but the current
implementation always worked this way.
Fixes #5818.
Fixes #5180.
R=rsc, iant, r, ken, minux.ma, dan.kortschak, rogpeppe, go.peter.90
CC=golang-dev
https://golang.org/cl/
14419054
Alberto García Hierro [Wed, 16 Oct 2013 16:22:57 +0000 (09:22 -0700)]
database/sql: Fix connection leak and potential deadlock
CL
10726044 introduced a race condition which causes connections
to be leaked under certain circumstances. If SetMaxOpenConns is
used, the application eventually deadlocks. Otherwise, the number
of open connections just keep growing indefinitely.
Fixes #6593
R=golang-dev, bradfitz, tad.glines, bketelsen
CC=golang-dev
https://golang.org/cl/
14611045
Alberto García Hierro [Wed, 16 Oct 2013 16:17:25 +0000 (09:17 -0700)]
database/sql: fix double decrement of numOpen count; test for connection leaks
Add a check at the end of every test to make sure
there are no leaked connections after running a test.
Avoid incorrectly decrementing the number of open connections
when the driver connection ends up it a bad state (numOpen was
decremented twice).
Prevent leaking a Rows struct (which ends up leaking a
connection) in Row.Scan() when a *RawBytes destination is
improperly used.
Close the Rows struct in TestRowsColumns.
Update #6593
R=golang-dev, bradfitz, dave
CC=golang-dev
https://golang.org/cl/
14642044
Shenghou Ma [Wed, 16 Oct 2013 01:35:52 +0000 (21:35 -0400)]
cmd/cgo: simpler fix for issue 6506.
Replaces CL
14682044 .
Fixes #6506.
R=rsc, iant, dave
CC=golang-dev
https://golang.org/cl/
14717043
Shenghou Ma [Wed, 16 Oct 2013 01:30:49 +0000 (21:30 -0400)]
doc/effective_go.html: fix code example
Fixes #6595.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
14425062
Russ Cox [Tue, 15 Oct 2013 19:00:48 +0000 (15:00 -0400)]
cmd/cgo: print the builtin prolog after the per-file preamble
The preamble may want to #define some special symbols
and then #include <sys/types.h> itself. The builtin prolog
also #includes <sys/types.h>, which would break such a
preamble (because the second #include will be a no-op).
The use of sys/types.h in the builtin prolog is new since Go 1.1,
so this should preserve the semantics of more existing cgo
code than we would otherwise.
It also fixes src/pkg/syscall/mkall.sh's use of go tool cgo -godefs
on some Linux systems.
Thanks to fullung@ for identifying the problem.
Fixes #6558.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/
14684044
Alex Brainman [Tue, 15 Oct 2013 18:37:43 +0000 (14:37 -0400)]
undo CL
14231047 /
2f4c2dde2756
undone because the change slows down profile collection
significantly and unpredictable at times (see comments
at https://golang.org/cl/
14231047 for details)
««« original CL description
runtime: collect profiles even while on g0 stack
Fixes #6417
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
14231047
»»»
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
14535046
Russ Cox [Tue, 15 Oct 2013 18:34:46 +0000 (14:34 -0400)]
cmd/cgo: fix Xcode 5 incompatibility for #defined expressions
Ensure that clang always exits with a non-zero status by
giving it something that it always warns about (the statement "1;").
Fixes #6128.
R=golang-dev, iant, minux.ma
CC=golang-dev
https://golang.org/cl/
14702043
Russ Cox [Tue, 15 Oct 2013 18:25:29 +0000 (14:25 -0400)]
misc/cgo/test: cut out non-standard functions
Otherwise the link fails. Fixes build.
TBR=golang-dev
CC=golang-dev
https://golang.org/cl/
14483050
Russ Cox [Tue, 15 Oct 2013 17:46:57 +0000 (13:46 -0400)]
misc/cgo/test: fix build (define prototype for alloca)
TBR=golang-dev
CC=golang-dev
https://golang.org/cl/
14454063
Russ Cox [Tue, 15 Oct 2013 16:46:14 +0000 (12:46 -0400)]
cmd/cgo: work around bug in clang debug info for builtins like memset
Fixes #6506.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
14682044
Oling Cat [Tue, 15 Oct 2013 07:41:23 +0000 (18:41 +1100)]
doc/contrib.html: fix some tags
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
14516057
Alex Brainman [Tue, 15 Oct 2013 02:00:06 +0000 (13:00 +1100)]
runtime/pprof: disable flaky TestGoroutineSwitch on windows
Update #6417
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
14604043
Keith Randall [Mon, 14 Oct 2013 21:26:52 +0000 (14:26 -0700)]
cmd/gc: fix comment about performing indexing at compile time.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
14441070
Michael Piatek [Mon, 14 Oct 2013 21:22:04 +0000 (08:22 +1100)]
net/http: skip content-type sniffing if the header is explicitly unset.
Fixes #5953
R=dsymonds, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/
14434044
David Symonds [Mon, 14 Oct 2013 21:21:30 +0000 (08:21 +1100)]
C: add Michael Piatek (Google CLA).
R=golang-dev, r
CC=golang-dev, piatek
https://golang.org/cl/
14681043
Ian Lance Taylor [Mon, 14 Oct 2013 17:53:55 +0000 (10:53 -0700)]
debug/dwarf: report the value of an unrecognized attribute format
R=golang-dev, r, minux.ma
CC=golang-dev
https://golang.org/cl/
14669045
Shenghou Ma [Mon, 14 Oct 2013 04:18:46 +0000 (00:18 -0400)]
cmd/api: make it work even when cgo is disabled
make use of $USER or %USERNAME% to determine the current user.
Fixes #6578.
R=golang-dev, bradfitz, alex.brainman
CC=golang-dev
https://golang.org/cl/
14649043
Shenghou Ma [Sat, 12 Oct 2013 22:40:41 +0000 (18:40 -0400)]
doc: fix small HTML problems
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/
14629043
Rob Pike [Fri, 11 Oct 2013 23:39:40 +0000 (16:39 -0700)]
doc/effective_go.html: fix unescaped less-than character
Why doesn't tidy complain about these?
Found by manlio.perillo.
Fixes #6571
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
14608044
Ian Lance Taylor [Fri, 11 Oct 2013 23:17:45 +0000 (16:17 -0700)]
go/build: add GOOS and GOARCH to name of gccgo pkg directory
This matches the behaviour of builder.includeArgs in
cmd/go/build.go.
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/
14535048
Ian Lance Taylor [Fri, 11 Oct 2013 22:55:50 +0000 (15:55 -0700)]
go/build: fix test if built with CGO_ENABLED=0
Fixes #6567.
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/
14502060
Ian Lance Taylor [Fri, 11 Oct 2013 18:24:54 +0000 (11:24 -0700)]
misc/cgo/test: fix C panic test to work with gccgo
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/
14611043
Ian Lance Taylor [Fri, 11 Oct 2013 15:55:13 +0000 (08:55 -0700)]
doc/progs: don't try building cgo tests if CGO_ENABLED=0
R=golang-dev, jsing, r
CC=golang-dev
https://golang.org/cl/
14523056
Shenghou Ma [Fri, 11 Oct 2013 02:43:34 +0000 (22:43 -0400)]
cmd/gc: re-word some error messages
Fixes #6557.
R=golang-dev, rsc, tracey.brendan
CC=golang-dev
https://golang.org/cl/
14432053
Andrew Gerrand [Fri, 11 Oct 2013 01:37:32 +0000 (10:37 +0900)]
go.tools/misc/dist: copy doc.go from go.tools to go root
This will allow "godoc godoc", "godoc vet", "godoc cover" to work.
Fixes #6527.
R=r, dsymonds
CC=golang-dev
https://golang.org/cl/
14566049
Yasuhiro Matsumoto [Fri, 11 Oct 2013 00:30:03 +0000 (11:30 +1100)]
misc/vim: complete packages in src directory
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
14454059
Rob Pike [Fri, 11 Oct 2013 00:26:03 +0000 (17:26 -0700)]
doc/effective_go.html: fix a couple of cosmetic issues
At the moment, godoc expands the example in the link, but in
the past it has not. Add a waffle word to allow either possibility.
Also change the order of cases in the switch in Compare to
be consistent with the other switch in the function.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/
14439055
Francesc Campoy [Fri, 11 Oct 2013 00:16:17 +0000 (17:16 -0700)]
lib/codereview: return an empty list when CONTRIBUTORS is not found instead of None.
R=adg, campoy, r
CC=golang-dev
https://golang.org/cl/
14419059
Dominik Honnef [Thu, 10 Oct 2013 23:30:47 +0000 (16:30 -0700)]
codereview: fix hg sync closing of CLs for subrepositories
The regexp for closing CLs that were sent by you but committed by
someone else only matched messages for the main repository,
because of the added &repo=... for subrepositories.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
14512045
Dominik Honnef [Thu, 10 Oct 2013 20:49:19 +0000 (16:49 -0400)]
misc/emacs: send correct content-length to the playground
R=adonovan
CC=golang-dev
https://golang.org/cl/
14548049
Dominik Honnef [Thu, 10 Oct 2013 20:30:20 +0000 (16:30 -0400)]
misc/emacs: don't treat (foo)(bar) as a function call when preceded by a word character.
Fixes #6531.
R=adonovan
CC=golang-dev
https://golang.org/cl/
14523043
Ian Lance Taylor [Wed, 9 Oct 2013 20:52:29 +0000 (13:52 -0700)]
net: fix TestDialFailPDLeak to work when GOMAXPROCS is large
Fixes #6553.
R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/
14526048
Keith Randall [Wed, 9 Oct 2013 20:28:47 +0000 (13:28 -0700)]
runtime: markfreed's error reports should be prefixed with "markfreed", not "markallocated".
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/
14441055
Ian Lance Taylor [Wed, 9 Oct 2013 17:35:46 +0000 (10:35 -0700)]
cmd/go: add any .c/.cc files to the SWIG shared library
Also add the action's object directory to the list of
directories we use to find SWIG shared libraries.
Fixes #6521.
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/
14369043
Ian Lance Taylor [Wed, 9 Oct 2013 15:44:47 +0000 (08:44 -0700)]
runtime/cgo: mark callback functions as NOSPLIT
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/
14448044
Russ Cox [Wed, 9 Oct 2013 15:08:22 +0000 (11:08 -0400)]
debug/dwarf: handle surprising clang encoding
Fixes a bug in cgo on OS X using clang.
See golang.org/issue/6472 for details.
Fixes #6472.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/
14575043
Ian Lance Taylor [Wed, 9 Oct 2013 13:44:11 +0000 (06:44 -0700)]
net: fix typo in failure message in test
R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/
14582043
Russ Cox [Wed, 9 Oct 2013 12:37:06 +0000 (08:37 -0400)]
compress/flate: fix infinite loop on malformed data
Test using compress/gzip, because that's how the
data arrived.
Fixes #6550.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
14441051
Rob Pike [Tue, 8 Oct 2013 23:16:24 +0000 (16:16 -0700)]
lib/time: update time zone files to version 2013g
This dataset is current as of Sep 30, 2013.
Fixes #6524
R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/
14570044
Rob Pike [Tue, 8 Oct 2013 20:13:40 +0000 (13:13 -0700)]
encoding/gob: add examples
Also tweak the package document, putting in section headings and
adding a sentence about intended use.
Fixes #4925.
R=golang-dev, iant, adg, ugorji
CC=golang-dev
https://golang.org/cl/
14519044
Andrew Gerrand [Tue, 8 Oct 2013 20:05:43 +0000 (07:05 +1100)]
doc: fix a few broken links
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
14494044
Alan Donovan [Tue, 8 Oct 2013 18:36:20 +0000 (14:36 -0400)]
test: revert changes made for Go SSA interpreter test.
R=r, gri
CC=golang-dev
https://golang.org/cl/
14552044
Carl Shapiro [Tue, 8 Oct 2013 17:40:51 +0000 (10:40 -0700)]
cmd/go, runtime: express armv5t architecture constraint differently
Instead of adding an -march=armv5t flag to the gcc command
line, the same effect is obtained with an ".arch armv5t"
pseudo op in the assembly file that uses armv5t instructions.
R=golang-dev, iant, dave
CC=golang-dev
https://golang.org/cl/
14511044
Andrew Gerrand [Tue, 8 Oct 2013 05:53:56 +0000 (16:53 +1100)]
A+C: Tw (individual CLA)
Generated by addca.
R=gobot
CC=golang-dev
https://golang.org/cl/
14502047
Andrew Gerrand [Tue, 8 Oct 2013 00:14:35 +0000 (11:14 +1100)]
doc/articles/wiki: fix path handling and clean up test process
Fixes #6525.
R=r
CC=golang-dev
https://golang.org/cl/
14383043
Rob Pike [Mon, 7 Oct 2013 23:32:47 +0000 (16:32 -0700)]
math: the trig functions work in radians; document that
Fixes #6543
6543 is also a fine NGC object.
R=golang-dev, dsymonds, kamil.kisiel, minux.ma
CC=golang-dev
https://golang.org/cl/
14515044
Robert Griesemer [Mon, 7 Oct 2013 17:43:28 +0000 (10:43 -0700)]
spec: unsafe.Pointers are pointers
But they cannot be dereferenced.
See also issue 6116.
Fixes #6358.
R=r, rsc, iant, ken
CC=golang-dev
https://golang.org/cl/
14374046
Dominik Honnef [Mon, 7 Oct 2013 17:08:26 +0000 (13:08 -0400)]
misc/emacs: find unused imports where path and package name differ
The Go compiler emits extra information for this case:
imported and not used: "sandbox/foo_bar" as bar
R=adonovan
CC=golang-dev
https://golang.org/cl/
14111043
Joel Sing [Mon, 7 Oct 2013 16:21:33 +0000 (09:21 -0700)]
os/user: fix user lookups on dragonfly
Like FreeBSD, DragonFly does not provide a sysconf value for
_SC_GETPW_R_SIZE_MAX.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/
14469043
Joel Sing [Mon, 7 Oct 2013 16:12:17 +0000 (09:12 -0700)]
os/user: enable tests on all supported platforms
All of the currently supported platforms have a working user
implementation and do not use stubs. As a result, enable the tests
on all platforms rather than whitelisting.
R=golang-dev, dave, iant
CC=golang-dev
https://golang.org/cl/
14454044
Joel Sing [Mon, 7 Oct 2013 16:04:20 +0000 (09:04 -0700)]
os/signal: make test logs reflect reality
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/
14470043
Jeff Sickel [Mon, 7 Oct 2013 15:41:27 +0000 (11:41 -0400)]
codereview: move dotfiles out of user home director to something sane.
See Rob Pike's lesson on shortcuts, https://plus.google.com/
101960720994009339267 /posts/R58WgWwN9jp
R=golang-dev, r, rsc
CC=aram.h, golang-dev
https://golang.org/cl/
14374045
Russ Cox [Mon, 7 Oct 2013 15:40:59 +0000 (11:40 -0400)]
A+C: Jeff Sickel (individual CLA)
Generated by addca.
R=gobot
CC=golang-dev
https://golang.org/cl/
14467045
David Symonds [Sat, 5 Oct 2013 04:15:02 +0000 (14:15 +1000)]
A+C: add Marko Juhani Silokunnas (individual CLA).
R=golang-dev, adg
CC=golang-dev, mikioh.mikioh
https://golang.org/cl/
14417043
Keith Randall [Fri, 4 Oct 2013 20:54:03 +0000 (13:54 -0700)]
runtime: fix bug in maps at the intersection of iterators, growing, and NaN keys
If an iterator is started while a map is in the middle of a grow,
and the map has NaN keys, then those keys might get returned by
the iterator more than once. This fix makes the evacuation decision
deterministic and repeatable for NaN keys so each one gets returned
only once.
R=golang-dev, r, khr, iant
CC=golang-dev
https://golang.org/cl/
14367043
Keith Randall [Fri, 4 Oct 2013 20:22:20 +0000 (13:22 -0700)]
runtime: remove 3 unused declarations.
R=golang-dev, cshapiro, iant
CC=golang-dev
https://golang.org/cl/
14405043
Ian Lance Taylor [Fri, 4 Oct 2013 20:12:50 +0000 (13:12 -0700)]
reflect: test using a MakeFunc value in a couple of different ways
The gccgo implementation mishandled calling Interface on a
value created by MakeFunc.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
14401043
Mikio Hara [Fri, 4 Oct 2013 04:13:56 +0000 (13:13 +0900)]
doc/go1.2.html: update a minor change to syscall
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
14379043
Alex Brainman [Fri, 4 Oct 2013 03:53:34 +0000 (13:53 +1000)]
runtime: collect profiles even while on g0 stack
Fixes #6417
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
14231047
Andrew Gerrand [Fri, 4 Oct 2013 01:46:32 +0000 (11:46 +1000)]
A+C: Matt Reiferson (individual CLA)
Generated by addca.
R=gobot
CC=golang-dev
https://golang.org/cl/
14375043
Andrew Gerrand [Thu, 3 Oct 2013 23:45:06 +0000 (09:45 +1000)]
doc: move spec and memory model back to /ref/
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
14364043
Robert Griesemer [Thu, 3 Oct 2013 23:38:22 +0000 (16:38 -0700)]
spec: added additional links, added missing 'label'
No semantic spec changes.
R=r
CC=golang-dev
https://golang.org/cl/
14363043
Ian Lance Taylor [Thu, 3 Oct 2013 20:23:02 +0000 (13:23 -0700)]
reflect: add a test that gccgo mishandled
Failure occurred when using reflect.Call to pass a func value
following a non-pointer value.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
14186043
Robert Hencke [Thu, 3 Oct 2013 19:46:02 +0000 (12:46 -0700)]
spec: fix small typo in comment for example
R=golang-dev, mirtchovski, r
CC=golang-dev
https://golang.org/cl/
14227043
Robert Hencke [Thu, 3 Oct 2013 17:55:17 +0000 (10:55 -0700)]
gofmt: explain why lower bounds aren't automatically simplified
Full credit goes to gri and rsc for their explanations.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
14229043
Russ Cox [Thu, 3 Oct 2013 17:53:16 +0000 (13:53 -0400)]
doc: remove link to PackageVersioning wiki
That page may be fine for experienced Go programmers
but it's not really targeting new programmers.
There's too much we don't know yet.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
14345043
Rob Pike [Thu, 3 Oct 2013 17:40:42 +0000 (10:40 -0700)]
sync/atomic: explain how to subtract an unsigned constant
Explain for those unfamiliar with twos-complement arithmetic how to
implement negation of signed positive constant.
Fixes #6408.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
14267044
Russ Cox [Thu, 3 Oct 2013 13:49:12 +0000 (09:49 -0400)]
go/doc: update ToHTML doc comment
Update #5429
R=golang-dev, r, dan.kortschak
CC=golang-dev
https://golang.org/cl/
14293043
Russ Cox [Thu, 3 Oct 2013 13:19:10 +0000 (09:19 -0400)]
runtime: change default stack segment size to 8 kB
Changing from 4 kB to 8 kB brings significant improvement
on a variety of the Go 1 benchmarks, on both amd64
and 386 systems.
Significant runtime reductions:
amd64 386
GoParse -14% -1%
GobDecode -12% -20%
GobEncode -64% -1%
JSONDecode -9% -4%
JSONEncode -15% -5%
Template -17% -14%
In the longer term, khr's new stacks will avoid needing to
make this decision at all, but for Go 1.2 this is a reasonable
stopgap that makes performance significantly better.
Demand paging should mean that if the second 4 kB is not
used, it will not be brought into memory, so the change
should not adversely affect resident set size.
The same argument could justify bumping as high as 64 kB
on 64-bit machines, but there are diminishing returns
after 8 kB, and using 8 kB limits the possible unintended
memory overheads we are not aware of.
Benchmark graphs at
http://swtch.com/~rsc/gostackamd64.html
http://swtch.com/~rsc/gostack386.html
Full data at
http://swtch.com/~rsc/gostack.zip
R=golang-dev, khr, dave, bradfitz, dvyukov
CC=golang-dev
https://golang.org/cl/
14317043
Russ Cox [Thu, 3 Oct 2013 13:18:47 +0000 (09:18 -0400)]
doc/faq: add a FAQ about versioning
Fixes #5633.
R=golang-dev, r, tommi.virtanen, adg, nj
CC=golang-dev
https://golang.org/cl/
14283044
Dave Day [Thu, 3 Oct 2013 03:48:47 +0000 (13:48 +1000)]
cmd/gc: support -installsuffix in the compiler and builder
Add the -installsuffix flag to gc and {5,6,8}l, which overrides -race
for the suffix if both are supplied.
Pass this flag from the go tool for build and install.
R=rsc
CC=golang-dev
https://golang.org/cl/
14246044
Yasuhiro Matsumoto [Thu, 3 Oct 2013 03:32:07 +0000 (13:32 +1000)]
misc/vim: Autocompletion for :Godoc command
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
14259043
Russ Cox [Thu, 3 Oct 2013 02:09:54 +0000 (22:09 -0400)]
net: use original argument in lookup error
Fixes #6324.
R=golang-dev, iant, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/
13280049
Russ Cox [Thu, 3 Oct 2013 01:42:23 +0000 (21:42 -0400)]
cmd/go: document relative imports
Fixes #3524.
R=golang-dev, iant, r
CC=golang-dev
https://golang.org/cl/
14296043
Russ Cox [Thu, 3 Oct 2013 01:40:01 +0000 (21:40 -0400)]
crypto/tls: document ConnectionState fields
Fixes #6456.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
14289043
Russ Cox [Thu, 3 Oct 2013 01:39:45 +0000 (21:39 -0400)]
runtime: remove syscall.NewCallbackCDecl on Windows
It is not possible to use (there is no declaration in package syscall),
and no one seems to care.
Alex Brainman may bring this back properly for Go 1.3.
Fixes #6338.
R=golang-dev, r, alex.brainman
CC=golang-dev
https://golang.org/cl/
14287043
Shenghou Ma [Thu, 3 Oct 2013 00:14:54 +0000 (20:14 -0400)]
misc/dist: support building statically linked toolchain.
so that we don't need worry about specifying the required
libc version (note: as cmd/go will still be dynamically
linked to libc, we still need to perform the build on OSes
with an old enough libc. But as cmd/go doesn't rely on many
libc symbols, the situation should be significantly better).
Fixes #3564.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
14261043
Josh Bleecher Snyder [Wed, 2 Oct 2013 22:52:18 +0000 (08:52 +1000)]
encoding/json: add an example for RawMessage
RawMessage is useful and mildly non-obvious.
Given the frequency with which RawMessage questions
show up on golang-nuts, and get answered with an example,
I suspect adding an example to the docs might help.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
14190044
Rob Pike [Wed, 2 Oct 2013 18:35:25 +0000 (11:35 -0700)]
doc/effective_go: fix server example that shares var between goroutines
Use it as a teaching example about how to solve this problem.
Fixes #6501
R=golang-dev, adg, rsc
CC=golang-dev
https://golang.org/cl/
14250043
Russ Cox [Wed, 2 Oct 2013 17:21:15 +0000 (13:21 -0400)]
net/http: be clear that HTTPS is supported
Fixes #6443.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/
14231045
Russ Cox [Wed, 2 Oct 2013 16:30:49 +0000 (12:30 -0400)]
runtime: fix finalizer test on amd64
Not scanning the stack by frames means we are reintroducing
a few false positives into the collection. Run the finalizer registration
in its own goroutine so that stack is guaranteed to be out of
consideration in a later collection.
This is working around a regression from yesterday's tip, but
it's not a regression from Go 1.1.
R=golang-dev
TBR=golang-dev
CC=golang-dev
https://golang.org/cl/
14290043
Rémy Oudompheng [Wed, 2 Oct 2013 16:27:33 +0000 (12:27 -0400)]
cmd/gc: qualified embedded fields with owner package.
R=rsc
CC=golang-dev
https://golang.org/cl/
14188044
Frithjof Schulze [Wed, 2 Oct 2013 16:09:13 +0000 (12:09 -0400)]
crypto/tls: Update reference to the TLS 1.2 RFC.
Ticket
13740047 updated the documented TLS version to 1.2.
This also updates the RFC refered to.
R=golang-dev
CC=golang-dev, rsc
https://golang.org/cl/
14029043
Russ Cox [Wed, 2 Oct 2013 15:59:53 +0000 (11:59 -0400)]
runtime: do not scan stack by frames during garbage collection
Walking the stack by frames is ~3x more expensive
than not, and since it didn't end up being precise,
there is not enough benefit to outweigh the cost.
This is the conservative choice: this CL makes the
stack scanning behavior the same as it was in Go 1.1.
Add benchmarks to package runtime so that we have
them when we re-enable this feature during the
Go 1.3 development.
benchmark old ns/op new ns/op delta
BenchmarkGoroutineSelect
3194909 1272092 -60.18%
BenchmarkGoroutineBlocking
3120282 866366 -72.23%
BenchmarkGoroutineForRange
3256179 939902 -71.13%
BenchmarkGoroutineIdle
2005571 482982 -75.92%
The Go 1 benchmarks, just to add more data.
As far as I can tell the changes are mainly noise.
benchmark old ns/op new ns/op delta
BenchmarkBinaryTree17
4409403046 4414734932 +0.12%
BenchmarkFannkuch11
3407708965 3378306120 -0.86%
BenchmarkFmtFprintfEmpty 100 99 -0.60%
BenchmarkFmtFprintfString 242 239 -1.24%
BenchmarkFmtFprintfInt 204 206 +0.98%
BenchmarkFmtFprintfIntInt 320 316 -1.25%
BenchmarkFmtFprintfPrefixedInt 295 299 +1.36%
BenchmarkFmtFprintfFloat 442 435 -1.58%
BenchmarkFmtManyArgs 1246 1216 -2.41%
BenchmarkGobDecode
10186951 10051210 -1.33%
BenchmarkGobEncode
16504381 16445650 -0.36%
BenchmarkGzip
447030885 447056865 +0.01%
BenchmarkGunzip
111056154 111696305 +0.58%
BenchmarkHTTPClientServer 89973 93040 +3.41%
BenchmarkJSONEncode
28174182 27933893 -0.85%
BenchmarkJSONDecode
106353777 110443817 +3.85%
BenchmarkMandelbrot200
4822289 4806083 -0.34%
BenchmarkGoParse
6102436 6142734 +0.66%
BenchmarkRegexpMatchEasy0_32 133 132 -0.75%
BenchmarkRegexpMatchEasy0_1K 372 373 +0.27%
BenchmarkRegexpMatchEasy1_32 113 111 -1.77%
BenchmarkRegexpMatchEasy1_1K 964 940 -2.49%
BenchmarkRegexpMatchMedium_32 202 205 +1.49%
BenchmarkRegexpMatchMedium_1K 68862 68858 -0.01%
BenchmarkRegexpMatchHard_32 3480 3407 -2.10%
BenchmarkRegexpMatchHard_1K 108255 112614 +4.03%
BenchmarkRevcomp
751393035 743929976 -0.99%
BenchmarkTemplate
139637041 135402220 -3.03%
BenchmarkTimeParse 479 475 -0.84%
BenchmarkTimeFormat 460 466 +1.30%
benchmark old MB/s new MB/s speedup
BenchmarkGobDecode 75.34 76.36 1.01x
BenchmarkGobEncode 46.50 46.67 1.00x
BenchmarkGzip 43.41 43.41 1.00x
BenchmarkGunzip 174.73 173.73 0.99x
BenchmarkJSONEncode 68.87 69.47 1.01x
BenchmarkJSONDecode 18.25 17.57 0.96x
BenchmarkGoParse 9.49 9.43 0.99x
BenchmarkRegexpMatchEasy0_32 239.58 241.74 1.01x
BenchmarkRegexpMatchEasy0_1K 2749.74 2738.00 1.00x
BenchmarkRegexpMatchEasy1_32 282.49 286.32 1.01x
BenchmarkRegexpMatchEasy1_1K 1062.00 1088.96 1.03x
BenchmarkRegexpMatchMedium_32 4.93 4.86 0.99x
BenchmarkRegexpMatchMedium_1K 14.87 14.87 1.00x
BenchmarkRegexpMatchHard_32 9.19 9.39 1.02x
BenchmarkRegexpMatchHard_1K 9.46 9.09 0.96x
BenchmarkRevcomp 338.26 341.65 1.01x
BenchmarkTemplate 13.90 14.33 1.03x
Fixes #6482.
R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/
14257043
Shenghou Ma [Wed, 2 Oct 2013 03:44:20 +0000 (23:44 -0400)]
cmd/dist, build: support building statically linked toolchain
Added a new $GO_DISTFLAGS to make.bash, and while we're here,
added mention $CXX in make.bash (CL
13704044 ).
Fixes #6448.
Update #3564
We can pass GO_DISTFLAGS=-s from misc/dist to make.bash so that
it will build a statically linked toolchain.
(Note: OS X doesn't have the concept of static linking, so don't
pass GO_DISTFLAGS=-s for OS X builds)
R=adg, rsc, iant
CC=golang-dev
https://golang.org/cl/
13887043
Andrew Gerrand [Wed, 2 Oct 2013 01:46:44 +0000 (11:46 +1000)]
doc: rename @go_nuts to @golang
Yay!
R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/
14256043
Dave Day [Wed, 2 Oct 2013 00:44:57 +0000 (20:44 -0400)]
cmd/go: use -installsuffix to determine the includes directory list
Currently, the directories generaed by includeArgs can have the "_race"
suffix added if invoked with -race flag, but ignores -installsuffix if
set.
R=adg, rsc
CC=golang-dev
https://golang.org/cl/
14174043