]>
Cypherpunks repositories - gostls13.git/log
Nigel Tao [Thu, 25 Mar 2010 05:15:52 +0000 (16:15 +1100)]
Sydney University tech talk.
R=adg
CC=golang-dev
https://golang.org/cl/744042
Russ Cox [Thu, 25 Mar 2010 05:12:59 +0000 (22:12 -0700)]
gc: tests omitted from the last bug fix
R=ken2
CC=golang-dev
https://golang.org/cl/748041
Giles Lean [Thu, 25 Mar 2010 04:59:21 +0000 (21:59 -0700)]
syscall: bring generated files zsyscall_darwin_*.go
up to date.
No functional change, but when these files are regenerated
they change, leading to noisy diffs when working in the
syscall package.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/705043
Russ Cox [Thu, 25 Mar 2010 02:52:07 +0000 (19:52 -0700)]
test/mallocfin: relax test to 80% from 90%.
R=r
CC=golang-dev
https://golang.org/cl/725042
Alex Brainman [Thu, 25 Mar 2010 01:03:10 +0000 (18:03 -0700)]
runtime: fix mingw build, implement missing destroylock()
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/747041
Ken Thompson [Wed, 24 Mar 2010 23:53:54 +0000 (16:53 -0700)]
depricate panicln
R=rsc
CC=golang-dev
https://golang.org/cl/743041
Rob Pike [Wed, 24 Mar 2010 23:46:53 +0000 (16:46 -0700)]
delete all uses of panicln by rewriting them using panic or,
in the tests, println+panic.
gofmt some tests too.
R=rsc
CC=golang-dev
https://golang.org/cl/741041
Robert Griesemer [Wed, 24 Mar 2010 23:28:59 +0000 (16:28 -0700)]
godoc: show relative file names without leading '/' (per r's request)
- change the various url-xxx formatters to return a relative URL path
- make the leading '/' for URLs explicit in the template
- on the way change some |html formatters to |html-esc
(html should only be used for formatting AST nodes)
R=rsc, r
CC=golang-dev
https://golang.org/cl/740041
Rob Pike [Wed, 24 Mar 2010 22:17:00 +0000 (15:17 -0700)]
Delete panicln from the spec.
R=rsc, gri, iant, ken2
CC=golang-dev
https://golang.org/cl/738041
Robert Griesemer [Wed, 24 Mar 2010 21:51:55 +0000 (14:51 -0700)]
godoc: use http GET for remote search instead of rpc
(this will allow the use of golang.org for remote
searches)
R=rsc
CC=golang-dev
https://golang.org/cl/734041
Russ Cox [Wed, 24 Mar 2010 16:40:09 +0000 (09:40 -0700)]
runtime: malloc sampling, pprof interface
R=r
CC=golang-dev
https://golang.org/cl/719041
Charles L. Dorian [Wed, 24 Mar 2010 16:25:49 +0000 (09:25 -0700)]
math: add J0 and Y0 (Bessel functions)
R=rsc
CC=golang-dev
https://golang.org/cl/661044
Russ Cox [Wed, 24 Mar 2010 15:59:09 +0000 (08:59 -0700)]
cc: fix typo
R=iant
CC=golang-dev
https://golang.org/cl/720041
Russ Cox [Wed, 24 Mar 2010 03:48:23 +0000 (20:48 -0700)]
runtime: add memory profiling, disabled.
no way to get the data out yet.
add prototype for runtime.Callers,
missing from last CL.
R=r
CC=golang-dev
https://golang.org/cl/713041
Dean Prichard [Wed, 24 Mar 2010 01:13:20 +0000 (18:13 -0700)]
arm: fix build
R=kaib, rsc
CC=golang-dev
https://golang.org/cl/627045
Andrey Mirtchovski [Wed, 24 Mar 2010 01:13:16 +0000 (18:13 -0700)]
cmd/goinstall: include command name in error reporting (usually missing software or incorrect $PATH)
R=rsc
CC=golang-dev
https://golang.org/cl/695041
Russ Cox [Wed, 24 Mar 2010 01:11:21 +0000 (18:11 -0700)]
gc: fix build in France
Fixes #626.
R=ken2
CC=golang-dev
https://golang.org/cl/714041
Fumitoshi Ukai [Wed, 24 Mar 2010 01:09:24 +0000 (18:09 -0700)]
websocket: implement new protocol
http://www.whatwg.org/specs/web-socket-protocol/
(draft of draft-hixie-thewebsocketprotocol-76)
draft-hixie-thewebsocketprotocol-76 will introduce new handshake
incompatible draft 75 or prior.
http://tools.ietf.org/html/draft-hixie-thewebsocketprotocol
R=rsc
CC=golang-dev
https://golang.org/cl/583041
Giles Lean [Wed, 24 Mar 2010 00:52:16 +0000 (17:52 -0700)]
Trivial: remove duplicate line #include <sys/types.h>
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/645044
Russ Cox [Wed, 24 Mar 2010 00:34:13 +0000 (17:34 -0700)]
fix build - unused import
R=gri
CC=golang-dev
https://golang.org/cl/711041
Robert Griesemer [Wed, 24 Mar 2010 00:30:14 +0000 (17:30 -0700)]
go spec: modification of defer statement
R=r, rsc, ken2, iant
CC=golang-dev
https://golang.org/cl/708041
Rob Pike [Wed, 24 Mar 2010 00:03:28 +0000 (17:03 -0700)]
FAQ: Protocol buffers are now supported. Update the entry.
R=rsc, adg
CC=golang-dev
https://golang.org/cl/702042
Russ Cox [Wed, 24 Mar 2010 00:01:17 +0000 (17:01 -0700)]
runtime: add Callers
cut copies of traceback from 6 to 1.
R=r
CC=golang-dev
https://golang.org/cl/703041
Russ Cox [Tue, 23 Mar 2010 23:56:48 +0000 (16:56 -0700)]
go/printer: avoid reflect in print
R=gri
CC=golang-dev
https://golang.org/cl/704041
Robert Griesemer [Tue, 23 Mar 2010 21:01:51 +0000 (14:01 -0700)]
Go spec: map indexing never raises a runtime exception.
Also: Actual map key must be assignment-compatible with
formal map key type.
Fixes #357.
R=r, iant, rsc, ken2
CC=golang-dev
https://golang.org/cl/673042
Kyle Consalus [Tue, 23 Mar 2010 20:20:16 +0000 (13:20 -0700)]
xml: add line numbers to syntax errors.
R=rsc
CC=golang-dev
https://golang.org/cl/699041
Ken Thompson [Tue, 23 Mar 2010 20:00:02 +0000 (13:00 -0700)]
maps access to a missing key
will return the "zero" value
R=rsc
CC=golang-dev
https://golang.org/cl/700041
Kyle Consalus [Tue, 23 Mar 2010 16:43:20 +0000 (09:43 -0700)]
xml: add CopyToken
R=rsc
CC=golang-dev
https://golang.org/cl/634042
Ian Lance Taylor [Tue, 23 Mar 2010 13:46:30 +0000 (06:46 -0700)]
Add support for #pragma dynexport.
R=rsc
CC=golang-dev
https://golang.org/cl/661043
Andrew Gerrand [Tue, 23 Mar 2010 03:18:57 +0000 (14:18 +1100)]
release.2010-03-22 part two
R=rsc
CC=golang-dev
https://golang.org/cl/691041
Ian Lance Taylor [Tue, 23 Mar 2010 02:58:55 +0000 (19:58 -0700)]
Rename dynld to dynimport throughout.
Cgo users will need to rerun cgo.
R=rsc
CC=golang-dev
https://golang.org/cl/692041
Andrew Gerrand [Tue, 23 Mar 2010 01:56:39 +0000 (12:56 +1100)]
release.2010-03-22
R=rsc
CC=golang-dev
https://golang.org/cl/643042
Russ Cox [Tue, 23 Mar 2010 01:51:14 +0000 (18:51 -0700)]
gc: various map-related bug fixes
Fixes #687.
R=ken2
CC=golang-dev
https://golang.org/cl/680042
Andrew Gerrand [Mon, 22 Mar 2010 22:00:47 +0000 (09:00 +1100)]
ast/printer: support for printing ast.Spec nodes
R=gri
CC=golang-dev
https://golang.org/cl/682041
Russ Cox [Sun, 21 Mar 2010 05:38:06 +0000 (22:38 -0700)]
goinstall: let git/hg/svn create the final directory element
R=r
CC=golang-dev
https://golang.org/cl/634044
Russ Cox [Sun, 21 Mar 2010 05:37:53 +0000 (22:37 -0700)]
A+C: add Kyle Consalus (individual CLA)
R=r
CC=golang-dev
https://golang.org/cl/662041
Russ Cox [Sun, 21 Mar 2010 05:37:23 +0000 (22:37 -0700)]
libmach: more info when memory reads fail on Darwin
R=r
CC=golang-dev
https://golang.org/cl/604043
Ken Thompson [Sun, 21 Mar 2010 01:50:01 +0000 (18:50 -0700)]
issue 682
complex DATA statement fo
initialization of complex variables.
R=rsc
CC=golang-dev
https://golang.org/cl/634045
Robert Griesemer [Sat, 20 Mar 2010 05:48:08 +0000 (22:48 -0700)]
godoc: line numbers for all remote search results
Instead of returning the index lookup result via
RPC which has to be corrected for the client,
simply render it on the server and return the
final output.
R=rsc, r
CC=golang-dev
https://golang.org/cl/669041
Russ Cox [Sat, 20 Mar 2010 00:46:18 +0000 (17:46 -0700)]
godoc: revert change 5089, per gri's instructions
R=gri
CC=golang-dev
https://golang.org/cl/630043
Andrew Gerrand [Sat, 20 Mar 2010 00:42:57 +0000 (11:42 +1100)]
website: add Go Blog widget to frontpage,
add Blog and Wiki links to sideba
R=r, rsc, gri
CC=golang-dev
https://golang.org/cl/611042
Robert Griesemer [Sat, 20 Mar 2010 00:07:16 +0000 (17:07 -0700)]
godoc: proper file path conversion for remote search
R=rsc
CC=golang-dev
https://golang.org/cl/664041
Rob Pike [Fri, 19 Mar 2010 23:33:27 +0000 (16:33 -0700)]
Make.cmd: make 'all' the default target (was 'clean': BUG)
R=rsc
CC=golang-dev
https://golang.org/cl/661041
Russ Cox [Fri, 19 Mar 2010 23:28:32 +0000 (16:28 -0700)]
os: drop File finalizer after normal Close
R=r
CC=golang-dev
https://golang.org/cl/586043
Andrew Gerrand [Fri, 19 Mar 2010 23:22:09 +0000 (10:22 +1100)]
http: add Error helper function
R=r, rsc
CC=golang-dev
https://golang.org/cl/626042
James Toy [Fri, 19 Mar 2010 23:17:18 +0000 (16:17 -0700)]
doc/htmlgen.go: remove unnecessary semicolons
R=rsc
CC=golang-dev
https://golang.org/cl/589043
Russ Cox [Fri, 19 Mar 2010 22:54:27 +0000 (15:54 -0700)]
A+C: add James Toy (individual CLA)
R=r
CC=golang-dev
https://golang.org/cl/660041
Charles L. Dorian [Fri, 19 Mar 2010 22:29:22 +0000 (15:29 -0700)]
math: add Gamma function
R=rsc
CC=golang-dev
https://golang.org/cl/649041
Alex Brainman [Fri, 19 Mar 2010 22:21:37 +0000 (15:21 -0700)]
syscall: mingw implemntation of Errstr()
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/621041
Robert Griesemer [Fri, 19 Mar 2010 22:20:20 +0000 (15:20 -0700)]
godoc: show (some) line numbers for remote search
- show build version
- use build goroot when possible
R=rsc
CC=golang-dev
https://golang.org/cl/656043
Alex Brainman [Fri, 19 Mar 2010 22:17:18 +0000 (15:17 -0700)]
syscall: mksyscall_mingw.sh emitting shorter calls (to Syscall or Syscall6) when there are fewer arguments
R=rsc
CC=golang-dev
https://golang.org/cl/622041
Rob Pike [Fri, 19 Mar 2010 22:14:46 +0000 (15:14 -0700)]
Factor the Makefiles to make writing outside Makefiles easier.
R=rsc
CC=golang-dev
https://golang.org/cl/650042
Ken Thompson [Fri, 19 Mar 2010 21:20:15 +0000 (14:20 -0700)]
issue 608
error compiling if(long long) in 6c compiler
R=rsc
CC=golang-dev
https://golang.org/cl/657042
Fumitoshi Ukai [Fri, 19 Mar 2010 21:18:02 +0000 (14:18 -0700)]
websocket: use URL.RawPath to construct WebSocket-Location: header
R=rsc
CC=golang-dev
https://golang.org/cl/651041
Alex Brainman [Fri, 19 Mar 2010 21:17:07 +0000 (14:17 -0700)]
deps.bash: handle Makefiles with .go filenames that include $(GOOS) and $(GOARCH)
R=rsc
CC=golang-dev
https://golang.org/cl/642042
Robert Griesemer [Fri, 19 Mar 2010 20:01:45 +0000 (13:01 -0700)]
godoc: improved comment formatting: recognize URLs
and highlight special words, if provided. Also:
- related cleanups in src/pkg/go/doc/comment.go
- fix typos in src/cmd/goinstall/doc.go
Fixes #672.
R=rsc
CC=adg, golang-dev
https://golang.org/cl/601042
Robert Griesemer [Fri, 19 Mar 2010 19:46:43 +0000 (12:46 -0700)]
godoc: implemented command-line search
The command-line search is using a running webserver
as index server; i.e., the search result is reflecting
the index at the server. See the documentation for
details.
Usage: godoc -q query1 query2 ...
Known issue: Results don't show the all-important
line numbers yet due to the way the index is organized.
Next CL.
R=rsc, r
CC=golang-dev
https://golang.org/cl/648041
Andrew Gerrand [Thu, 18 Mar 2010 22:46:39 +0000 (09:46 +1100)]
template: fixed html formatter bug where it would turn a []byte
into a string of decimal numbers.
R=r, rsc
CC=golang-dev
https://golang.org/cl/624041
Robert Griesemer [Thu, 18 Mar 2010 21:10:25 +0000 (14:10 -0700)]
rpc documentation cleanup: remove ;'s from code in documentation
R=r
CC=golang-dev
https://golang.org/cl/624042
Robert Griesemer [Thu, 18 Mar 2010 21:09:17 +0000 (14:09 -0700)]
go/doc cleanup: remove some unnecessary string conversions
R=rsc
CC=golang-dev
https://golang.org/cl/642041
Alex Brainman [Thu, 18 Mar 2010 03:07:14 +0000 (20:07 -0700)]
Fix src/pkg/syscall/mkall.sh: don't assume that . is on PATH.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/614042
Ian Lance Taylor [Wed, 17 Mar 2010 17:08:27 +0000 (10:08 -0700)]
Fix build: don't assume that . is on PATH.
R=rsc
TBR=rsc
CC=golang-dev
https://golang.org/cl/610043
Russ Cox [Wed, 17 Mar 2010 06:12:20 +0000 (23:12 -0700)]
crypto/rand: new package
Until proven insufficient, rely on the operating system
to give us good random bytes (/dev/urandom).
R=agl1
CC=golang-dev
https://golang.org/cl/569044
Russ Cox [Wed, 17 Mar 2010 06:10:33 +0000 (23:10 -0700)]
runtime: add GOROOT and Version
R=r
CC=golang-dev
https://golang.org/cl/608041
Alex Brainman [Wed, 17 Mar 2010 06:10:07 +0000 (23:10 -0700)]
syscall: more changes to mingw version
- mkall now generates syscall stabs automatically
- we can call unicode versions of winapi now
- introduce GetErrstr function to fetch error text given errno
- general cleanup
R=rsc
CC=golang-dev
https://golang.org/cl/562041
Andrew Gerrand [Wed, 17 Mar 2010 04:41:16 +0000 (15:41 +1100)]
json: add MarshalIndent (accepts user-specified indent string)
Fixes #661
R=r, rsc, skorobo
CC=golang-dev
https://golang.org/cl/576042
Russ Cox [Wed, 17 Mar 2010 01:45:48 +0000 (18:45 -0700)]
syscall: add const ARCH, analogous to OS
R=r
CC=giles, golang-dev
https://golang.org/cl/600041
Russ Cox [Wed, 17 Mar 2010 01:45:16 +0000 (18:45 -0700)]
doc/install: tweak port text; drop redundant list of operating systems.
R=adg
CC=golang-dev, r
https://golang.org/cl/597041
Russ Cox [Wed, 17 Mar 2010 01:45:06 +0000 (18:45 -0700)]
version.bash: cope with ancient Mercurial
R=adg
CC=dpx, golang-dev
https://golang.org/cl/593043
Russ Cox [Wed, 17 Mar 2010 01:44:55 +0000 (18:44 -0700)]
http: change RawPath to mean raw path, not raw everything-after-scheme.
The new meaning is more useful for both websocket and http.
R=r, petar-m, ukai
CC=golang-dev, madari
https://golang.org/cl/582043
Russ Cox [Wed, 17 Mar 2010 01:44:37 +0000 (18:44 -0700)]
utf16: new package
needed for interacting with various legacy interfaces,
like Windows and the Mac OS clipboard.
R=r
CC=golang-dev
https://golang.org/cl/595041
Andrew Gerrand [Wed, 17 Mar 2010 00:40:05 +0000 (11:40 +1100)]
goinstall doc: fix link to godashboard/package
R=rsc
CC=golang-dev
https://golang.org/cl/607041
Robert Griesemer [Tue, 16 Mar 2010 23:45:54 +0000 (16:45 -0700)]
gofmt: more consistent formatting of const/var decls
- gofmt -w src misc
- only manually modified file: src/pkg/go/printer/nodes.go
R=rsc
CC=golang-dev, r
https://golang.org/cl/606041
Robert Griesemer [Tue, 16 Mar 2010 21:17:42 +0000 (14:17 -0700)]
godoc: initial support for showing popup information
for identifiers in Go source code
- at the moment just show identifier kind (var, func, etc.) and name
(eventually should show declaration, type, etc.)
- JavaScript parts by adg
R=rsc
CC=adg, golang-dev
https://golang.org/cl/578042
Russ Cox [Tue, 16 Mar 2010 21:16:33 +0000 (14:16 -0700)]
net: fix IPMask.String not to crash on all-0xff mask
R=r
CC=golang-dev
https://golang.org/cl/438042
Petar Maymounkov [Tue, 16 Mar 2010 20:57:16 +0000 (13:57 -0700)]
http: add ParseQuery
R=rsc
CC=golang-dev
https://golang.org/cl/238041
Anthony Starks [Tue, 16 Mar 2010 20:26:34 +0000 (13:26 -0700)]
misc/bbedit: support for cmplx, real, imag
R=rsc
CC=golang-dev
https://golang.org/cl/582041
Conrad Meyer [Tue, 16 Mar 2010 20:26:21 +0000 (13:26 -0700)]
sha512: add sha384 (truncated version)
R=rsc
CC=golang-dev
https://golang.org/cl/317041
Robert Griesemer [Tue, 16 Mar 2010 05:10:47 +0000 (22:10 -0700)]
image/jpeg: fix typos
Fixes #665.
R=nigeltao, nigeltao_golang
CC=golang-dev
https://golang.org/cl/570041
David Symonds [Tue, 16 Mar 2010 03:38:24 +0000 (20:38 -0700)]
Add new complex types, functions and literals to Vim syntax file.
R=rsc
CC=golang-dev
https://golang.org/cl/224042
Russ Cox [Tue, 16 Mar 2010 03:29:17 +0000 (20:29 -0700)]
runtime: lock finalizer table accesses
R=r
CC=golang-dev
https://golang.org/cl/462043
Andrew Gerrand [Mon, 15 Mar 2010 23:54:02 +0000 (10:54 +1100)]
release.2010-03-15 part two
R=rsc
CC=golang-dev
https://golang.org/cl/581041
Andrew Gerrand [Mon, 15 Mar 2010 23:44:13 +0000 (10:44 +1100)]
release.2010-03-15
R=rsc
CC=golang-dev
https://golang.org/cl/579041
Andrew Gerrand [Mon, 15 Mar 2010 22:42:34 +0000 (09:42 +1100)]
install.html: elaborate on shell profile instructions
R=r, rsc
CC=golang-dev
https://golang.org/cl/556041
Robert Griesemer [Mon, 15 Mar 2010 22:42:09 +0000 (15:42 -0700)]
gofmt: fix for gofmt rewrite feature
Fixes #643.
R=rsc
CC=golang-dev
https://golang.org/cl/576041
Andrew Gerrand [Mon, 15 Mar 2010 22:05:09 +0000 (09:05 +1100)]
dashboard: include package.html
This was omitted from the original commit.
R=rsc
CC=golang-dev
https://golang.org/cl/554043
Robert Griesemer [Sat, 13 Mar 2010 02:16:21 +0000 (18:16 -0800)]
godoc: support for multiple packages in a directory
- smartly select the "right" package
- provide a list of other packages
R=rsc
CC=golang-dev
https://golang.org/cl/466042
Russ Cox [Sat, 13 Mar 2010 01:38:18 +0000 (17:38 -0800)]
hash/crc64: new package implementing 64-bit CRC
hash/crc32: add Update function
hash: add Sum64 interface
R=r
CC=golang-dev
https://golang.org/cl/445042
Robert Griesemer [Fri, 12 Mar 2010 22:54:06 +0000 (14:54 -0800)]
gofmt: make sure there is a newline after
a /*-style comment at the end of a file
Some minor cleanups/typo fixes along the way.
Fixes an issue where that newline was removed
after applying gofmt.
R=r
CC=golang-dev
https://golang.org/cl/476043
Robert Griesemer [Fri, 12 Mar 2010 22:01:52 +0000 (14:01 -0800)]
go/printer: fix a couple of hidden crashes that become
visible only when enabling internal debug mode:
- in rare cases expression depth can underflow
- when printing a single labeled statement, indentation
may underflow if not setup correctly
R=rsc
CC=golang-dev
https://golang.org/cl/484041
Robert Griesemer [Fri, 12 Mar 2010 01:39:55 +0000 (17:39 -0800)]
ast/filter.go: missing nil-check causes crash
R=rsc
CC=golang-dev
https://golang.org/cl/461041
Robert Griesemer [Fri, 12 Mar 2010 00:44:56 +0000 (16:44 -0800)]
godoc: fix formatting of -src output
- go/filter.go: make MergePackageFiles smarter
- go/printer.go: handle positions from multiple files
R=rsc
CC=golang-dev
https://golang.org/cl/460042
Robert Griesemer [Fri, 12 Mar 2010 00:40:32 +0000 (16:40 -0800)]
math, path: minor comment fixes
R=r
CC=golang-dev
https://golang.org/cl/444043
Christopher Wedgwood [Thu, 11 Mar 2010 17:46:16 +0000 (09:46 -0800)]
syslog: increase test timeout from 10ms to 100ms
Problem pointed out by rsc.
R=rsc
CC=golang-dev
https://golang.org/cl/444041
Ian Lance Taylor [Thu, 11 Mar 2010 04:38:38 +0000 (20:38 -0800)]
Revert previous change: complexN only converts to complexN.
This was discussed with Ken and Russ. 6g has been changed,
and both compilers now work this way. This avoids a double
type conversion--first to the float type, then to the complex
type.
R=r
CC=golang-dev, ken2, rsc
https://golang.org/cl/419042
Robert Griesemer [Thu, 11 Mar 2010 01:04:43 +0000 (17:04 -0800)]
math package: minor documentation fix
R=rsc
CC=golang-dev
https://golang.org/cl/424041
Robert Griesemer [Thu, 11 Mar 2010 00:31:09 +0000 (16:31 -0800)]
install.html: add section on C tools
R=rsc
CC=golang-dev
https://golang.org/cl/238042
Robert Griesemer [Wed, 10 Mar 2010 23:41:36 +0000 (15:41 -0800)]
godoc: change -x to -src, update doc.go (missed in previous CL)
R=rsc
CC=golang-dev
https://golang.org/cl/384044
Robert Griesemer [Wed, 10 Mar 2010 23:29:36 +0000 (15:29 -0800)]
go_spec.html: fix typo and link
R=r
CC=golang-dev
https://golang.org/cl/382045
Robert Griesemer [Wed, 10 Mar 2010 23:22:22 +0000 (15:22 -0800)]
godoc: provide mode which shows exported interface in "source form"
- on the commandline: godoc -x big
- in a webpage: provide form parameter ?m=src
Known issues:
- Positioning of comments incorrect in several cases. Separate CL.
- Need a link/menu to switch between different modes of presentation
in the web view.
R=rsc
CC=golang-dev
https://golang.org/cl/376041