]>
Cypherpunks repositories - gostls13.git/log
Dmitriy Vyukov [Mon, 2 Jul 2012 16:55:08 +0000 (20:55 +0400)]
reflect: set GOMAXPROCS=1 in the malloc test
Occasionally I see:
--- FAIL: TestAllocations-15 (0.00 seconds)
all_test.go:1575: 6 mallocs after 100 iterations
Tested:
$ go test -cpu=1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20 reflect
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/
6354063
Dmitriy Vyukov [Mon, 2 Jul 2012 16:10:31 +0000 (20:10 +0400)]
net/http: fix comment
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6348062
Shenghou Ma [Mon, 2 Jul 2012 03:12:42 +0000 (23:12 -0400)]
image: fix doc typo
Fixes #3789.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6357058
Shenghou Ma [Mon, 2 Jul 2012 01:33:22 +0000 (09:33 +0800)]
cmd/gc: add missing case for OCOM in defaultlit()
Fixes #3765.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6349064
Dmitriy Vyukov [Sun, 1 Jul 2012 17:59:50 +0000 (21:59 +0400)]
test: enforce 1 proc in the test
otherwise it fails spuriously with "newfunc allocated unexpectedly" message
when run with GOMAXPROCS>1 (other goroutine allocates).
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
6347056
Dmitriy Vyukov [Sun, 1 Jul 2012 09:10:01 +0000 (13:10 +0400)]
runtime: add freemcache() function
It will be required for scheduler that maintains
GOMAXPROCS MCache's.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6350062
Amir Mohammad Saied [Sat, 30 Jun 2012 19:27:57 +0000 (12:27 -0700)]
cmd/go: httpGet function does not use global variable httpClient
No change, just for consistency.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6346048
Brad Fitzpatrick [Sat, 30 Jun 2012 19:26:06 +0000 (12:26 -0700)]
net/http: ignore malicious or dumb Range requests
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
6356050
Brad Fitzpatrick [Sat, 30 Jun 2012 19:25:38 +0000 (12:25 -0700)]
api: update next.txt
Some accumulated changes from the past few weeks.
Just cleans up all.bash output.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
6354056
Pieter Droogendijk [Sat, 30 Jun 2012 14:27:05 +0000 (00:27 +1000)]
cmd/dist: Make windows.c's fatal() print to stderr
Generating env.bat using dist env -wp > env.bat failed silently
if case of an error, because the message was redirected to env.bat.
Verbose messages still go to stdout, causing problems, but that's
a seperate change.
Made errprintf() identical to xprintf(), except for the output handle.
Yes, it's duplicate code, but most of the function is unpacking
the argument list and preparing it for WriteFile(), which has to be
done anyway.
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/
6343047
Alex Brainman [Sat, 30 Jun 2012 12:08:53 +0000 (22:08 +1000)]
path/filepath: avoid allocation in Clean of cleaned path even on windows (fix build)
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6344049
Shenghou Ma [Sat, 30 Jun 2012 04:40:07 +0000 (12:40 +0800)]
cmd/cgo: generate definitions for GoSlice
Fixes #3741.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6308076
Jean-Marc Eurin [Fri, 29 Jun 2012 16:49:31 +0000 (12:49 -0400)]
misc/emacs: Fix the gofmt patching when the TMPDIR is not the default.
The previous code assumed the gofmt output referred to /tmp but
that's not true if TMPDIR points somewhere else (like on Macs).
Fixes #3782.
R=sameer
CC=golang-dev
https://golang.org/cl/
6346050
Brad Fitzpatrick [Fri, 29 Jun 2012 14:44:04 +0000 (07:44 -0700)]
net/http: support multiple byte ranges in ServeContent
Fixes #3784
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
6351052
Andrey Mirtchovski [Thu, 28 Jun 2012 22:18:35 +0000 (15:18 -0700)]
net/http: Fix a verb-tense mismatch and a typo in documentation.
R=bradfitz
CC=golang-dev
https://golang.org/cl/
6357049
Robert Griesemer [Thu, 28 Jun 2012 19:22:47 +0000 (12:22 -0700)]
go/parser: minor internal cleanups
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6356046
Robert Griesemer [Thu, 28 Jun 2012 19:22:24 +0000 (12:22 -0700)]
go spec: clean up section on selectors
- point out difference between selectors and qualified identifiers
- differentiate between illegal selectors and run-time panics
- use "indirect" as opposed to "dereference" consistently
- add extra links
Fixes #3779.
R=r, rsc, iant, ken
CC=golang-dev
https://golang.org/cl/
6326059
Han-Wen Nienhuys [Thu, 28 Jun 2012 16:46:44 +0000 (09:46 -0700)]
path/filepath: add test case for rooted ".."
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6350047
Joe Poirier [Wed, 27 Jun 2012 23:21:48 +0000 (18:21 -0500)]
syscall: add missing argument type
And update implementation location comment.
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/
6352046
Mathieu Lonjaret [Wed, 27 Jun 2012 21:37:17 +0000 (14:37 -0700)]
image/jpeg: support for reading 4:4:0 subsampling.
Updates #2362.
R=nigeltao
CC=golang-dev
https://golang.org/cl/
6326057
Russ Cox [Wed, 27 Jun 2012 21:32:41 +0000 (17:32 -0400)]
runtime: fix string optimization
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6354048
Russ Cox [Wed, 27 Jun 2012 21:06:49 +0000 (17:06 -0400)]
runtime: avoid allocation for "" + x + ""
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6359043
Russ Cox [Wed, 27 Jun 2012 21:02:39 +0000 (17:02 -0400)]
net: fix build (FreeBSD sendfile)
TBR=bradfitz
CC=golang-dev
https://golang.org/cl/
6358043
Russ Cox [Wed, 27 Jun 2012 20:52:36 +0000 (16:52 -0400)]
path/filepath: avoid allocation in Clean of cleaned path
Alternative to https://golang.org/cl/
6330044 .
Fixes #3681.
R=golang-dev, r, hanwen, iant
CC=golang-dev
https://golang.org/cl/
6335056
Dmitriy Vyukov [Wed, 27 Jun 2012 17:57:49 +0000 (21:57 +0400)]
runtime: add goroutine creation benchmark
Current results on 2 core darwin/amd64:
BenchmarkGoroutineChain 351 ns/op
BenchmarkGoroutineChain-2 3840 ns/op
BenchmarkGoroutineChain-4 4040 ns/op
BenchmarkConcGoroutineChain 350 ns/op
BenchmarkConcGoroutineChain-2 875 ns/op
BenchmarkConcGoroutineChain-4 2027 ns/op
R=r, rsc
CC=golang-dev
https://golang.org/cl/
6332054
Robert Griesemer [Tue, 26 Jun 2012 18:49:19 +0000 (11:49 -0700)]
go spec: clean up use of QualifiedIdent production.
Fixes #3763.
R=r, rsc, iant, ken
CC=golang-dev
https://golang.org/cl/
6333066
Russ Cox [Tue, 26 Jun 2012 00:45:18 +0000 (20:45 -0400)]
syscall: fix build
I missed the API change in the last FreeBSD CL, but the tool caught it.
TBR=bradfitz
CC=golang-dev
https://golang.org/cl/
6331063
Patrick Mylund Nielsen [Tue, 26 Jun 2012 00:41:46 +0000 (20:41 -0400)]
net/http: provide access to POST-only form values
Fixes #3630.
R=rsc
CC=bradfitz, dsymonds, golang-dev, rodrigo.moraes
https://golang.org/cl/
6210067
L Campbell [Tue, 26 Jun 2012 00:26:19 +0000 (20:26 -0400)]
syscall, net: sendfile for FreeBSD
R=golang-dev, rsc, bradfitz, devon.odell
CC=golang-dev
https://golang.org/cl/
6221054
Russ Cox [Tue, 26 Jun 2012 00:25:59 +0000 (20:25 -0400)]
A+C: L Campbell (individual CLA)
Guess I was wrong about being done for the day.
R=golang-dev, r
CC=golang-dev, unpantsu
https://golang.org/cl/
6325060
Rob Pike [Mon, 25 Jun 2012 23:48:20 +0000 (16:48 -0700)]
fmt: set p.field before nil check
Fixes #3752.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6331062
Dave Cheney [Mon, 25 Jun 2012 22:58:00 +0000 (08:58 +1000)]
runtime: add arm soft division and modulo benchmarks
arm soft div and mod performance plays an important part
in runtime performance.
The currently implementation is very stable, but we believe
we can best it. This benchmark provides a reference point.
linux/arm omap4 pandaboard
BenchmarkUint32Div7
10000000 298 ns/op
BenchmarkUint32Div37
10000000 298 ns/op
BenchmarkUint32Div123
10000000 298 ns/op
BenchmarkUint32Div763
10000000 298 ns/op
BenchmarkUint32Div1247
10000000 299 ns/op
BenchmarkUint32Div9305
10000000 298 ns/op
BenchmarkUint32Div13307
10000000 298 ns/op
BenchmarkUint32Div52513
10000000 298 ns/op
BenchmarkUint32Div60978747
10000000 298 ns/op
BenchmarkUint32Div106956295
10000000 297 ns/op
BenchmarkUint32Mod7
10000000 280 ns/op
BenchmarkUint32Mod37
10000000 280 ns/op
BenchmarkUint32Mod123
10000000 280 ns/op
BenchmarkUint32Mod763
10000000 280 ns/op
BenchmarkUint32Mod1247
10000000 280 ns/op
BenchmarkUint32Mod9305
10000000 280 ns/op
BenchmarkUint32Mod13307
10000000 280 ns/op
BenchmarkUint32Mod52513
10000000 280 ns/op
BenchmarkUint32Mod60978747
10000000 280 ns/op
BenchmarkUint32Mod106956295
10000000 280 ns/op
R=minux.ma, rsc
CC=golang-dev
https://golang.org/cl/
6258067
Andrew Gerrand [Mon, 25 Jun 2012 21:54:26 +0000 (14:54 -0700)]
doc: drop video title from homepage
It's just stutter.
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/
6334053
Jonathan Gold [Mon, 25 Jun 2012 21:36:09 +0000 (17:36 -0400)]
encoding/json: add Number type
Number represents the actual JSON text,
preserving the precision and
formatting of the original input.
R=rsc, iant
CC=golang-dev
https://golang.org/cl/
6202068
Russ Cox [Mon, 25 Jun 2012 21:36:02 +0000 (17:36 -0400)]
A+C: Jonathan Gold (individual CLA)
This is my last one for today, I hope!
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6339052
Michael Stapelberg [Mon, 25 Jun 2012 21:32:39 +0000 (17:32 -0400)]
net: fix lookup of AAAA-only hosts without cgo
Fixes #3762.
R=rsc
CC=golang-dev
https://golang.org/cl/
6303106
Russ Cox [Mon, 25 Jun 2012 21:32:31 +0000 (17:32 -0400)]
A+C: add Michael Stapelberg (individual CLA)
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6325058
Pieter Droogendijk [Mon, 25 Jun 2012 21:20:48 +0000 (17:20 -0400)]
go/build: fix doc typo
go/build section "Build Constraints", first paragraph said:
"... they must be appear near the top of the file ..."
fixed to:
"... they must appear near the top of the file ..."
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6329060
Amir Mohammad Saied [Mon, 25 Jun 2012 21:19:08 +0000 (17:19 -0400)]
misc/chrome/gophertool: Support for manifest version 1 is being phased out.
Manifest version 1 was deprecated in Chrome 18, and support will be phased
out according to the schedule available at:
http://code.google.com/chrome/extensions/manifestVersion.html
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6332053
Thomas Alan Copeland [Mon, 25 Jun 2012 21:18:50 +0000 (17:18 -0400)]
encoding/base32, encoding/base64: removed unneeded break label
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6305086
Russ Cox [Mon, 25 Jun 2012 21:18:44 +0000 (17:18 -0400)]
A+C: Amir Mohammad Saied, Thomas Alan Copeland (both individual CLA)
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6330059
Robert Griesemer [Mon, 25 Jun 2012 20:58:28 +0000 (13:58 -0700)]
gofmt: handle comments correctly in rewrites
R=rsc
CC=golang-dev
https://golang.org/cl/
6294076
Micah Stetson [Mon, 25 Jun 2012 20:03:18 +0000 (16:03 -0400)]
encoding/json: simplify (*decodeState).indirect
Removes an incorrect code comment and some superfluous variables.
The comment I removed says that struct fields which implement
Unmarshaler must be pointers, even if they're in an addressable
struct. That's not the case, and there's already a test in decode_test.go
that demonstrates as much.
Encoding/json has quite a few assignments of reflect.Values to extra
variables – things like "iv := v" when there's no need to make a copy. I
think these are left over from a previous version of the reflect API. If they
aren't wanted, I wouldn't mind going through the package and getting
rid of the rest of them.
R=rsc
CC=golang-dev
https://golang.org/cl/
6318047
Jan Ziak [Mon, 25 Jun 2012 20:00:35 +0000 (16:00 -0400)]
encoding/csv, encoding/xml: report write errors
Fixes #3773.
R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/
6327053
Robert Griesemer [Mon, 25 Jun 2012 18:28:24 +0000 (11:28 -0700)]
spec: clarify receive operator
- receiving from a closed channel returns immediately
- in the ,ok form, the 2nd result is of type bool, not
just boolean (gc and ggcgo agree).
Per dsymonds' suggestion.
R=r, rsc, ken, iant, dsymonds
CC=golang-dev
https://golang.org/cl/
6333057
Robert Griesemer [Mon, 25 Jun 2012 18:27:54 +0000 (11:27 -0700)]
go/ast: minor comment maps API change
This is a new, not yet committed API.
- Changed NewCommentMap to be independent of
*File nodes and more symmetric with the
Filter and Comments methods.
- Implemented Update method for use in
AST modifications.
- Implemented String method for debugging
R=rsc
CC=golang-dev
https://golang.org/cl/
6303086
Jan Ziak [Mon, 25 Jun 2012 18:08:09 +0000 (14:08 -0400)]
exp/inotify: prevent data race
Fixes #3713.
R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/
6331055
Brad Fitzpatrick [Mon, 25 Jun 2012 15:54:36 +0000 (08:54 -0700)]
net/http: speed up Header.WriteSubset
A few performance improvements, but without the stack sorting
change to avoid allocating, which is instead waiting on better
escape analysis.
R=rsc
CC=golang-dev
https://golang.org/cl/
6265047
Dave Cheney [Mon, 25 Jun 2012 13:01:34 +0000 (23:01 +1000)]
runtime: remove memset/memclr shim
This CL resolves https://golang.org/cl/
6300043 /#msg3
by renaming memset_arm.s to memclr_arm.s and merging the function
of the same name from asm_arm.s.
R=minux.ma, rsc
CC=golang-dev
https://golang.org/cl/
6336054
Dmitriy Vyukov [Mon, 25 Jun 2012 07:08:09 +0000 (11:08 +0400)]
runtime: fix potential GC deadlock
The issue seems to not be triggered right now,
but I've seen the deadlock after some other legal
modifications to runtime.
So I think we are safer this way.
R=rsc, r
CC=golang-dev
https://golang.org/cl/
6339051
Russ Cox [Sun, 24 Jun 2012 23:47:50 +0000 (19:47 -0400)]
runtime: detect hash map collision problems
This can only happen if the hash function we're using is getting
far more than it's fair share of collisions, but that has happened
to us repeatedly as we've expanded the allowed use cases for
hash tables (issue 1544, issue 2609, issue 2630, issue 2883, issue 3695).
Maybe this will help the next time we try something new.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6306083
Charles L. Dorian [Sun, 24 Jun 2012 23:39:07 +0000 (19:39 -0400)]
math: improve Atan, Asin and Acos accuracy
pkg/math/all_test.go tests Atan (and therefore Asin and Acos) to a
relative accuracy of 4e-16, but the test vector misses values where
the old algorithm was in error by more than that. For example:
x newError oldError
0.
414215746 1.41e-16 -4.24e-16
0.
414216076 1.41e-16 -4.24e-16
0.
414217632 1.41e-16 -4.24e-16
0.
414218770 1.41e-16 -4.24e-16
0.
414225466 0 -5.65e-16
0.
414226244 1.41e-16 -4.24e-16
0.
414228756 0 -5.65e-16
0.
414235089 0 -5.65e-16
0.
414237070 0 -5.65e-16
R=rsc, golang-dev
CC=golang-dev
https://golang.org/cl/
6302093
Han-Wen Nienhuys [Sun, 24 Jun 2012 23:34:06 +0000 (19:34 -0400)]
os: make POSIX StartProcess work with chroot again.
Skip directory check in startProcess in the presence of
SysProcAttr.
Fixes #3649.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6297083
Russ Cox [Sun, 24 Jun 2012 23:32:37 +0000 (19:32 -0400)]
CONTRIBUTORS: add Han-Wen Nienhuys (Google CLA)
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6327054
Jan Ziak [Sun, 24 Jun 2012 23:23:09 +0000 (19:23 -0400)]
test/bench/shootout: remove dependency on C libraries in test mode
Fixes #3732.
R=golang-dev
CC=golang-dev
https://golang.org/cl/
6335053
Jan Ziak [Sun, 24 Jun 2012 23:22:48 +0000 (19:22 -0400)]
exp/inotify: prevent data race during testing
Fixes #3714.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6341047
Dave Cheney [Sun, 24 Jun 2012 22:28:30 +0000 (08:28 +1000)]
runtime: avoid r9/r10 during memmove
Fixes #3718.
Requires CL
6300043 .
R=rsc, minux.ma, extraterrestrial.neighbour
CC=golang-dev
https://golang.org/cl/
6305100
Dave Cheney [Sun, 24 Jun 2012 21:59:50 +0000 (07:59 +1000)]
runtime: avoid r9/r10 during memset
Partially fixes issue 3718.
R=golang-dev, rsc, minux.ma
CC=golang-dev
https://golang.org/cl/
6300043
David Symonds [Sun, 24 Jun 2012 19:23:51 +0000 (12:23 -0700)]
flag: fix indexing doc.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6341046
Brad Fitzpatrick [Sun, 24 Jun 2012 17:41:12 +0000 (10:41 -0700)]
net/http: fix doc inaccuracy and typo; tighten test
Note url.Error wrapping, and s/issue/issuing/.
Fixes #3724
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
6294093
Shenghou Ma [Sat, 23 Jun 2012 17:41:17 +0000 (01:41 +0800)]
runtime: fix struct Sigaction for Linux/386
We need to use kernel headers to generate defs_linux_$GOARCH.h
R=golang-dev, dave, alex.brainman, iant
CC=golang-dev
https://golang.org/cl/
6296091
David G. Andersen [Fri, 22 Jun 2012 22:07:22 +0000 (15:07 -0700)]
net/rpc: fix typo in documentation, clarify semantics of error return
Several of my students were confused by trying to use both the error
return and a reply return, so I figured it was worth explicitly clarifying
that returning an error overrides the reply.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6327051
David G. Andersen [Fri, 22 Jun 2012 21:43:41 +0000 (14:43 -0700)]
encoding/json: fix minor typo in documentation for Marshal
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/
6325053
Andrew Gerrand [Fri, 22 Jun 2012 17:22:01 +0000 (10:22 -0700)]
doc: put A Tour of Go video on the front page
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6337047
Mats Lidell [Thu, 21 Jun 2012 17:01:54 +0000 (13:01 -0400)]
misc/emacs: Replace replace-{string|regexp} for XEmacs compatible code
Use code to be used in lisp programs as suggested in the doc strings for
replace-{string|regexp}. Bonus: This code works for XEmacs.
R=golang-dev, sameer, jmeurin
CC=golang-dev
https://golang.org/cl/
6296073
Adam Langley [Wed, 20 Jun 2012 20:18:56 +0000 (16:18 -0400)]
crypto/x509: add extended key usage support.
Flame motivated me to get around to adding extended key usage support
so that code signing certificates can't be used for TLS server
authentication and vice versa.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6304065
Marcel van Lohuizen [Tue, 19 Jun 2012 18:34:56 +0000 (11:34 -0700)]
exp/locale/collate: added regression test for collate package
based on UCA test files.
R=r
CC=golang-dev
https://golang.org/cl/
6216056
Shenghou Ma [Tue, 19 Jun 2012 17:22:03 +0000 (01:22 +0800)]
doc/articles/slices_usage_and_internals: fix typo
Fixes #3753.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
6304097
Shenghou Ma [Tue, 19 Jun 2012 17:17:03 +0000 (01:17 +0800)]
runtime: fix struct Sigaction for Linux/ARM
if we were to use sizeof(sa.sa_mask) instead of 8 as the last argument
to rt_sigaction, we would have already fixed this bug, so also updated
Linux/386 and Linux/amd64 files to use that; also test the return value
of rt_sigaction.
R=dave, rsc
CC=golang-dev
https://golang.org/cl/
6297087
Brad Fitzpatrick [Tue, 19 Jun 2012 16:20:41 +0000 (09:20 -0700)]
net/http: make client await response concurrently with writing request
If the server replies with an HTTP response before we're done
writing our body (for instance "401 Unauthorized" response), we
were previously ignoring that, since we returned our write
error ("broken pipe", etc) before ever reading the response.
Now we read and write at the same time.
Fixes #3595
R=rsc, adg
CC=golang-dev
https://golang.org/cl/
6238043
Brad Fitzpatrick [Tue, 19 Jun 2012 16:10:14 +0000 (09:10 -0700)]
net/http: clarify client return values in docs
Also, fixes one violation found during testing where both
response and error could be non-nil when a CheckRedirect test
failed. This is arguably a minor API (behavior, not
signature) change, but it wasn't documented either way and was
inconsistent & non-Go like. Any code depending on the old
behavior was wrong anyway.
R=adg, rsc
CC=golang-dev
https://golang.org/cl/
6307088
Robert Griesemer [Tue, 19 Jun 2012 04:56:41 +0000 (21:56 -0700)]
go/ast: multiple "blank" imports are permitted
R=rsc, dsymonds
CC=golang-dev
https://golang.org/cl/
6303099
Marcel van Lohuizen [Tue, 19 Jun 2012 00:43:05 +0000 (17:43 -0700)]
bytes: fixed typo.
R=r
CC=golang-dev
https://golang.org/cl/
6301096
Brad Fitzpatrick [Mon, 18 Jun 2012 19:54:36 +0000 (12:54 -0700)]
net/url: sort keys in Encode; don't enumerate map randomly
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
6303098
Adam Langley [Mon, 18 Jun 2012 15:08:31 +0000 (11:08 -0400)]
A+C: Christine Hansmann (individual CLA)
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/
6312045
Robert Griesemer [Fri, 15 Jun 2012 23:55:15 +0000 (16:55 -0700)]
go/ast: Walk: do not walk comment list
A comment to that effect was introduced
with rev
d332f4b9cef5 but the respective
code wasn't deleted.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/
6304086
Shenghou Ma [Fri, 15 Jun 2012 18:24:44 +0000 (02:24 +0800)]
doc: delete Mercurial Queues doc
Fixes #3716.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/
6310044
Nigel Tao [Fri, 15 Jun 2012 05:39:25 +0000 (15:39 +1000)]
exp/html/atom: add some more atoms.
R=r, dsymonds
CC=golang-dev
https://golang.org/cl/
6298085
Shenghou Ma [Thu, 14 Jun 2012 18:52:18 +0000 (02:52 +0800)]
exp/types: clean up objects after test
Fixes #3739.
R=bradfitz, rsc
CC=golang-dev
https://golang.org/cl/
6295083
Shenghou Ma [Thu, 14 Jun 2012 14:43:15 +0000 (22:43 +0800)]
crypto/elliptic: fix doc typo
Fixes #3735.
R=golang-dev, agl
CC=golang-dev
https://golang.org/cl/
6301083
Andrew Gerrand [Thu, 14 Jun 2012 03:18:10 +0000 (13:18 +1000)]
tag go1.0.2
R=golang-dev, rsc, dsymonds, minux.ma
CC=golang-dev
https://golang.org/cl/
6305089
Andrew Gerrand [Thu, 14 Jun 2012 01:44:00 +0000 (11:44 +1000)]
doc: document go1.0.2
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/
6298079
Nigel Tao [Thu, 14 Jun 2012 00:43:20 +0000 (10:43 +1000)]
cmd/gc: inline convT2E when T is uintptr-shaped.
GOARCH=amd64 benchmarks
src/pkg/runtime
benchmark old ns/op new ns/op delta
BenchmarkConvT2ESmall 10 10 +1.00%
BenchmarkConvT2EUintptr 9 0 -92.07%
BenchmarkConvT2EBig 74 74 -0.27%
BenchmarkConvT2I 27 26 -3.62%
BenchmarkConvI2E 4 4 -7.05%
BenchmarkConvI2I 20 19 -2.99%
test/bench/go1
benchmark old ns/op new ns/op delta
BenchmarkBinaryTree17
5930908000 5937260000 +0.11%
BenchmarkFannkuch11
3927057000 3933556000 +0.17%
BenchmarkGobDecode
21998090 21870620 -0.58%
BenchmarkGobEncode
12725310 12734480 +0.07%
BenchmarkGzip
567617600 567892800 +0.05%
BenchmarkGunzip
178284100 178706900 +0.24%
BenchmarkJSONEncode
87693550 86794300 -1.03%
BenchmarkJSONDecode
314212600 324115000 +3.15%
BenchmarkMandelbrot200
7016640 7073766 +0.81%
BenchmarkParse
7852100 7892085 +0.51%
BenchmarkRevcomp
1285663000 1286147000 +0.04%
BenchmarkTemplate
566823800 567606200 +0.14%
I'm not entirely sure why the JSON* numbers have changed, but
eyeballing the profile suggests that it could be spending less
and more time in runtime.{new,old}stack, so it could simply be
stack-split boundary noise.
R=rsc, dave, bsiegert, dsymonds
CC=golang-dev
https://golang.org/cl/
6280049
Rob Pike [Wed, 13 Jun 2012 22:55:43 +0000 (15:55 -0700)]
encoding/gob: don't cache broken encoding engines.
Fixes a situation where a nested bad type would still
permit the outer type to install a working engine, leading
to inconsistent behavior.
Fixes #3273.
R=bsiegert, rsc
CC=golang-dev
https://golang.org/cl/
6294067
Brad Fitzpatrick [Wed, 13 Jun 2012 21:53:05 +0000 (14:53 -0700)]
net/http: use index.html modtime (not directory) for If-Modified-Since
Thanks to Håvid Falch for finding the problem.
Fixes #3414
R=r, rsc
CC=golang-dev
https://golang.org/cl/
6300081
Rémy Oudompheng [Wed, 13 Jun 2012 21:52:00 +0000 (23:52 +0200)]
strconv: extend fast parsing algorithm to ParseFloat(s, 32)
benchmark old ns/op new ns/op delta
BenchmarkAtof32Decimal 215 73 -65.72%
BenchmarkAtof32Float 233 83 -64.21%
BenchmarkAtof32FloatExp 3351 209 -93.76%
BenchmarkAtof32Random 1939 260 -86.59%
R=rsc
CC=golang-dev, remy
https://golang.org/cl/
6294071
Robert Griesemer [Wed, 13 Jun 2012 20:54:36 +0000 (13:54 -0700)]
math/big: correctly test for positive inputs in Int.GCD
Also: better GCD tests.
R=rsc
CC=golang-dev
https://golang.org/cl/
6295076
Russ Cox [Wed, 13 Jun 2012 20:44:19 +0000 (16:44 -0400)]
syscall: fix windows copyFindData
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6301076
Robert Griesemer [Wed, 13 Jun 2012 20:32:59 +0000 (13:32 -0700)]
godoc: show comments in various filtered views
Fixes #3454.
R=rsc
CC=golang-dev
https://golang.org/cl/
6305069
Robert Griesemer [Wed, 13 Jun 2012 20:32:29 +0000 (13:32 -0700)]
go/ast: comment map implementation
A comment map associates comments with AST nodes
and permits correct updating of the AST's comment
list when the AST is manipulated.
R=rsc
CC=golang-dev
https://golang.org/cl/
6281044
Russ Cox [Wed, 13 Jun 2012 20:24:56 +0000 (16:24 -0400)]
go/build: fix boolean negation
!(linux&cgo | darwin&cgo)
= (!linux|!cgo) & (!darwin|!cgo)
= (!linux&!darwin) | !cgo // new comment
≠ !linux | !darwin | !cgo // old comment
Fixes #3726.
R=golang-dev, bsiegert
CC=golang-dev
https://golang.org/cl/
6306076
Jan Ziak [Wed, 13 Jun 2012 19:52:32 +0000 (15:52 -0400)]
runtime: improved continuity in hash computation
Fixes #3695.
R=r, dave, rsc
CC=golang-dev
https://golang.org/cl/
6304062
Robert Griesemer [Wed, 13 Jun 2012 17:29:06 +0000 (10:29 -0700)]
math/big: fix binaryGCD
R=rsc
CC=golang-dev
https://golang.org/cl/
6297085
Robert Griesemer [Wed, 13 Jun 2012 16:37:47 +0000 (09:37 -0700)]
math/big: various cleanups
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/
6295072
Christopher Swenson [Wed, 13 Jun 2012 16:31:20 +0000 (09:31 -0700)]
math/big: Implemented binary GCD algorithm
benchmark old ns/op new ns/op delta
BenchmarkGCD10x10 4383 2126 -51.49%
BenchmarkGCD10x100 5612 2124 -62.15%
BenchmarkGCD10x1000 8843 2622 -70.35%
BenchmarkGCD10x10000 17025 6576 -61.37%
BenchmarkGCD10x100000 118985 48130 -59.55%
BenchmarkGCD100x100 45328 11683 -74.23%
BenchmarkGCD100x1000 50141 12678 -74.72%
BenchmarkGCD100x10000 110314 26719 -75.78%
BenchmarkGCD100x100000 630000 156041 -75.23%
BenchmarkGCD1000x1000 654809 137973 -78.93%
BenchmarkGCD1000x10000 985683 159951 -83.77%
BenchmarkGCD1000x100000
4920792 366399 -92.55%
BenchmarkGCD10000x10000
16848950 3732062 -77.85%
BenchmarkGCD10000x100000
55401500 4675876 -91.56%
BenchmarkGCD100000x100000
1126775000 258951800 -77.02%
R=gri, rsc, bradfitz, remyoudompheng, mtj
CC=golang-dev
https://golang.org/cl/
6305065
Jean-Marc Eurin [Wed, 13 Jun 2012 14:25:00 +0000 (10:25 -0400)]
misc/emacs: Fix a failure when /tmp/<file>.go exists.
R=sameer
CC=golang-dev
https://golang.org/cl/
6296060
Robert Griesemer [Wed, 13 Jun 2012 01:11:19 +0000 (18:11 -0700)]
CONTRIBUTORS: added Christopher Swenson (Google CLA)
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/
6302069
Andrew Gerrand [Wed, 13 Jun 2012 00:33:02 +0000 (10:33 +1000)]
doc/install: mention GOPATH and point to code.html
Fixes #3469.
R=golang-dev, kevlar, rsc, r
CC=golang-dev
https://golang.org/cl/
6304049
Nigel Tao [Wed, 13 Jun 2012 00:13:05 +0000 (10:13 +1000)]
exp/html: simplify some of the parser's internal methods.
benchmark old ns/op new ns/op delta
BenchmarkParser
4006888 3950604 -1.40%
R=r, andybalholm
CC=golang-dev
https://golang.org/cl/
6301070
Robert Griesemer [Tue, 12 Jun 2012 16:36:35 +0000 (09:36 -0700)]
math/big: optimize common case of Int.Bit(0)
R=golang-dev, dsymonds, rsc
CC=golang-dev
https://golang.org/cl/
6306069