]> Cypherpunks repositories - gostls13.git/log
gostls13.git
11 years ago[release-branch.go1.2] cmd/cgo: use __typeof__, -w instead of typeof, -Wno-all
Andrew Gerrand [Fri, 1 Nov 2013 00:14:19 +0000 (11:14 +1100)]
[release-branch.go1.2] cmd/cgo: use __typeof__, -w instead of typeof, -Wno-all

««« CL 14920052 / 98840b3349f4
cmd/cgo: use __typeof__, -w instead of typeof, -Wno-all

Suggested by iant in earlier CL.

R=golang-dev, bradfitz, iant
CC=golang-dev
https://golang.org/cl/14920052
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20600043

11 years ago[release-branch.go1.2] time: fix ParseDuration overflow when given more than 9 digits...
Andrew Gerrand [Fri, 1 Nov 2013 00:13:30 +0000 (11:13 +1100)]
[release-branch.go1.2] time: fix ParseDuration overflow when given more than 9 digits on 32-bit arch

««« CL 15080043 / fbf3b853e00b
time: fix ParseDuration overflow when given more than 9 digits on 32-bit arch
Fixes #6617.

R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/15080043

»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20050045

11 years ago[release-branch.go1.2] misc/emacs: handle empty "import ()" in go-goto-imports
Andrew Gerrand [Fri, 1 Nov 2013 00:12:28 +0000 (11:12 +1100)]
[release-branch.go1.2] misc/emacs: handle empty "import ()" in go-goto-imports

««« CL 14454058 / 6b8f33ab7ca4
misc/emacs: handle empty "import ()" in go-goto-imports

R=adonovan
CC=golang-dev
https://golang.org/cl/14454058

»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20590043

11 years ago[release-branch.go1.2] math: remove unnecessary source file
Andrew Gerrand [Fri, 1 Nov 2013 00:11:36 +0000 (11:11 +1100)]
[release-branch.go1.2] math: remove unnecessary source file

««« CL 15750046 / 2d1e1adf8ece
math: remove unnecessary source file

The routines in this file are dregs from a very early copy of the math API.
There are no Go prototypes and no non-amd64 implementations.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/15750046
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/19560045

11 years ago[release-branch.go1.2] go/build: document the go1.2 build tag
Andrew Gerrand [Fri, 1 Nov 2013 00:10:46 +0000 (11:10 +1100)]
[release-branch.go1.2] go/build: document the go1.2 build tag

««« CL 14930046 / d4f6533fad0b
go/build: document the go1.2 build tag

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/14930046

»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/19960044

11 years ago[release-branch.go1.2] crypto/x509: name constraints should be a disjunction.
Andrew Gerrand [Fri, 1 Nov 2013 00:09:56 +0000 (11:09 +1100)]
[release-branch.go1.2] crypto/x509: name constraints should be a disjunction.

««« CL 15570044 / b4c37131e846
crypto/x509: name constraints should be a disjunction.

The code was requiring that all constraints be met, but it should be
satisfied by meeting *any* of them.

R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/15570044
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20580043

11 years ago[release-branch.go1.2] crypto/tls: advertise support for RSA+SHA1 in TLS 1.2 handshake.
Andrew Gerrand [Fri, 1 Nov 2013 00:09:06 +0000 (11:09 +1100)]
[release-branch.go1.2] crypto/tls: advertise support for RSA+SHA1 in TLS 1.2 handshake.

««« CL 15650043 / 29d3ab5ced5a
crypto/tls: advertise support for RSA+SHA1 in TLS 1.2 handshake.

Despite SHA256 support being required for TLS 1.2 handshakes, some
servers are aborting handshakes that don't offer SHA1 support.

This change adds support for signing TLS 1.2 ServerKeyExchange messages
with SHA1. It does not add support for signing TLS 1.2 client
certificates with SHA1 as that would require the handshake to be
buffered.

Fixes #6618.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/15650043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20570043

11 years ago[release-branch.go1.2] net/mail: fix minor doc typo.
Andrew Gerrand [Fri, 1 Nov 2013 00:08:05 +0000 (11:08 +1100)]
[release-branch.go1.2] net/mail: fix minor doc typo.

««« CL 15510043 / 6752a7aad603
net/mail: fix minor doc typo.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/15510043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20560043

11 years ago[release-branch.go1.2] cmd/yacc: fix stderr on Windows.
Andrew Gerrand [Fri, 1 Nov 2013 00:07:06 +0000 (11:07 +1100)]
[release-branch.go1.2] cmd/yacc: fix stderr on Windows.

««« CL 15330043 / 69bf31787310
cmd/yacc: fix stderr on Windows.
Fixes #6620.

R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/15330043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20550043

11 years ago[release-branch.go1.2] cmd/cgo: fix line number in an error message
Andrew Gerrand [Fri, 1 Nov 2013 00:06:07 +0000 (11:06 +1100)]
[release-branch.go1.2] cmd/cgo: fix line number in an error message

««« CL 14870046 / b508daf6dae6
cmd/cgo: fix line number in an error message

Fixes #6563.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/14870046
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20150045

11 years ago[release-branch.go1.2] cmd/cgo: stop using compiler error message text to analyze...
Andrew Gerrand [Fri, 1 Nov 2013 00:05:17 +0000 (11:05 +1100)]
[release-branch.go1.2] cmd/cgo: stop using compiler error message text to analyze C names

««« CL 15070043 / 90a628ac54ed
cmd/cgo: stop using compiler error message text to analyze C names

The old approach to determining whether "name" was a type, constant,
or expression was to compile the C program

        name;

and scan the errors and warnings generated by the compiler.
This requires looking for specific substrings in the errors and warnings,
which ties the implementation to specific compiler versions.
As compilers change their errors or drop warnings, cgo breaks.
This happens slowly but it does happen.
Clang in particular (now required on OS X) has a significant churn rate.

The new approach compiles a slightly more complex program
that is either valid C or not valid C depending on what kind of
thing "name" is. It uses only the presence or absence of an error
message on a particular line, not the error text itself. The program is:

        // error if and only if name is undeclared
        void f1(void) { typeof(name) *x; }

        // error if and only if name is not a type
        void f2(void) { name *x; }

        // error if and only if name is not an integer constant
        void f3(void) { enum { x = (name)*1 }; }

I had not been planning to do this until Go 1.3, because it is a
non-trivial change, but it fixes a real Xcode 5 problem in Go 1.2,
and the new code is easier to understand than the old code.
It should be significantly more robust.

Fixes #6596.
Fixes #6612.

R=golang-dev, r, james, iant
CC=golang-dev
https://golang.org/cl/15070043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20060044

11 years ago[release-branch.go1.2] cmd/gc: shorten name used for map bucket type
Andrew Gerrand [Fri, 1 Nov 2013 00:00:12 +0000 (11:00 +1100)]
[release-branch.go1.2] cmd/gc: shorten name used for map bucket type

««« CL 15110044 / 95336afd420c
cmd/gc: shorten name used for map bucket type

Before:
type.struct { buckets *struct { overflow *struct { overflow *struct { overflow *struct { overflow *struct { overflow *<...>; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; oldbuckets *struct { overflow *struct { overflow *struct { overflow *struct { overflow *struct { overflow *<...>; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable }; keys [8]string; values [8]*"".RangeTable } }

After:
type.map.bucket[string]*"".RangeTable

This makes debugging maps a little nicer, and it takes up less space in the binary.

R=golang-dev, r
CC=golang-dev, khr
https://golang.org/cl/15110044
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20050044

11 years ago[release-branch.go1.2] net: make sure failed Dial returns nil Conn
Andrew Gerrand [Thu, 31 Oct 2013 23:58:25 +0000 (10:58 +1100)]
[release-branch.go1.2] net: make sure failed Dial returns nil Conn

««« CL 14950045 / 1e60ffd5933d
net: make sure failed Dial returns nil Conn

Fixes #6614.

R=golang-dev, bradfitz, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/14950045
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/20170047

11 years ago[release-branch.go1.2] runtime: remove nomemprof
Andrew Gerrand [Thu, 31 Oct 2013 23:51:42 +0000 (10:51 +1100)]
[release-branch.go1.2] runtime: remove nomemprof

««« CL 14695044 / 35d5bae6aac8
runtime: remove nomemprof
Nomemprof seems to be unneeded now, there is no recursion.
If the recursion will be re-introduced, it will break loudly by deadlocking.
Fixes #6566.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/14695044
»»»

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/20540043

11 years ago[release-branch.go1.2] misc/dist: build race packages when os suffix present
Andrew Gerrand [Thu, 31 Oct 2013 23:50:00 +0000 (10:50 +1100)]
[release-branch.go1.2] misc/dist: build race packages when os suffix present

««« CL 14930043 / 5746e3a5443b
misc/dist: build race packages when os suffix present

The "darwin-amd64-osx10.8" target was not matching "darwin-amd64".

R=golang-dev
CC=golang-dev
https://golang.org/cl/14930043
»»»

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/20290045

11 years agogo1.2rc2 go1.2rc2
Andrew Gerrand [Fri, 18 Oct 2013 04:53:33 +0000 (13:53 +0900)]
go1.2rc2

11 years agoapi: add go1.2.txt, use in tests
Andrew Gerrand [Fri, 18 Oct 2013 04:36:59 +0000 (13:36 +0900)]
api: add go1.2.txt, use in tests

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/14860043

11 years agomisc/dist: set default go.tools tag
Andrew Gerrand [Fri, 18 Oct 2013 01:51:21 +0000 (10:51 +0900)]
misc/dist: set default go.tools tag

Fixes #6607.

R=dsymonds
CC=golang-dev
https://golang.org/cl/14830043

11 years agonet/url: fix regression when serializing relative URLs
Brad Fitzpatrick [Thu, 17 Oct 2013 23:06:40 +0000 (16:06 -0700)]
net/url: fix regression when serializing relative URLs

Only add a slash to path if it's a separator between
a host and path.

Fixes #6609

R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/14815043

11 years agoruntime: correct test for when to poll network
Ian Lance Taylor [Thu, 17 Oct 2013 18:57:48 +0000 (11:57 -0700)]
runtime: correct test for when to poll network

Fixes #6610.

R=golang-dev, khr
CC=golang-dev
https://golang.org/cl/14793043

11 years agoruntime: correct parameter name in MCentral_AllocList comment
Ian Lance Taylor [Thu, 17 Oct 2013 18:57:00 +0000 (11:57 -0700)]
runtime: correct parameter name in MCentral_AllocList comment

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/14792043

11 years agoencoding/xml: accept chains of interfaces and pointers
Russ Cox [Thu, 17 Oct 2013 16:13:33 +0000 (12:13 -0400)]
encoding/xml: accept chains of interfaces and pointers

Fixes #6556.

R=golang-dev, iant, adg
CC=golang-dev
https://golang.org/cl/14747043

11 years agodatabase/sql: make tests repeatable with -cpu=n,n
Alberto García Hierro [Thu, 17 Oct 2013 16:02:32 +0000 (09:02 -0700)]
database/sql: make tests repeatable with -cpu=n,n

New test added in CL 14611045 causes a deadlock when
running the tests with -cpu=n,n because the fakedb
driver always waits when opening a new connection after
running TestConnectionLeak.  Reset its state after.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/14780043

11 years agoA+C: add Jamie Turner (Dropbox corporate CLA).
David Symonds [Thu, 17 Oct 2013 00:48:27 +0000 (11:48 +1100)]
A+C: add Jamie Turner (Dropbox corporate CLA).

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/14765043

11 years agodatabase/sql: fix some test fmt verbs
Brad Fitzpatrick [Wed, 16 Oct 2013 23:30:39 +0000 (16:30 -0700)]
database/sql: fix some test fmt verbs

Found by vet.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14762044

11 years agospec: clarify re-use of underlying arrays in slice operations
Robert Griesemer [Wed, 16 Oct 2013 23:16:54 +0000 (16:16 -0700)]
spec: clarify re-use of underlying arrays in slice operations

Please note the slight rewording for append: The spec now
requires that append reuses the underlying array if it is
sufficiently large. Per majority sentiment.

This is technically a language change but the current
implementation always worked this way.

Fixes #5818.
Fixes #5180.

R=rsc, iant, r, ken, minux.ma, dan.kortschak, rogpeppe, go.peter.90
CC=golang-dev
https://golang.org/cl/14419054

11 years agodatabase/sql: Fix connection leak and potential deadlock
Alberto García Hierro [Wed, 16 Oct 2013 16:22:57 +0000 (09:22 -0700)]
database/sql: Fix connection leak and potential deadlock

CL 10726044 introduced a race condition which causes connections
to be leaked under certain circumstances. If SetMaxOpenConns is
used, the application eventually deadlocks. Otherwise, the number
of open connections just keep growing indefinitely.

Fixes #6593

R=golang-dev, bradfitz, tad.glines, bketelsen
CC=golang-dev
https://golang.org/cl/14611045

11 years agodatabase/sql: fix double decrement of numOpen count; test for connection leaks
Alberto García Hierro [Wed, 16 Oct 2013 16:17:25 +0000 (09:17 -0700)]
database/sql: fix double decrement of numOpen count; test for connection leaks

Add a check at the end of every test to make sure
there are no leaked connections after running a test.

Avoid incorrectly decrementing the number of open connections
when the driver connection ends up it a bad state (numOpen was
decremented twice).

Prevent leaking a Rows struct (which ends up leaking a
connection) in Row.Scan() when a *RawBytes destination is
improperly used.

Close the Rows struct in TestRowsColumns.

Update #6593

R=golang-dev, bradfitz, dave
CC=golang-dev
https://golang.org/cl/14642044

11 years agocmd/cgo: simpler fix for issue 6506.
Shenghou Ma [Wed, 16 Oct 2013 01:35:52 +0000 (21:35 -0400)]
cmd/cgo: simpler fix for issue 6506.
Replaces CL 14682044.
Fixes #6506.

R=rsc, iant, dave
CC=golang-dev
https://golang.org/cl/14717043

11 years agodoc/effective_go.html: fix code example
Shenghou Ma [Wed, 16 Oct 2013 01:30:49 +0000 (21:30 -0400)]
doc/effective_go.html: fix code example
Fixes #6595.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/14425062

11 years agocmd/cgo: print the builtin prolog after the per-file preamble
Russ Cox [Tue, 15 Oct 2013 19:00:48 +0000 (15:00 -0400)]
cmd/cgo: print the builtin prolog after the per-file preamble

The preamble may want to #define some special symbols
and then #include <sys/types.h> itself. The builtin prolog
also #includes <sys/types.h>, which would break such a
preamble (because the second #include will be a no-op).

The use of sys/types.h in the builtin prolog is new since Go 1.1,
so this should preserve the semantics of more existing cgo
code than we would otherwise.

It also fixes src/pkg/syscall/mkall.sh's use of go tool cgo -godefs
on some Linux systems.

Thanks to fullung@ for identifying the problem.

Fixes #6558.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/14684044

11 years agoundo CL 14231047 / 2f4c2dde2756
Alex Brainman [Tue, 15 Oct 2013 18:37:43 +0000 (14:37 -0400)]
undo CL 14231047 / 2f4c2dde2756

undone because the change slows down profile collection
significantly and unpredictable at times (see comments
at https://golang.org/cl/14231047 for details)

««« original CL description
runtime: collect profiles even while on g0 stack

Fixes #6417

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/14231047
»»»

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/14535046

11 years agocmd/cgo: fix Xcode 5 incompatibility for #defined expressions
Russ Cox [Tue, 15 Oct 2013 18:34:46 +0000 (14:34 -0400)]
cmd/cgo: fix Xcode 5 incompatibility for #defined expressions

Ensure that clang always exits with a non-zero status by
giving it something that it always warns about (the statement "1;").

Fixes #6128.

R=golang-dev, iant, minux.ma
CC=golang-dev
https://golang.org/cl/14702043

11 years agomisc/cgo/test: cut out non-standard functions
Russ Cox [Tue, 15 Oct 2013 18:25:29 +0000 (14:25 -0400)]
misc/cgo/test: cut out non-standard functions

Otherwise the link fails. Fixes build.

TBR=golang-dev
CC=golang-dev
https://golang.org/cl/14483050

11 years agomisc/cgo/test: fix build (define prototype for alloca)
Russ Cox [Tue, 15 Oct 2013 17:46:57 +0000 (13:46 -0400)]
misc/cgo/test: fix build (define prototype for alloca)

TBR=golang-dev
CC=golang-dev
https://golang.org/cl/14454063

11 years agocmd/cgo: work around bug in clang debug info for builtins like memset
Russ Cox [Tue, 15 Oct 2013 16:46:14 +0000 (12:46 -0400)]
cmd/cgo: work around bug in clang debug info for builtins like memset

Fixes #6506.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14682044

11 years agodoc/contrib.html: fix some tags
Oling Cat [Tue, 15 Oct 2013 07:41:23 +0000 (18:41 +1100)]
doc/contrib.html: fix some tags

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/14516057

11 years agoruntime/pprof: disable flaky TestGoroutineSwitch on windows
Alex Brainman [Tue, 15 Oct 2013 02:00:06 +0000 (13:00 +1100)]
runtime/pprof: disable flaky TestGoroutineSwitch on windows

Update #6417

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/14604043

11 years agocmd/gc: fix comment about performing indexing at compile time.
Keith Randall [Mon, 14 Oct 2013 21:26:52 +0000 (14:26 -0700)]
cmd/gc: fix comment about performing indexing at compile time.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14441070

11 years agonet/http: skip content-type sniffing if the header is explicitly unset.
Michael Piatek [Mon, 14 Oct 2013 21:22:04 +0000 (08:22 +1100)]
net/http: skip content-type sniffing if the header is explicitly unset.

Fixes #5953

R=dsymonds, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/14434044

11 years agoC: add Michael Piatek (Google CLA).
David Symonds [Mon, 14 Oct 2013 21:21:30 +0000 (08:21 +1100)]
C: add Michael Piatek (Google CLA).

R=golang-dev, r
CC=golang-dev, piatek
https://golang.org/cl/14681043

11 years agodebug/dwarf: report the value of an unrecognized attribute format
Ian Lance Taylor [Mon, 14 Oct 2013 17:53:55 +0000 (10:53 -0700)]
debug/dwarf: report the value of an unrecognized attribute format

R=golang-dev, r, minux.ma
CC=golang-dev
https://golang.org/cl/14669045

11 years agocmd/api: make it work even when cgo is disabled
Shenghou Ma [Mon, 14 Oct 2013 04:18:46 +0000 (00:18 -0400)]
cmd/api: make it work even when cgo is disabled
make use of $USER or %USERNAME% to determine the current user.
Fixes #6578.

R=golang-dev, bradfitz, alex.brainman
CC=golang-dev
https://golang.org/cl/14649043

11 years agodoc: fix small HTML problems
Shenghou Ma [Sat, 12 Oct 2013 22:40:41 +0000 (18:40 -0400)]
doc: fix small HTML problems

R=golang-dev, dave
CC=golang-dev
https://golang.org/cl/14629043

11 years agodoc/effective_go.html: fix unescaped less-than character
Rob Pike [Fri, 11 Oct 2013 23:39:40 +0000 (16:39 -0700)]
doc/effective_go.html: fix unescaped less-than character
Why doesn't tidy complain about these?
Found by manlio.perillo.
Fixes #6571

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/14608044

11 years agogo/build: add GOOS and GOARCH to name of gccgo pkg directory
Ian Lance Taylor [Fri, 11 Oct 2013 23:17:45 +0000 (16:17 -0700)]
go/build: add GOOS and GOARCH to name of gccgo pkg directory

This matches the behaviour of builder.includeArgs in
cmd/go/build.go.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/14535048

11 years agogo/build: fix test if built with CGO_ENABLED=0
Ian Lance Taylor [Fri, 11 Oct 2013 22:55:50 +0000 (15:55 -0700)]
go/build: fix test if built with CGO_ENABLED=0

Fixes #6567.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/14502060

11 years agomisc/cgo/test: fix C panic test to work with gccgo
Ian Lance Taylor [Fri, 11 Oct 2013 18:24:54 +0000 (11:24 -0700)]
misc/cgo/test: fix C panic test to work with gccgo

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/14611043

11 years agodoc/progs: don't try building cgo tests if CGO_ENABLED=0
Ian Lance Taylor [Fri, 11 Oct 2013 15:55:13 +0000 (08:55 -0700)]
doc/progs: don't try building cgo tests if CGO_ENABLED=0

R=golang-dev, jsing, r
CC=golang-dev
https://golang.org/cl/14523056

11 years agocmd/gc: re-word some error messages
Shenghou Ma [Fri, 11 Oct 2013 02:43:34 +0000 (22:43 -0400)]
cmd/gc: re-word some error messages
Fixes #6557.

R=golang-dev, rsc, tracey.brendan
CC=golang-dev
https://golang.org/cl/14432053

11 years agogo.tools/misc/dist: copy doc.go from go.tools to go root
Andrew Gerrand [Fri, 11 Oct 2013 01:37:32 +0000 (10:37 +0900)]
go.tools/misc/dist: copy doc.go from go.tools to go root

This will allow "godoc godoc", "godoc vet", "godoc cover" to work.

Fixes #6527.

R=r, dsymonds
CC=golang-dev
https://golang.org/cl/14566049

11 years agomisc/vim: complete packages in src directory
Yasuhiro Matsumoto [Fri, 11 Oct 2013 00:30:03 +0000 (11:30 +1100)]
misc/vim: complete packages in src directory

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/14454059

11 years agodoc/effective_go.html: fix a couple of cosmetic issues
Rob Pike [Fri, 11 Oct 2013 00:26:03 +0000 (17:26 -0700)]
doc/effective_go.html: fix a couple of cosmetic issues
At the moment, godoc expands the example in the link, but in
the past it has not. Add a waffle word to allow either possibility.
Also change the order of cases in the switch in Compare to
be consistent with the other switch in the function.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/14439055

11 years agolib/codereview: return an empty list when CONTRIBUTORS is not found instead of None.
Francesc Campoy [Fri, 11 Oct 2013 00:16:17 +0000 (17:16 -0700)]
lib/codereview: return an empty list when CONTRIBUTORS is not found instead of None.

R=adg, campoy, r
CC=golang-dev
https://golang.org/cl/14419059

11 years agocodereview: fix hg sync closing of CLs for subrepositories
Dominik Honnef [Thu, 10 Oct 2013 23:30:47 +0000 (16:30 -0700)]
codereview: fix hg sync closing of CLs for subrepositories

The regexp for closing CLs that were sent by you but committed by
someone else only matched messages for the main repository,
because of the added &repo=... for subrepositories.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14512045

11 years agomisc/emacs: send correct content-length to the playground
Dominik Honnef [Thu, 10 Oct 2013 20:49:19 +0000 (16:49 -0400)]
misc/emacs: send correct content-length to the playground

R=adonovan
CC=golang-dev
https://golang.org/cl/14548049

11 years agomisc/emacs: don't treat (foo)(bar) as a function call when preceded by a word character.
Dominik Honnef [Thu, 10 Oct 2013 20:30:20 +0000 (16:30 -0400)]
misc/emacs: don't treat (foo)(bar) as a function call when preceded by a word character.

Fixes #6531.

R=adonovan
CC=golang-dev
https://golang.org/cl/14523043

11 years agonet: fix TestDialFailPDLeak to work when GOMAXPROCS is large
Ian Lance Taylor [Wed, 9 Oct 2013 20:52:29 +0000 (13:52 -0700)]
net: fix TestDialFailPDLeak to work when GOMAXPROCS is large

Fixes #6553.

R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/14526048

11 years agoruntime: markfreed's error reports should be prefixed with "markfreed", not "markallo...
Keith Randall [Wed, 9 Oct 2013 20:28:47 +0000 (13:28 -0700)]
runtime: markfreed's error reports should be prefixed with "markfreed", not "markallocated".

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/14441055

11 years agocmd/go: add any .c/.cc files to the SWIG shared library
Ian Lance Taylor [Wed, 9 Oct 2013 17:35:46 +0000 (10:35 -0700)]
cmd/go: add any .c/.cc files to the SWIG shared library

Also add the action's object directory to the list of
directories we use to find SWIG shared libraries.

Fixes #6521.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/14369043

11 years agoruntime/cgo: mark callback functions as NOSPLIT
Ian Lance Taylor [Wed, 9 Oct 2013 15:44:47 +0000 (08:44 -0700)]
runtime/cgo: mark callback functions as NOSPLIT

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/14448044

11 years agodebug/dwarf: handle surprising clang encoding
Russ Cox [Wed, 9 Oct 2013 15:08:22 +0000 (11:08 -0400)]
debug/dwarf: handle surprising clang encoding

Fixes a bug in cgo on OS X using clang.
See golang.org/issue/6472 for details.

Fixes #6472.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/14575043

11 years agonet: fix typo in failure message in test
Ian Lance Taylor [Wed, 9 Oct 2013 13:44:11 +0000 (06:44 -0700)]
net: fix typo in failure message in test

R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/14582043

11 years agocompress/flate: fix infinite loop on malformed data
Russ Cox [Wed, 9 Oct 2013 12:37:06 +0000 (08:37 -0400)]
compress/flate: fix infinite loop on malformed data

Test using compress/gzip, because that's how the
data arrived.

Fixes #6550.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14441051

11 years agolib/time: update time zone files to version 2013g
Rob Pike [Tue, 8 Oct 2013 23:16:24 +0000 (16:16 -0700)]
lib/time: update time zone files to version 2013g
This dataset is current as of Sep 30, 2013.

Fixes #6524

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/14570044

11 years agoencoding/gob: add examples
Rob Pike [Tue, 8 Oct 2013 20:13:40 +0000 (13:13 -0700)]
encoding/gob: add examples
Also tweak the package document, putting in section headings and
adding a sentence about intended use.

Fixes #4925.

R=golang-dev, iant, adg, ugorji
CC=golang-dev
https://golang.org/cl/14519044

11 years agodoc: fix a few broken links
Andrew Gerrand [Tue, 8 Oct 2013 20:05:43 +0000 (07:05 +1100)]
doc: fix a few broken links

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14494044

11 years agotest: revert changes made for Go SSA interpreter test.
Alan Donovan [Tue, 8 Oct 2013 18:36:20 +0000 (14:36 -0400)]
test: revert changes made for Go SSA interpreter test.

R=r, gri
CC=golang-dev
https://golang.org/cl/14552044

11 years agocmd/go, runtime: express armv5t architecture constraint differently
Carl Shapiro [Tue, 8 Oct 2013 17:40:51 +0000 (10:40 -0700)]
cmd/go, runtime: express armv5t architecture constraint differently

Instead of adding an -march=armv5t flag to the gcc command
line, the same effect is obtained with an ".arch armv5t"
pseudo op in the assembly file that uses armv5t instructions.

R=golang-dev, iant, dave
CC=golang-dev
https://golang.org/cl/14511044

11 years agoA+C: Tw (individual CLA)
Andrew Gerrand [Tue, 8 Oct 2013 05:53:56 +0000 (16:53 +1100)]
A+C: Tw (individual CLA)

Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/14502047

11 years agodoc/articles/wiki: fix path handling and clean up test process
Andrew Gerrand [Tue, 8 Oct 2013 00:14:35 +0000 (11:14 +1100)]
doc/articles/wiki: fix path handling and clean up test process

Fixes #6525.

R=r
CC=golang-dev
https://golang.org/cl/14383043

11 years agomath: the trig functions work in radians; document that
Rob Pike [Mon, 7 Oct 2013 23:32:47 +0000 (16:32 -0700)]
math: the trig functions work in radians; document that
Fixes #6543
6543 is also a fine NGC object.

R=golang-dev, dsymonds, kamil.kisiel, minux.ma
CC=golang-dev
https://golang.org/cl/14515044

11 years agospec: unsafe.Pointers are pointers
Robert Griesemer [Mon, 7 Oct 2013 17:43:28 +0000 (10:43 -0700)]
spec: unsafe.Pointers are pointers

But they cannot be dereferenced.
See also issue 6116.

Fixes #6358.

R=r, rsc, iant, ken
CC=golang-dev
https://golang.org/cl/14374046

11 years agomisc/emacs: find unused imports where path and package name differ
Dominik Honnef [Mon, 7 Oct 2013 17:08:26 +0000 (13:08 -0400)]
misc/emacs: find unused imports where path and package name differ

The Go compiler emits extra information for this case:

imported and not used: "sandbox/foo_bar" as bar

R=adonovan
CC=golang-dev
https://golang.org/cl/14111043

11 years agoos/user: fix user lookups on dragonfly
Joel Sing [Mon, 7 Oct 2013 16:21:33 +0000 (09:21 -0700)]
os/user: fix user lookups on dragonfly

Like FreeBSD, DragonFly does not provide a sysconf value for
_SC_GETPW_R_SIZE_MAX.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/14469043

11 years agoos/user: enable tests on all supported platforms
Joel Sing [Mon, 7 Oct 2013 16:12:17 +0000 (09:12 -0700)]
os/user: enable tests on all supported platforms

All of the currently supported platforms have a working user
implementation and do not use stubs. As a result, enable the tests
on all platforms rather than whitelisting.

R=golang-dev, dave, iant
CC=golang-dev
https://golang.org/cl/14454044

11 years agoos/signal: make test logs reflect reality
Joel Sing [Mon, 7 Oct 2013 16:04:20 +0000 (09:04 -0700)]
os/signal: make test logs reflect reality

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/14470043

11 years agocodereview: move dotfiles out of user home director to something sane.
Jeff Sickel [Mon, 7 Oct 2013 15:41:27 +0000 (11:41 -0400)]
codereview: move dotfiles out of user home director to something sane.

See Rob Pike's lesson on shortcuts, https://plus.google.com/101960720994009339267/posts/R58WgWwN9jp

R=golang-dev, r, rsc
CC=aram.h, golang-dev
https://golang.org/cl/14374045

11 years agoA+C: Jeff Sickel (individual CLA)
Russ Cox [Mon, 7 Oct 2013 15:40:59 +0000 (11:40 -0400)]
A+C: Jeff Sickel (individual CLA)

Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/14467045

11 years agoA+C: add Marko Juhani Silokunnas (individual CLA).
David Symonds [Sat, 5 Oct 2013 04:15:02 +0000 (14:15 +1000)]
A+C: add Marko Juhani Silokunnas (individual CLA).

R=golang-dev, adg
CC=golang-dev, mikioh.mikioh
https://golang.org/cl/14417043

11 years agoruntime: fix bug in maps at the intersection of iterators, growing, and NaN keys
Keith Randall [Fri, 4 Oct 2013 20:54:03 +0000 (13:54 -0700)]
runtime: fix bug in maps at the intersection of iterators, growing, and NaN keys

If an iterator is started while a map is in the middle of a grow,
and the map has NaN keys, then those keys might get returned by
the iterator more than once.  This fix makes the evacuation decision
deterministic and repeatable for NaN keys so each one gets returned
only once.

R=golang-dev, r, khr, iant
CC=golang-dev
https://golang.org/cl/14367043

11 years agoruntime: remove 3 unused declarations.
Keith Randall [Fri, 4 Oct 2013 20:22:20 +0000 (13:22 -0700)]
runtime: remove 3 unused declarations.

R=golang-dev, cshapiro, iant
CC=golang-dev
https://golang.org/cl/14405043

11 years agoreflect: test using a MakeFunc value in a couple of different ways
Ian Lance Taylor [Fri, 4 Oct 2013 20:12:50 +0000 (13:12 -0700)]
reflect: test using a MakeFunc value in a couple of different ways

The gccgo implementation mishandled calling Interface on a
value created by MakeFunc.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14401043

11 years agodoc/go1.2.html: update a minor change to syscall
Mikio Hara [Fri, 4 Oct 2013 04:13:56 +0000 (13:13 +0900)]
doc/go1.2.html: update a minor change to syscall

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14379043

11 years agoruntime: collect profiles even while on g0 stack
Alex Brainman [Fri, 4 Oct 2013 03:53:34 +0000 (13:53 +1000)]
runtime: collect profiles even while on g0 stack

Fixes #6417

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/14231047

11 years agoA+C: Matt Reiferson (individual CLA)
Andrew Gerrand [Fri, 4 Oct 2013 01:46:32 +0000 (11:46 +1000)]
A+C: Matt Reiferson (individual CLA)

Generated by addca.

R=gobot
CC=golang-dev
https://golang.org/cl/14375043

11 years agodoc: move spec and memory model back to /ref/
Andrew Gerrand [Thu, 3 Oct 2013 23:45:06 +0000 (09:45 +1000)]
doc: move spec and memory model back to /ref/

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14364043

11 years agospec: added additional links, added missing 'label'
Robert Griesemer [Thu, 3 Oct 2013 23:38:22 +0000 (16:38 -0700)]
spec: added additional links, added missing 'label'

No semantic spec changes.

R=r
CC=golang-dev
https://golang.org/cl/14363043

11 years agoreflect: add a test that gccgo mishandled
Ian Lance Taylor [Thu, 3 Oct 2013 20:23:02 +0000 (13:23 -0700)]
reflect: add a test that gccgo mishandled

Failure occurred when using reflect.Call to pass a func value
following a non-pointer value.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14186043

11 years agospec: fix small typo in comment for example
Robert Hencke [Thu, 3 Oct 2013 19:46:02 +0000 (12:46 -0700)]
spec: fix small typo in comment for example

R=golang-dev, mirtchovski, r
CC=golang-dev
https://golang.org/cl/14227043

11 years agogofmt: explain why lower bounds aren't automatically simplified
Robert Hencke [Thu, 3 Oct 2013 17:55:17 +0000 (10:55 -0700)]
gofmt: explain why lower bounds aren't automatically simplified

Full credit goes to gri and rsc for their explanations.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14229043

11 years agodoc: remove link to PackageVersioning wiki
Russ Cox [Thu, 3 Oct 2013 17:53:16 +0000 (13:53 -0400)]
doc: remove link to PackageVersioning wiki

That page may be fine for experienced Go programmers
but it's not really targeting new programmers.
There's too much we don't know yet.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/14345043

11 years agosync/atomic: explain how to subtract an unsigned constant
Rob Pike [Thu, 3 Oct 2013 17:40:42 +0000 (10:40 -0700)]
sync/atomic: explain how to subtract an unsigned constant
Explain for those unfamiliar with twos-complement arithmetic how to
implement negation of signed positive constant.
Fixes #6408.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/14267044

11 years agogo/doc: update ToHTML doc comment
Russ Cox [Thu, 3 Oct 2013 13:49:12 +0000 (09:49 -0400)]
go/doc: update ToHTML doc comment

Update #5429

R=golang-dev, r, dan.kortschak
CC=golang-dev
https://golang.org/cl/14293043

11 years agoruntime: change default stack segment size to 8 kB
Russ Cox [Thu, 3 Oct 2013 13:19:10 +0000 (09:19 -0400)]
runtime: change default stack segment size to 8 kB

Changing from 4 kB to 8 kB brings significant improvement
on a variety of the Go 1 benchmarks, on both amd64
and 386 systems.

Significant runtime reductions:

          amd64  386
GoParse    -14%  -1%
GobDecode  -12% -20%
GobEncode  -64%  -1%
JSONDecode  -9%  -4%
JSONEncode -15%  -5%
Template   -17% -14%

In the longer term, khr's new stacks will avoid needing to
make this decision at all, but for Go 1.2 this is a reasonable
stopgap that makes performance significantly better.

Demand paging should mean that if the second 4 kB is not
used, it will not be brought into memory, so the change
should not adversely affect resident set size.
The same argument could justify bumping as high as 64 kB
on 64-bit machines, but there are diminishing returns
after 8 kB, and using 8 kB limits the possible unintended
memory overheads we are not aware of.

Benchmark graphs at
http://swtch.com/~rsc/gostackamd64.html
http://swtch.com/~rsc/gostack386.html

Full data at
http://swtch.com/~rsc/gostack.zip

R=golang-dev, khr, dave, bradfitz, dvyukov
CC=golang-dev
https://golang.org/cl/14317043

11 years agodoc/faq: add a FAQ about versioning
Russ Cox [Thu, 3 Oct 2013 13:18:47 +0000 (09:18 -0400)]
doc/faq: add a FAQ about versioning

Fixes #5633.

R=golang-dev, r, tommi.virtanen, adg, nj
CC=golang-dev
https://golang.org/cl/14283044

11 years agocmd/gc: support -installsuffix in the compiler and builder
Dave Day [Thu, 3 Oct 2013 03:48:47 +0000 (13:48 +1000)]
cmd/gc: support -installsuffix in the compiler and builder

Add the -installsuffix flag to gc and {5,6,8}l, which overrides -race
for the suffix if both are supplied.
Pass this flag from the go tool for build and install.

R=rsc
CC=golang-dev
https://golang.org/cl/14246044

11 years agomisc/vim: Autocompletion for :Godoc command
Yasuhiro Matsumoto [Thu, 3 Oct 2013 03:32:07 +0000 (13:32 +1000)]
misc/vim: Autocompletion for :Godoc command

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/14259043

11 years agonet: use original argument in lookup error
Russ Cox [Thu, 3 Oct 2013 02:09:54 +0000 (22:09 -0400)]
net: use original argument in lookup error

Fixes #6324.

R=golang-dev, iant, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/13280049

11 years agocmd/go: document relative imports
Russ Cox [Thu, 3 Oct 2013 01:42:23 +0000 (21:42 -0400)]
cmd/go: document relative imports

Fixes #3524.

R=golang-dev, iant, r
CC=golang-dev
https://golang.org/cl/14296043