]> Cypherpunks repositories - gostls13.git/log
gostls13.git
14 years agowindows: fix netchan test by using 127.0.0.1.
Rob Pike [Sat, 18 Sep 2010 01:43:10 +0000 (11:43 +1000)]
windows: fix netchan test by using 127.0.0.1.
Re-enable the test on Windows.

R=brainman, alex.brainman
CC=golang-dev
https://golang.org/cl/2244041

14 years agopkg/Makefile: disable netchan test to fix windows build
Alex Brainman [Sat, 18 Sep 2010 01:09:08 +0000 (11:09 +1000)]
pkg/Makefile: disable netchan test to fix windows build

R=r
CC=golang-dev
https://golang.org/cl/2225042

14 years agodoc: fix typo in go_for_cpp_programmers.html
Andrew Gerrand [Fri, 17 Sep 2010 02:39:01 +0000 (12:39 +1000)]
doc: fix typo in go_for_cpp_programmers.html

R=rsc, gri
CC=golang-dev
https://golang.org/cl/2191043

14 years agoos: make RemoveAll() work on windows
Alex Brainman [Fri, 17 Sep 2010 02:35:34 +0000 (12:35 +1000)]
os: make RemoveAll() work on windows

R=golang-dev, rsc1
CC=golang-dev
https://golang.org/cl/2212041

14 years agofix various comments
Robert Griesemer [Fri, 17 Sep 2010 01:21:01 +0000 (18:21 -0700)]
fix various comments

(os package comments were duplicates)

R=rsc
CC=golang-dev
https://golang.org/cl/2205042

14 years agoadd readonly flag to static initialization
Ken Thompson [Thu, 16 Sep 2010 23:42:38 +0000 (16:42 -0700)]
add readonly flag to static initialization

R=rsc
CC=golang-dev
https://golang.org/cl/2187042

14 years agonetchan: add a cross-connect test.
Rob Pike [Thu, 16 Sep 2010 21:12:54 +0000 (07:12 +1000)]
netchan: add a cross-connect test.
Suggested in a bug report (since addressed) by Axel Schreiner.

R=rsc
CC=golang-dev
https://golang.org/cl/2228041

14 years agogodoc: show "Last update" info for directory listings.
Robert Griesemer [Thu, 16 Sep 2010 20:45:40 +0000 (13:45 -0700)]
godoc: show "Last update" info for directory listings.

Use -timestamps=false flag to disable.

(This used to be shown on the front-page below the
build information with the old godoc. However, the
time stamps are directory-specific and should be
shown with the directory.)

R=rsc
CC=golang-dev
https://golang.org/cl/2233044

14 years agogc: spell debug['u'] correctly
Russ Cox [Thu, 16 Sep 2010 19:50:46 +0000 (15:50 -0400)]
gc: spell debug['u'] correctly

R=ken2
CC=golang-dev
https://golang.org/cl/2214042

14 years agogc: make sure path names are canonical
Russ Cox [Thu, 16 Sep 2010 19:37:57 +0000 (15:37 -0400)]
gc: make sure path names are canonical

R=ken2
CC=golang-dev
https://golang.org/cl/2209042

14 years agogofmt: add another exception to test cases
Robert Griesemer [Thu, 16 Sep 2010 18:03:28 +0000 (11:03 -0700)]
gofmt: add another exception to test cases

R=rsc
CC=golang-dev
https://golang.org/cl/2233043

14 years agogodoc: don't use quadratic algorithm to filter paths
Robert Griesemer [Thu, 16 Sep 2010 17:40:07 +0000 (10:40 -0700)]
godoc: don't use quadratic algorithm to filter paths

R=rsc
CC=golang-dev
https://golang.org/cl/2212042

14 years agocgo: show preamble gcc errors
Eric Clark [Thu, 16 Sep 2010 17:38:23 +0000 (13:38 -0400)]
cgo: show preamble gcc errors

Fixes #1081

R=rsc
CC=golang-dev
https://golang.org/cl/2112046

14 years agonet/dict: parse response correctly + typo
Fazlul Shahriar [Thu, 16 Sep 2010 17:37:35 +0000 (13:37 -0400)]
net/dict: parse response correctly + typo

* SHOW DB responds with a
  "110 n databases present - text follows" -- parse it.
* Doing a Define() on a non-existing word gives error
  "invalid definition count: no", when we really
  want "552 no match".

R=rsc
CC=golang-dev
https://golang.org/cl/2211041

14 years agotag release.2010-09-15
Andrew Gerrand [Thu, 16 Sep 2010 04:04:34 +0000 (14:04 +1000)]
tag release.2010-09-15

R=r
CC=golang-dev
https://golang.org/cl/2213042

14 years agorelease.2010-09-15 weekly.2010-09-15
Andrew Gerrand [Thu, 16 Sep 2010 04:02:24 +0000 (14:02 +1000)]
release.2010-09-15

R=r
CC=golang-dev
https://golang.org/cl/2227041

14 years agogolang.org redesign
Andrew Gerrand [Thu, 16 Sep 2010 04:01:02 +0000 (14:01 +1000)]
golang.org redesign

R=r, rsc, gri
CC=golang-dev, iant, ken2, lvd, nigeltao_golang, stephenm
https://golang.org/cl/2182042

14 years agonetchan: fix bug for imported send.
Rob Pike [Thu, 16 Sep 2010 03:59:31 +0000 (13:59 +1000)]
netchan: fix bug for imported send.
Also add a bit of debugging and sanitation code.
Fixes #769.

R=adg
CC=golang-dev
https://golang.org/cl/2206042

14 years agofix build
Robert Griesemer [Thu, 16 Sep 2010 00:00:00 +0000 (17:00 -0700)]
fix build

R=iant
CC=golang-dev, ken2
https://golang.org/cl/2182043

14 years agoos: error in documentation
Robert Griesemer [Wed, 15 Sep 2010 22:38:16 +0000 (15:38 -0700)]
os: error in documentation

R=r
CC=golang-dev
https://golang.org/cl/2225041

14 years agogodoc: only show directories containing true package files
Robert Griesemer [Wed, 15 Sep 2010 22:07:52 +0000 (15:07 -0700)]
godoc: only show directories containing true package files

(ignore directories containing *.go files that don't
actually start with a package clause)

R=r
CC=golang-dev
https://golang.org/cl/2223041

14 years agofix line number printing
Ken Thompson [Wed, 15 Sep 2010 21:32:09 +0000 (14:32 -0700)]
fix line number printing
with //line directives.

R=rsc
CC=golang-dev
https://golang.org/cl/2224041

14 years agolibmach: fix build on arm host
Russ Cox [Wed, 15 Sep 2010 20:52:11 +0000 (16:52 -0400)]
libmach: fix build on arm host

Fixes #1079.

R=r, trufae, fgergo
CC=golang-dev
https://golang.org/cl/2103048

14 years agonetchan: make -1 unlimited, as advertised.
Rob Pike [Wed, 15 Sep 2010 06:41:37 +0000 (23:41 -0700)]
netchan: make -1 unlimited, as advertised.

R=adg
CC=golang-dev
https://golang.org/cl/2198042

14 years agogodoc: better handling of deep directory trees
Robert Griesemer [Wed, 15 Sep 2010 01:58:09 +0000 (18:58 -0700)]
godoc: better handling of deep directory trees

also: fix a logic error with filter use at startup

R=rsc
CC=golang-dev
https://golang.org/cl/2184044

14 years agogodoc: atomically update filter file
Robert Griesemer [Tue, 14 Sep 2010 23:54:38 +0000 (16:54 -0700)]
godoc: atomically update filter file

R=rsc
CC=golang-dev
https://golang.org/cl/2206041

14 years agogodoc: use correct delay time (bug fix)
Robert Griesemer [Tue, 14 Sep 2010 20:59:45 +0000 (13:59 -0700)]
godoc: use correct delay time (bug fix)

R=rsc
CC=golang-dev
https://golang.org/cl/2201041

14 years agogodoc documentation: fixed typo, more precise comment
Robert Griesemer [Tue, 14 Sep 2010 19:03:26 +0000 (12:03 -0700)]
godoc documentation: fixed typo, more precise comment

R=iant
CC=golang-dev
https://golang.org/cl/2184042

14 years agogodoc: better support for directory trees for user-defined
Robert Griesemer [Tue, 14 Sep 2010 18:16:36 +0000 (11:16 -0700)]
godoc: better support for directory trees for user-defined
       file systems provided via -path

R=rsc
CC=golang-dev
https://golang.org/cl/2182041

14 years agotabs
Russ Cox [Tue, 14 Sep 2010 15:16:57 +0000 (11:16 -0400)]
tabs

TBR=lvd
CC=golang-dev
https://golang.org/cl/2194041

14 years ago6l, 8l: make etext accurate; introduce rodata, erodata.
Russ Cox [Tue, 14 Sep 2010 15:13:04 +0000 (11:13 -0400)]
6l, 8l: make etext accurate; introduce rodata, erodata.

Makes binaries work with 6cov again.

R=ken2
CC=golang-dev
https://golang.org/cl/2192041

14 years agoPreliminary support for 'copy' builtin function in exp/eval
Sebastien Binet [Tue, 14 Sep 2010 07:25:34 +0000 (17:25 +1000)]
Preliminary support for 'copy' builtin function in exp/eval

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/2157042

14 years agoCLA for Sebastien Binet
Rob Pike [Tue, 14 Sep 2010 07:24:29 +0000 (17:24 +1000)]
CLA for Sebastien Binet

R=adg
CC=binet, golang-dev
https://golang.org/cl/2188041

14 years agodoc: fix typo in Programming FAQ
Andrew Gerrand [Tue, 14 Sep 2010 03:33:27 +0000 (13:33 +1000)]
doc: fix typo in Programming FAQ

R=rsc, r2
CC=golang-dev
https://golang.org/cl/2186041

14 years agofmt.Fscan: use UnreadRune to preserve data across calls.
Rob Pike [Tue, 14 Sep 2010 01:06:17 +0000 (11:06 +1000)]
fmt.Fscan: use UnreadRune to preserve data across calls.
Fixes #1055.
(About as well as it can be fixed without changing the API.)

R=rsc
CC=golang-dev
https://golang.org/cl/2156047

14 years agogc: implement new comparison rule
Russ Cox [Mon, 13 Sep 2010 19:42:47 +0000 (15:42 -0400)]
gc: implement new comparison rule

The new comparison rule was added to the spec by

changeset:   5605:33abb649cb63
user:        Robert Griesemer <gri@golang.org>
date:        Thu Jun 03 16:55:50 2010 -0700
files:       doc/go_spec.html
description:
go spec: Base comparison compatibility on assignment compatibility.

Specifically:
- Simplified definition of comparison compatibility and folded into
  section on comparison operators since it's only used there.

This is a small language change/cleanup. As a consequence:
- An interface value may now be compared against a non-interface value.
- Channels with opposite directions cannot be compared directly anymore
  (per discussion with rsc).

R=rsc, r, iant, ken2
CC=golang-dev
https://golang.org/cl/1462041

but never implemented.

Fixes #1070.

R=ken2
CC=golang-dev
https://golang.org/cl/2116047

14 years agogc: bug306
Russ Cox [Mon, 13 Sep 2010 19:42:14 +0000 (15:42 -0400)]
gc: bug306

Fixes #1040.

R=ken2
CC=golang-dev
https://golang.org/cl/2132047

14 years agoA+C: Kai Backman (individual CLA)
Russ Cox [Mon, 13 Sep 2010 19:41:47 +0000 (15:41 -0400)]
A+C: Kai Backman (individual CLA)

Just AUTHORS; already in CONTRIBUTORS from work at Google.

R=gri
CC=golang-dev
https://golang.org/cl/2098048

14 years agojson: Add package comment
Scott Lawrence [Mon, 13 Sep 2010 06:03:27 +0000 (16:03 +1000)]
json: Add package comment

R=golang-dev, r2, r
CC=golang-dev
https://golang.org/cl/2149047

14 years agogo-mode.el: Fix highlighting for 'chan' type
Scott Lawrence [Mon, 13 Sep 2010 04:12:18 +0000 (00:12 -0400)]
go-mode.el: Fix highlighting for 'chan' type
Fixes #1038.

R=aclements, rsc
CC=golang-dev
https://golang.org/cl/2111046

14 years ago(windows) disable tests that cause the build to fail
Joe Poirier [Mon, 13 Sep 2010 03:36:51 +0000 (13:36 +1000)]
(windows) disable tests that cause the build to fail

R=rsc, brainman
CC=golang-dev
https://golang.org/cl/2171044

14 years agoarm tests: disable zerodivide.go: compilation fails.
Rob Pike [Mon, 13 Sep 2010 03:19:25 +0000 (13:19 +1000)]
arm tests: disable zerodivide.go: compilation fails.
Hope to fix the build.

R=rsc
CC=golang-dev
https://golang.org/cl/2140048

14 years agolibcgo: fix NaCl build.
Nigel Tao [Mon, 13 Sep 2010 03:12:46 +0000 (13:12 +1000)]
libcgo: fix NaCl build.

R=r, rsc, nigeltao
CC=golang-dev
https://golang.org/cl/2110046

14 years agogoinstall: warn when http:// is found at beginning of package name
Scott Lawrence [Mon, 13 Sep 2010 02:59:59 +0000 (12:59 +1000)]
goinstall: warn when http:// is found at beginning of package name
Fixes #860.

R=golang-dev, adg1, rsc, adg
CC=golang-dev
https://golang.org/cl/2124046

14 years agomisc/dashboard/builder: gobuilder, a continuous build client
Andrew Gerrand [Mon, 13 Sep 2010 00:46:17 +0000 (10:46 +1000)]
misc/dashboard/builder: gobuilder, a continuous build client

R=rsc
CC=golang-dev
https://golang.org/cl/2126042

14 years agogc: fix symbol table generation on windows
Alex Brainman [Sun, 12 Sep 2010 08:07:13 +0000 (18:07 +1000)]
gc: fix symbol table generation on windows

gc records full, '/' delimited, filenames now.

R=rsc
CC=golang-dev
https://golang.org/cl/1962042

14 years agobufio: add UnreadRune.
Rob Pike [Sun, 12 Sep 2010 07:40:27 +0000 (17:40 +1000)]
bufio: add UnreadRune.

R=rsc
CC=golang-dev
https://golang.org/cl/2103046

14 years agoexec.LookPath() unix/windows separation
Joe Poirier [Sun, 12 Sep 2010 07:38:36 +0000 (17:38 +1000)]
exec.LookPath() unix/windows separation

R=brainman, rsc, vcc, rsc1
CC=golang-dev
https://golang.org/cl/2068041

14 years agolibmach: fix whitespace.
Nigel Tao [Sun, 12 Sep 2010 06:40:31 +0000 (16:40 +1000)]
libmach: fix whitespace.

R=rsc, r
CC=golang-dev
https://golang.org/cl/2149046

14 years agotest: Make gccgo believe that the variables can change.
Ian Lance Taylor [Sun, 12 Sep 2010 05:51:05 +0000 (22:51 -0700)]
test: Make gccgo believe that the variables can change.

This test is supposed to test runtime behaviour.  However,
gccgo is smart enough to see that the variables are local to
the package and that they never change.  Add a function so
that gccgo thinks that the variables can in fact vary, so that
the test works at runtime as expected.

R=rsc
CC=golang-dev
https://golang.org/cl/2178041

14 years agogc: make string x + y + z + ... + w efficient
Russ Cox [Sun, 12 Sep 2010 04:53:04 +0000 (00:53 -0400)]
gc: make string x + y + z + ... + w efficient

1 malloc per concatenation.

R=ken2
CC=golang-dev
https://golang.org/cl/2124045

14 years ago6g, 6l, 8g, 8l: move read-only data to text segment
Russ Cox [Sun, 12 Sep 2010 04:17:44 +0000 (00:17 -0400)]
6g, 6l, 8g, 8l: move read-only data to text segment

Changing 5g and 5l too, but it doesn't work yet.

R=ken2
CC=golang-dev
https://golang.org/cl/2136047

14 years ago5g: register allocation bugs
Russ Cox [Sun, 12 Sep 2010 04:06:45 +0000 (00:06 -0400)]
5g: register allocation bugs

Fixes #1099.

R=ken2, r
CC=golang-dev
https://golang.org/cl/2147047

14 years agocodereview: convert email address from Rietveld to lower case
Russ Cox [Sun, 12 Sep 2010 03:42:29 +0000 (23:42 -0400)]
codereview: convert email address from Rietveld to lower case
before looking for it in the CONTRIBUTORS file

R=r
CC=golang-dev
https://golang.org/cl/1883049

14 years agolibmach: fix new thread race with Linux
Russ Cox [Sun, 12 Sep 2010 03:42:04 +0000 (23:42 -0400)]
libmach: fix new thread race with Linux

If you look at the sequence of values returned
by waitpid, it simply tells us about the child of
clone before it tells us that the parent called clone.
There's nothing we can do but assume unexpected
tids are newly cloned children.

Tested with 6prof on godoc.

Fixes #251.

R=r
CC=golang-dev
https://golang.org/cl/2167045

14 years agobuild: avoid bad environment interactions
Russ Cox [Sun, 12 Sep 2010 03:41:40 +0000 (23:41 -0400)]
build: avoid bad environment interactions

Specifically, $LIB is set on Windows.

Also diagnose attempt to build GOOS=darwin GOARCH=arm.
Otherwise the build fails mysteriously in package runtime.

Fixes #1065.

R=r
CC=golang-dev
https://golang.org/cl/2162043

14 years agomath: make portable Tan(Pi/2) return NaN
Russ Cox [Sun, 12 Sep 2010 03:41:25 +0000 (23:41 -0400)]
math: make portable Tan(Pi/2) return NaN

The panic NaN was a translation error.
The earliest version said panic "return sys.NaN()",
and when sys.NaN came along, it changed
to "panic sys.NaN()" instead of "return sys.NaN()".

R=r
CC=golang-dev
https://golang.org/cl/2106049

14 years agohttp: check https certificate against host name
Russ Cox [Sun, 12 Sep 2010 03:41:12 +0000 (23:41 -0400)]
http: check https certificate against host name

Fixes #1093.

R=agl, agl1
CC=golang-dev
https://golang.org/cl/2115045

14 years agoarm: make libcgo build during OS X cross-compile
Russ Cox [Sun, 12 Sep 2010 03:36:06 +0000 (23:36 -0400)]
arm: make libcgo build during OS X cross-compile

The gcc on OS X seems pickier about noticing
symbols that are referred to but not found during
the link of a .so file.

R=r
CC=golang-dev
https://golang.org/cl/2098047

14 years agonet: disable tests for functions not available on windows
Alex Brainman [Sun, 12 Sep 2010 02:02:29 +0000 (12:02 +1000)]
net: disable tests for functions not available on windows

R=r, Joe Poirier, rsc
CC=golang-dev
https://golang.org/cl/2123044

14 years agoruntime(windows): make sure scheduler runs on os stack and new stdcall implementation
Alex Brainman [Sun, 12 Sep 2010 01:45:16 +0000 (11:45 +1000)]
runtime(windows): make sure scheduler runs on os stack and new stdcall implementation

R=rsc
CC=golang-dev
https://golang.org/cl/2009045

14 years agogc: const nil bug
Russ Cox [Sat, 11 Sep 2010 19:47:56 +0000 (15:47 -0400)]
gc: const nil bug

Fixes #1073.

R=ken2
CC=golang-dev
https://golang.org/cl/2169043

14 years agoarm build: try to fix it by removing reference to deleted file syntax/slice.go
Rob Pike [Sat, 11 Sep 2010 06:10:28 +0000 (23:10 -0700)]
arm build: try to fix it by removing reference to deleted file syntax/slice.go

R=rsc
CC=golang-dev
https://golang.org/cl/2127046

14 years agowebsocket: Add support for secure WebSockets
Jukka-Pekka Kekkonen [Sat, 11 Sep 2010 04:27:16 +0000 (00:27 -0400)]
websocket: Add support for secure WebSockets

Fixes #842.
Fixes #1061.

R=rsc
CC=golang-dev
https://golang.org/cl/2119042

14 years agoruntime: fix crash trace on amd64
Russ Cox [Sat, 11 Sep 2010 04:26:56 +0000 (00:26 -0400)]
runtime: fix crash trace on amd64

g is not in r15 anymore.
now it's in a per-thread memory segment,
which is valid even inside a signal handler,
so we can just refer to g directly.

Fixes #1082.

R=r
CC=golang-dev
https://golang.org/cl/2149045

14 years agoarm: work around reg allocator bug in 5g, in two parts.
Rob Pike [Sat, 11 Sep 2010 03:55:29 +0000 (20:55 -0700)]
arm: work around reg allocator bug in 5g, in two parts.
1) hack regalloc to leave R9 (m) and R10 (g) alone.
the real fix is tricker, but this gets us running
2) fix up the few places in the package sources that
the shortage of registers affects, by simplifying
some expressions.

all of this should be reverted when the right fix is in.

Fixes #1084.

R=rsc
CC=golang-dev
https://golang.org/cl/2132046

14 years agotest: Add test for //line (currently fails).
Ian Lance Taylor [Sat, 11 Sep 2010 02:12:43 +0000 (19:12 -0700)]
test: Add test for //line (currently fails).

R=rsc
CC=golang-dev
https://golang.org/cl/2127045

14 years agotest: Match gccgo error messages.
Ian Lance Taylor [Sat, 11 Sep 2010 02:12:10 +0000 (19:12 -0700)]
test: Match gccgo error messages.

The gccgo compiler does not always generate a "cannot use"
error message.  It only does so for named types.  Maybe that
should change, but in any case it is irrelevant for this test.

assign1.go:105:4: error: incompatible types in assignment (cannot use type A1 as type A)
assign1.go:107:5: error: incompatible types in assignment (cannot use type A as type A1)
assign1.go:112:4: error: incompatible types in assignment (cannot use type B1 as type B)
assign1.go:114:5: error: incompatible types in assignment (cannot use type B as type B1)
assign1.go:119:4: error: incompatible types in assignment (cannot use type C1 as type C)
assign1.go:121:5: error: incompatible types in assignment (cannot use type C as type C1)
assign1.go:126:4: error: incompatible types in assignment (cannot use type F1 as type F)
assign1.go:128:5: error: incompatible types in assignment (cannot use type F as type F1)
assign1.go:140:4: error: incompatible types in assignment (cannot use type M1 as type M)
assign1.go:142:5: error: incompatible types in assignment (cannot use type M as type M1)
assign1.go:147:4: error: incompatible types in assignment (cannot use type P1 as type P)
assign1.go:149:5: error: incompatible types in assignment (cannot use type P as type P1)
assign1.go:154:4: error: incompatible types in assignment (cannot use type S1 as type S)
assign1.go:156:5: error: incompatible types in assignment (cannot use type S as type S1)
assign1.go:158:6: error: incompatible types in assignment
assign1.go:159:6: error: incompatible types in assignment
assign1.go:160:5: error: incompatible types in assignment
assign1.go:161:5: error: incompatible types in assignment
assign1.go:162:6: error: incompatible types in assignment
assign1.go:163:6: error: incompatible types in assignment
assign1.go:165:6: error: incompatible types in assignment
assign1.go:166:6: error: incompatible types in assignment
assign1.go:167:5: error: incompatible types in assignment
assign1.go:168:5: error: incompatible types in assignment
assign1.go:169:6: error: incompatible types in assignment
assign1.go:170:6: error: incompatible types in assignment
assign1.go:172:6: error: incompatible types in assignment
assign1.go:173:6: error: incompatible types in assignment
assign1.go:174:5: error: incompatible types in assignment
assign1.go:175:5: error: incompatible types in assignment
assign1.go:176:6: error: incompatible types in assignment
assign1.go:177:6: error: incompatible types in assignment
assign1.go:179:6: error: incompatible types in assignment
assign1.go:180:6: error: incompatible types in assignment
assign1.go:181:5: error: incompatible types in assignment
assign1.go:182:5: error: incompatible types in assignment
assign1.go:183:6: error: incompatible types in assignment
assign1.go:184:6: error: incompatible types in assignment
assign1.go:186:6: error: incompatible types in assignment
assign1.go:187:6: error: incompatible types in assignment
assign1.go:188:5: error: incompatible types in assignment
assign1.go:189:5: error: incompatible types in assignment
assign1.go:190:6: error: incompatible types in assignment
assign1.go:191:6: error: incompatible types in assignment
assign1.go:193:6: error: incompatible types in assignment
assign1.go:194:6: error: incompatible types in assignment
assign1.go:195:5: error: incompatible types in assignment
assign1.go:196:5: error: incompatible types in assignment
assign1.go:197:6: error: incompatible types in assignment
assign1.go:198:6: error: incompatible types in assignment
assign1.go:200:6: error: incompatible types in assignment
assign1.go:201:6: error: incompatible types in assignment
assign1.go:202:5: error: incompatible types in assignment
assign1.go:203:5: error: incompatible types in assignment
assign1.go:204:6: error: incompatible types in assignment
assign1.go:205:6: error: incompatible types in assignment
assign1.go:207:6: error: incompatible types in assignment
assign1.go:208:6: error: incompatible types in assignment
assign1.go:209:5: error: incompatible types in assignment
assign1.go:210:5: error: incompatible types in assignment
assign1.go:211:6: error: incompatible types in assignment
assign1.go:212:6: error: incompatible types in assignment

R=rsc
CC=golang-dev
https://golang.org/cl/2163044

14 years agotest: Run garbage collector before testing malloc numbers.
Ian Lance Taylor [Fri, 10 Sep 2010 22:54:16 +0000 (15:54 -0700)]
test: Run garbage collector before testing malloc numbers.

The gccgo library generates some garbage in the init routines
because it handles interfaces slightly differently.  Since the
test sets MemStats.Alloc to 0, the first time the garbage
collector runs it goes negative and the test fails.

R=rsc, r2
CC=golang-dev
https://golang.org/cl/2110044

14 years agotest: Reduce race conditions in chan/nonblock.go.
Ian Lance Taylor [Fri, 10 Sep 2010 22:37:20 +0000 (15:37 -0700)]
test: Reduce race conditions in chan/nonblock.go.

nonblock.go wants to test nonblocking operations on
synchronous channels, so it is inherently racy.  This
introduces loops to make the race conditions much more likely
to succeed when using gccgo.

R=r
CC=golang-dev
https://golang.org/cl/2161043

14 years agocrypto/tls: don't return an error from Close()
Adam Langley [Fri, 10 Sep 2010 19:55:35 +0000 (15:55 -0400)]
crypto/tls: don't return an error from Close()

Fixes #1037.

R=adg, rsc1
CC=golang-dev
https://golang.org/cl/2107048

14 years agonet: fix windows build
Russ Cox [Fri, 10 Sep 2010 19:50:29 +0000 (15:50 -0400)]
net: fix windows build

R=adg
CC=golang-dev
https://golang.org/cl/2111045

14 years agotest: Match gccgo error messages.
Ian Lance Taylor [Fri, 10 Sep 2010 19:45:46 +0000 (12:45 -0700)]
test: Match gccgo error messages.

gccgo does not handle 'new' specially here.

varerr.go:10:6: error: reference to undefined name ‘asdf’
varerr.go:12:6: error: invalid left hand side of assignment

R=rsc
CC=golang-dev
https://golang.org/cl/2139045

14 years agotest: Match gccgo error messages.
Ian Lance Taylor [Fri, 10 Sep 2010 19:44:37 +0000 (12:44 -0700)]
test: Match gccgo error messages.

undef.go:12:6: error: reference to undefined name ‘x’
undef.go:13:6: error: reference to undefined name ‘x’
undef.go:14:6: error: reference to undefined name ‘x’
undef.go:22:25: error: reference to undefined name ‘y’
undef.go:42:11: error: reference to undefined name ‘v’

R=rsc
CC=golang-dev
https://golang.org/cl/2152045

14 years agotest: Match gccgo error messages.
Ian Lance Taylor [Fri, 10 Sep 2010 19:44:07 +0000 (12:44 -0700)]
test: Match gccgo error messages.

vareq.go:10:25: error: expected ';' or '}' or newline

vareq1.go:9:24: error: expected ';' or newline after top level declaration

R=rsc
CC=golang-dev
https://golang.org/cl/2132045

14 years agonet: fix freebsd build
Russ Cox [Fri, 10 Sep 2010 18:40:56 +0000 (14:40 -0400)]
net: fix freebsd build

R=adg
CC=golang-dev
https://golang.org/cl/2174043

14 years agowindows: disable unimplemented tests
Joe Poirier [Fri, 10 Sep 2010 18:05:57 +0000 (14:05 -0400)]
windows: disable unimplemented tests

Add windows NOTEST list to pkg make file.
5a make file. the change removes a space
character that was included when appending
an extension to TARG.

R=brainman, rsc
CC=golang-dev
https://golang.org/cl/2140046

14 years agold: handle quoted spaces in package path
Dan Sinclair [Fri, 10 Sep 2010 17:59:20 +0000 (13:59 -0400)]
ld: handle quoted spaces in package path

Fixes #1087.

R=rsc
CC=golang-dev
https://golang.org/cl/2172041

14 years agoA+C: add Dan Sinclair (individual CLA)
Russ Cox [Fri, 10 Sep 2010 17:59:08 +0000 (13:59 -0400)]
A+C: add Dan Sinclair (individual CLA)

R=r
CC=golang-dev
https://golang.org/cl/2140045

14 years ago6c, 8c: show line numbers in -S output
Russ Cox [Fri, 10 Sep 2010 15:53:51 +0000 (11:53 -0400)]
6c, 8c: show line numbers in -S output

R=ken2
CC=golang-dev
https://golang.org/cl/2107047

14 years agogc: remove &[10]int -> []int conversion
Russ Cox [Fri, 10 Sep 2010 15:53:27 +0000 (11:53 -0400)]
gc: remove &[10]int -> []int conversion

Fixes #829.

R=ken2
CC=golang-dev
https://golang.org/cl/2124044

14 years agoexp/draw: fast path for drawing overlapping image.RGBAs.
Nigel Tao [Fri, 10 Sep 2010 10:09:56 +0000 (20:09 +1000)]
exp/draw: fast path for drawing overlapping image.RGBAs.

R=r, nigeltao
CC=golang-dev
https://golang.org/cl/2145045

14 years agoexp/draw: fix double-counting of pt.Min for the src and mask points.
Nigel Tao [Fri, 10 Sep 2010 09:48:27 +0000 (19:48 +1000)]
exp/draw: fix double-counting of pt.Min for the src and mask points.
The min is typically zero, which is why this hasn't bitten us yet.

R=r
CC=golang-dev
https://golang.org/cl/2119048

14 years agoarm: fix a couple of build bugs.
Rob Pike [Fri, 10 Sep 2010 06:31:33 +0000 (23:31 -0700)]
arm: fix a couple of build bugs.
tests have not been run yet

R=stephenm
CC=golang-dev
https://golang.org/cl/2165046

14 years agotest: Match gccgo error messages.
Ian Lance Taylor [Fri, 10 Sep 2010 05:40:25 +0000 (22:40 -0700)]
test: Match gccgo error messages.

With the recursive descent parser that gccgo uses, I think
that it doesn't make sense to try to match a statement where a
statement is not expected.  If the construct is not a
statement, you will just get bizarre error messages.

topexpr.go:9:1: error: expected declaration
topexpr.go:14:1: error: expected declaration
topexpr.go:19:1: error: expected declaration

R=rsc, r2
CC=golang-dev
https://golang.org/cl/2175041

14 years agosyscall: fix windows Gettimeofday
Alex Brainman [Fri, 10 Sep 2010 05:39:45 +0000 (15:39 +1000)]
syscall: fix windows Gettimeofday

Fixes #1092.

R=golang-dev, r2
CC=golang-dev
https://golang.org/cl/2121048

14 years agodoc/tutorial: update for slice changes.
Rob Pike [Fri, 10 Sep 2010 03:53:18 +0000 (13:53 +1000)]
doc/tutorial: update for slice changes.
Awaiting the lower-bound change before checkin.

Fixes #1067.

R=rsc, iant, gri
CC=golang-dev
https://golang.org/cl/2105043

14 years agofix build
Robert Griesemer [Thu, 9 Sep 2010 21:42:49 +0000 (14:42 -0700)]
fix build

R=rsc, ken2
CC=golang-dev
https://golang.org/cl/2118050

14 years agogc: more accurate line numbers for ATEXT
Russ Cox [Thu, 9 Sep 2010 21:11:51 +0000 (17:11 -0400)]
gc: more accurate line numbers for ATEXT
and other begin and end of function code

R=ken2
CC=golang-dev
https://golang.org/cl/2158044

14 years agotest: Match gccgo error messages.
Ian Lance Taylor [Thu, 9 Sep 2010 16:00:32 +0000 (09:00 -0700)]
test: Match gccgo error messages.

tmp.go:4:20: error: invalid NUL byte
tmp.go:6:24: error: invalid NUL byte
tmp.go:8:15: error: invalid NUL byte
tmp.go:10:21: error: invalid NUL byte
tmp.go:12:22: error: invalid NUL byte
tmp.go:14:21: error: invalid UTF-8 encoding
tmp.go:14:22: error: invalid UTF-8 encoding
tmp.go:16:25: error: invalid UTF-8 encoding
tmp.go:18:15: error: invalid UTF-8 encoding
tmp.go:18:16: error: invalid UTF-8 encoding
tmp.go:20:21: error: invalid UTF-8 encoding
tmp.go:20:22: error: invalid NUL byte
tmp.go:20:23: error: invalid NUL byte
tmp.go:23:6: error: invalid UTF-8 encoding
tmp.go:23:7: error: invalid UTF-8 encoding
tmp.go:25:22: error: invalid UTF-8 encoding

R=rsc
CC=golang-dev
https://golang.org/cl/2151046

14 years agoexp/draw: clip destination rectangle to the image bounds.
Nigel Tao [Thu, 9 Sep 2010 09:12:54 +0000 (19:12 +1000)]
exp/draw: clip destination rectangle to the image bounds.
image: introduce Intersect and Union rectangle methods.

R=r, rog, nigeltao
CC=golang-dev
https://golang.org/cl/2115043

14 years agoexp/draw: rename Context to Window, and add a Close method.
Nigel Tao [Thu, 9 Sep 2010 08:06:59 +0000 (18:06 +1000)]
exp/draw: rename Context to Window, and add a Close method.
exp/draw/x11: allow clean shutdown when the user closes the window.

R=r
CC=golang-dev
https://golang.org/cl/2134045

14 years agobuild: generate, clean .exe files on Windows
Joe Poirier [Thu, 9 Sep 2010 05:42:55 +0000 (01:42 -0400)]
build: generate, clean .exe files on Windows

R=rsc, brainman, vcc
CC=golang-dev
https://golang.org/cl/2165044

14 years agotest: remove slice syntax test
Scott Lawrence [Thu, 9 Sep 2010 05:42:49 +0000 (01:42 -0400)]
test: remove slice syntax test

R=rsc
CC=golang-dev
https://golang.org/cl/2145043

14 years agopath: add IsAbs
Ivan Krasin [Thu, 9 Sep 2010 05:42:43 +0000 (01:42 -0400)]
path: add IsAbs

R=rsc, imkrasin, r
CC=golang-dev
https://golang.org/cl/1969042

14 years agoMake.inc: fix build for tiny.
Rob Pike [Thu, 9 Sep 2010 05:14:38 +0000 (15:14 +1000)]
Make.inc: fix build for tiny.
Suggested by paulzhol@gmail.com

R=rsc
CC=golang-dev
https://golang.org/cl/2122049

14 years agogofmt, go/printer: update internal estimated position correctly
Robert Griesemer [Thu, 9 Sep 2010 05:01:48 +0000 (22:01 -0700)]
gofmt, go/printer: update internal estimated position correctly

Fixes #1089.

R=rsc
CC=golang-dev
https://golang.org/cl/2172043

14 years agoruntime: fix bug in tracebacks
Rob Pike [Thu, 9 Sep 2010 04:28:56 +0000 (14:28 +1000)]
runtime: fix bug in tracebacks
Need to correct for deferproc's extra 2 words of stack or in some
cases (such as memory profiling) traceback can cause a crash.
Also bulletproof the closure test.

R=rsc
CC=golang-dev
https://golang.org/cl/2138047

14 years agotest: Match gccgo error messages.
Ian Lance Taylor [Thu, 9 Sep 2010 04:03:51 +0000 (21:03 -0700)]
test: Match gccgo error messages.

named1.go:40:11: error: argument 1 has incompatible type (cannot use type bool as type Bool)
named1.go:41:11: error: argument 1 has incompatible type (cannot use type bool as type Bool)
named1.go:43:7: error: incompatible types in assignment (cannot use type bool as type Bool)
named1.go:44:12: error: argument 4 has incompatible type (cannot use type Bool as type bool)
named1.go:46:4: error: incompatible types in assignment (cannot use type bool as type Bool)
named1.go:48:11: error: argument 1 has incompatible type (cannot use type bool as type Bool)
named1.go:50:7: error: incompatible types in assignment (cannot use type bool as type Bool)
named1.go:54:7: error: incompatible types in assignment (cannot use type bool as type Bool)
named1.go:60:7: error: incompatible types in assignment (cannot use type bool as type Bool)
named1.go:63:9: error: argument 1 has incompatible type (cannot use type bool as type Bool)
named1.go:64:4: error: incompatible types in assignment (cannot use type bool as type Bool)
named1.go:67:17: error: invalid type conversion (cannot use type Slice as type String)

R=rsc
CC=golang-dev
https://golang.org/cl/2146044

14 years agotest: Match gccgo error messages.
Ian Lance Taylor [Thu, 9 Sep 2010 04:03:24 +0000 (21:03 -0700)]
test: Match gccgo error messages.

explicit.go:36:4: error: incompatible types in assignment (need explicit conversion)
explicit.go:41:4: error: incompatible types in assignment (type has no methods)
explicit.go:42:4: error: incompatible types in assignment (need explicit conversion)
explicit.go:45:5: error: incompatible types in assignment (need explicit conversion; missing method ‘N’)
explicit.go:48:9: error: invalid type conversion (need explicit conversion; missing method ‘N’)
explicit.go:51:4: error: incompatible types in assignment
explicit.go:51:7: error: invalid type conversion (need explicit conversion)
explicit.go:57:10: error: impossible type assertion: type does not implement interface (type has no methods)
explicit.go:62:10: error: impossible type assertion: type does not implement interface (incompatible type for method ‘M’ (different number of parameters))
explicit.go:67:5: error: incompatible type in initialization (type has no methods)
explicit.go:68:5: error: incompatible type in initialization (incompatible type for method ‘M’ (different number of parameters))
explicit.go:70:11: error: invalid type conversion (type has no methods)
explicit.go:71:11: error: invalid type conversion (incompatible type for method ‘M’ (different number of parameters))

R=rsc
CC=golang-dev
https://golang.org/cl/2139044